You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2023/02/28 13:56:43 UTC
[GitHub] [arrow] raulcd opened a new issue, #34381: [Dev] PR Workflow incorrectly tagging for committer reviews
raulcd opened a new issue, #34381:
URL: https://github.com/apache/arrow/issues/34381
### Describe the bug, including details regarding any error messages, version, and platform.
Committer GitHub role is CONTRIBUTOR instead of MEMBER.
Example of event payload for event triggered from Committer:
```
"author_association": "CONTRIBUTOR",
```
### Component(s)
Developer Tools
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #34381: [Dev] PR Workflow incorrectly tagging committer reviews that have their Apache membership set to private
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #34381:
URL: https://github.com/apache/arrow/issues/34381#issuecomment-1451106573
We already have a commiter list: https://github.com/apache/arrow-site/blob/main/_data/committers.yml
Can we use this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on issue #34381: [Dev] PR Workflow incorrectly tagging committer reviews that have their Apache membership set to private
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #34381:
URL: https://github.com/apache/arrow/issues/34381#issuecomment-1449861058
I have tested giving all possible read permissions to the workflow and requesting via API instead of using the default payload event using the `secrets.GITHUB_TOKEN`. This token does not have permissions to read the organization members and if the member is private it won't appear as MEMBER.
I've done a test adding a new token with only `read:org` permissions which we could use to retrieve the membership. Something like the following:
```
def is_committer(self, review=False):
# We require a new connection to GitHub with a specific token to read
# membership association.
member_conn = github.Github(self._member_token)
repo = member_conn.get_repo(self.event_payload['repository']['id'], lazy=True)
gh_obj = repo.get_pull(self.event_payload['pull_request']['number'])
if review:
gh_obj = gh_obj.get_review(self.event_payload['review']['id'])
author_association = gh_obj.raw_data['author_association']
print(f"Author Association is {author_association}")
return author_association in COMMITTER_ROLES
```
This would work but would require to set up a new secret on our repo, something like `MEMBERSHIP_GITHUB_TOKEN`.
The only other solution I can think of is to have a list of committers and check the author name is on the list but that would require maintaining a list of committers.
@kou @assignUser any preference on any of the two solutions or other ideas you think I could try?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on issue #34381: [Dev] PR Workflow incorrectly tagging for committer reviews
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #34381:
URL: https://github.com/apache/arrow/issues/34381#issuecomment-1448294370
As pointed out by @assignUser this might have to do with some users setting their Apache role to private (https://github.com/orgs/apache/people) similar to: https://github.com/flutter/flutter/issues/101012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed issue #34381: [Dev] PR Workflow incorrectly tagging committer reviews that have their Apache membership set to private
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #34381: [Dev] PR Workflow incorrectly tagging committer reviews that have their Apache membership set to private
URL: https://github.com/apache/arrow/issues/34381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on issue #34381: [Dev] PR Workflow incorrectly tagging committer reviews that have their Apache membership set to private
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #34381:
URL: https://github.com/apache/arrow/issues/34381#issuecomment-1451623346
Thanks @kou I forgot this existed. Yes that should work. I'll take the committer GitHub usernames from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on issue #34381: [Dev] PR Workflow incorrectly tagging for committer reviews
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #34381:
URL: https://github.com/apache/arrow/issues/34381#issuecomment-1448257710
That is not exactly true. It seems to happen only for some committers. Maybe there's something wrong on the GitHub permissions?
For example we can see the event payload on a review made from me on this PR:
https://github.com/apache/arrow/actions/runs/4293861653
The `author_association` on the PR review comment is `MEMBER` but these two (made by @pitrou and @AlenkaF ) appear as if the review comment `author_assiciation` is `CONTRIBUTOR`:
https://github.com/apache/arrow/actions/runs/4293849744
https://github.com/apache/arrow/actions/runs/4293586215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on issue #34381: [Dev] PR Workflow incorrectly tagging committer reviews that have their Apache membership set to private
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #34381:
URL: https://github.com/apache/arrow/issues/34381#issuecomment-1451131160
Oh nice, as the list already exists and is even in yaml it should be easy to use!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org