You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Uri Moszkowicz (JIRA)" <ji...@codehaus.org> on 2006/10/26 07:00:03 UTC
[jira] Created: (CONTINUUM-971) Symbolic links are traversed on
deletion
Symbolic links are traversed on deletion
----------------------------------------
Key: CONTINUUM-971
URL: http://jira.codehaus.org/browse/CONTINUUM-971
Project: Continuum
Issue Type: Bug
Affects Versions: 1.0.3
Environment: Reproduced on Redhat Enterprise 4 but applicable to all forms of UNIX
Reporter: Uri Moszkowicz
Priority: Critical
To reproduce:
1. Create a project that checks out files from some SCM
2. Create a build script that creates symbolic links outside of the checked out project sandbox. This is often done to bring outside libraries into the project.
3. Delete the created project from the Continuum website. Notice how all kinds of files disappear from your file system!
>From looking at the release logs it looks like someone added follow symbolic links as the default and mentioned that at some point in the future an option should be added to disable this behavior. Following symbolic links is very dangerous and if supported it should be disabled by default, not the reverse. A warning should be posted in a visible place for the existing versions until this can be fixed as it can result in significant data loss outside of the Continuum program.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (CONTINUUM-971) Symbolic links are traversed on
deletion
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Venisse closed CONTINUUM-971.
--------------------------------------
Assignee: Emmanuel Venisse (was: Olivier Lamy)
Resolution: Fixed
Applied. Thanks
> Symbolic links are traversed on deletion
> ----------------------------------------
>
> Key: CONTINUUM-971
> URL: http://jira.codehaus.org/browse/CONTINUUM-971
> Project: Continuum
> Issue Type: Bug
> Components: Environmental
> Affects Versions: 1.0.3
> Environment: Reproduced on Redhat Enterprise 4 but applicable to all forms of UNIX
> Reporter: Uri Moszkowicz
> Assignee: Emmanuel Venisse
> Priority: Critical
> Fix For: 1.1-beta-2
>
> Attachments: CONTINUUM-971
>
>
> To reproduce:
> 1. Create a project that checks out files from some SCM
> 2. Create a build script that creates symbolic links outside of the checked out project sandbox. This is often done to bring outside libraries into the project.
> 3. Delete the created project from the Continuum website. Notice how all kinds of files disappear from your file system!
> From looking at the release logs it looks like someone added follow symbolic links as the default and mentioned that at some point in the future an option should be added to disable this behavior. Following symbolic links is very dangerous and if supported it should be disabled by default, not the reverse. A warning should be posted in a visible place for the existing versions until this can be fixed as it can result in significant data loss outside of the Continuum program.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CONTINUUM-971) Symbolic links are traversed on
deletion
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Venisse updated CONTINUUM-971:
---------------------------------------
Fix Version/s: (was: Future)
1.1-beta-2
We'll need to use FileSetManager from file-management artifact in maven shared.
> Symbolic links are traversed on deletion
> ----------------------------------------
>
> Key: CONTINUUM-971
> URL: http://jira.codehaus.org/browse/CONTINUUM-971
> Project: Continuum
> Issue Type: Bug
> Components: Environmental
> Affects Versions: 1.0.3
> Environment: Reproduced on Redhat Enterprise 4 but applicable to all forms of UNIX
> Reporter: Uri Moszkowicz
> Priority: Critical
> Fix For: 1.1-beta-2
>
>
> To reproduce:
> 1. Create a project that checks out files from some SCM
> 2. Create a build script that creates symbolic links outside of the checked out project sandbox. This is often done to bring outside libraries into the project.
> 3. Delete the created project from the Continuum website. Notice how all kinds of files disappear from your file system!
> From looking at the release logs it looks like someone added follow symbolic links as the default and mentioned that at some point in the future an option should be added to disable this behavior. Following symbolic links is very dangerous and if supported it should be disabled by default, not the reverse. A warning should be posted in a visible place for the existing versions until this can be fixed as it can result in significant data loss outside of the Continuum program.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CONTINUUM-971) Symbolic links are traversed on
deletion
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy updated CONTINUUM-971:
-----------------------------------
Attachment: CONTINUUM-971
patch attached.
> Symbolic links are traversed on deletion
> ----------------------------------------
>
> Key: CONTINUUM-971
> URL: http://jira.codehaus.org/browse/CONTINUUM-971
> Project: Continuum
> Issue Type: Bug
> Components: Environmental
> Affects Versions: 1.0.3
> Environment: Reproduced on Redhat Enterprise 4 but applicable to all forms of UNIX
> Reporter: Uri Moszkowicz
> Assignee: Olivier Lamy
> Priority: Critical
> Fix For: 1.1-beta-2
>
> Attachments: CONTINUUM-971
>
>
> To reproduce:
> 1. Create a project that checks out files from some SCM
> 2. Create a build script that creates symbolic links outside of the checked out project sandbox. This is often done to bring outside libraries into the project.
> 3. Delete the created project from the Continuum website. Notice how all kinds of files disappear from your file system!
> From looking at the release logs it looks like someone added follow symbolic links as the default and mentioned that at some point in the future an option should be added to disable this behavior. Following symbolic links is very dangerous and if supported it should be disabled by default, not the reverse. A warning should be posted in a visible place for the existing versions until this can be fixed as it can result in significant data loss outside of the Continuum program.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CONTINUUM-971) Symbolic links are traversed on
deletion
Posted by "Jesse McConnell (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-971?page=all ]
Jesse McConnell updated CONTINUUM-971:
--------------------------------------
Fix Version/s: 1.1
Component/s: Environmental
> Symbolic links are traversed on deletion
> ----------------------------------------
>
> Key: CONTINUUM-971
> URL: http://jira.codehaus.org/browse/CONTINUUM-971
> Project: Continuum
> Issue Type: Bug
> Components: Environmental
> Affects Versions: 1.0.3
> Environment: Reproduced on Redhat Enterprise 4 but applicable to all forms of UNIX
> Reporter: Uri Moszkowicz
> Priority: Critical
> Fix For: 1.1
>
>
> To reproduce:
> 1. Create a project that checks out files from some SCM
> 2. Create a build script that creates symbolic links outside of the checked out project sandbox. This is often done to bring outside libraries into the project.
> 3. Delete the created project from the Continuum website. Notice how all kinds of files disappear from your file system!
> From looking at the release logs it looks like someone added follow symbolic links as the default and mentioned that at some point in the future an option should be added to disable this behavior. Following symbolic links is very dangerous and if supported it should be disabled by default, not the reverse. A warning should be posted in a visible place for the existing versions until this can be fixed as it can result in significant data loss outside of the Continuum program.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-971) Symbolic links are traversed on
deletion
Posted by "Stephan Heinze (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_103338 ]
Stephan Heinze commented on CONTINUUM-971:
------------------------------------------
Modified problem with version 1.1-beta-1:
Symbolic links cause 'clean-working-directory' to fail. See Exception-StackTrace below.
Project is a shell project (usual automake/autoconf/libtool C++ project). Symbol link points to a file that was removed by the clean-task itself .. inside the project.
org.codehaus.plexus.taskqueue.execution.TaskExecutionException: Error executing action 'clean-working-directory'
at org.apache.maven.continuum.buildcontroller.DefaultBuildController.performAction(DefaultBuildController.java:432)
at org.apache.maven.continuum.buildcontroller.DefaultBuildController.cleanWorkingDirectory(DefaultBuildController.java:361)
at org.apache.maven.continuum.buildcontroller.DefaultBuildController.build(DefaultBuildController.java:103)
at org.apache.maven.continuum.buildcontroller.BuildProjectTaskExecutor.executeTask(BuildProjectTaskExecutor.java:50)
at org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable$1.run(ThreadedTaskQueueExecutor.java:116)
at edu.emory.mathcs.backport.java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:442)
at edu.emory.mathcs.backport.java.util.concurrent.FutureTask.run(FutureTask.java:176)
at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:665)
at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:690)
at java.lang.Thread.run(Thread.java:595)
Caused by: java.io.IOException: Directory /opt/continuum/working-directory/11/debug/xml/.libs unable to be deleted.
at org.codehaus.plexus.util.FileUtils.deleteDirectory(FileUtils.java:1390)
at org.codehaus.plexus.util.FileUtils.forceDelete(FileUtils.java:1215)
at org.codehaus.plexus.util.FileUtils.cleanDirectory(FileUtils.java:1429)
at org.codehaus.plexus.util.FileUtils.deleteDirectory(FileUtils.java:1386)
at org.codehaus.plexus.util.FileUtils.forceDelete(FileUtils.java:1215)
at org.codehaus.plexus.util.FileUtils.cleanDirectory(FileUtils.java:1429)
at org.codehaus.plexus.util.FileUtils.deleteDirectory(FileUtils.java:1386)
at org.codehaus.plexus.util.FileUtils.forceDelete(FileUtils.java:1215)
at org.codehaus.plexus.util.FileUtils.cleanDirectory(FileUtils.java:1429)
at org.apache.maven.continuum.core.action.CleanWorkingDirectoryAction.execute(CleanWorkingDirectoryAction.java:58)
at org.apache.maven.continuum.buildcontroller.DefaultBuildController.performAction(DefaultBuildController.java:406)
... 9 more
> Symbolic links are traversed on deletion
> ----------------------------------------
>
> Key: CONTINUUM-971
> URL: http://jira.codehaus.org/browse/CONTINUUM-971
> Project: Continuum
> Issue Type: Bug
> Components: Environmental
> Affects Versions: 1.0.3
> Environment: Reproduced on Redhat Enterprise 4 but applicable to all forms of UNIX
> Reporter: Uri Moszkowicz
> Priority: Critical
> Fix For: Future
>
>
> To reproduce:
> 1. Create a project that checks out files from some SCM
> 2. Create a build script that creates symbolic links outside of the checked out project sandbox. This is often done to bring outside libraries into the project.
> 3. Delete the created project from the Continuum website. Notice how all kinds of files disappear from your file system!
> From looking at the release logs it looks like someone added follow symbolic links as the default and mentioned that at some point in the future an option should be added to disable this behavior. Following symbolic links is very dangerous and if supported it should be disabled by default, not the reverse. A warning should be posted in a visible place for the existing versions until this can be fixed as it can result in significant data loss outside of the Continuum program.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CONTINUUM-971) Symbolic links are traversed on
deletion
Posted by "Jesse McConnell (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse McConnell updated CONTINUUM-971:
--------------------------------------
Fix Version/s: (was: 1.1-alpha-1)
1.1-alpha-#
> Symbolic links are traversed on deletion
> ----------------------------------------
>
> Key: CONTINUUM-971
> URL: http://jira.codehaus.org/browse/CONTINUUM-971
> Project: Continuum
> Issue Type: Bug
> Components: Environmental
> Affects Versions: 1.0.3
> Environment: Reproduced on Redhat Enterprise 4 but applicable to all forms of UNIX
> Reporter: Uri Moszkowicz
> Priority: Critical
> Fix For: 1.1-alpha-#
>
>
> To reproduce:
> 1. Create a project that checks out files from some SCM
> 2. Create a build script that creates symbolic links outside of the checked out project sandbox. This is often done to bring outside libraries into the project.
> 3. Delete the created project from the Continuum website. Notice how all kinds of files disappear from your file system!
> From looking at the release logs it looks like someone added follow symbolic links as the default and mentioned that at some point in the future an option should be added to disable this behavior. Following symbolic links is very dangerous and if supported it should be disabled by default, not the reverse. A warning should be posted in a visible place for the existing versions until this can be fixed as it can result in significant data loss outside of the Continuum program.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira