[GitHub] [incubator-doris] morningman commented on a change in pull request #1633: add zone map page(#1390)

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #1633: add zone map page(#1390)
URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316684220
 
 

 ##########
 File path: be/src/olap/rowset/segment_v2/row_ranges.h
 ##########
 @@ -0,0 +1,283 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <string>
+#include <vector>
+
+#include "common/logging.h"
+#include "olap/rowset/segment_v2/common.h"
+#include "gutil/strings/substitute.h"
+
+namespace doris {
+namespace segment_v2 {
+
+// RowRange stands for range[From, To), From is inclusive,
+// To is exclusive. It is used for row id range calculation.
+class RowRange {
+public:
+    // Returns true if if two ranges are overlapped or false.
 
 Review comment:
   ```suggestion
       // Returns true if two ranges are overlapped or false.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org