[GitHub] [inlong] healchow commented on a diff in pull request #7536: [INLONG-7535][Manager] Optimize the serializationType setting of PulsarSource to prevent NullPointerException

["healchow (via GitHub)" <gi...@apache.org>]

healchow commented on code in PR #7536:
URL: https://github.com/apache/inlong/pull/7536#discussion_r1127359072


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/pulsar/PulsarSourceOperator.java:
##########
@@ -131,8 +131,10 @@ public Map<String, List<StreamSource>> getSourcesMap(InlongGroupInfo groupInfo,
             pulsarSource.setAdminUrl(adminUrl);
             pulsarSource.setServiceUrl(serviceUrl);
             pulsarSource.setInlongComponent(true);
-            String serializationType = DataTypeEnum.forType(streamInfo.getDataType()).getType();
-            pulsarSource.setSerializationType(serializationType);
+            if (StringUtils.isNotBlank(streamInfo.getDataType())) {

Review Comment:
   @chestnut-c If the dataType was blank, do we need a default value for it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org