You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2023/01/09 07:58:52 UTC

[kudu-CR] [web] add maintenance op statistics information at web pages for data retained bytes

Yuqi Du has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19407


Change subject: [web] add maintenance op statistics information at web pages for data_retained_bytes
......................................................................

[web] add maintenance op statistics information at web pages for data_retained_bytes

MaintenanceOpStats has collected statistics about 'data_retained_bytes_',
which means the amount of disk capacity can be freed later. But the protobuf
file has no the information, so it is not showed at web pages.

This patch adds a variable in protobuf file and show it at web pages.

Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
---
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.proto
3 files changed, 11 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/19407/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>

[kudu-CR] [web] add maintenance op statistics information at web pages for data retained bytes

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19407 )

Change subject: [web] add maintenance op statistics information at web pages for data_retained_bytes
......................................................................


Patch Set 5:

> Patch Set 5:
> 
> > Patch Set 4:
> > 
> > (6 comments)
> > 
> > > Patch Set 4: Code-Review+1
> > > 
> > > It would be nice if you could provide the screenshot for the maintenance manager page and add the permanent link to the commit message.
> > 
> > 
> > Thanks your advice, get it. I should study it.
> > 
> > How to do this, is there any common way to do this?
> 
> Maybe a simple way is to take a screenshot of this page, upload it to github, and then you can paste the url of the picture in the commit message.

ok。 Thanks your advice. I'll do it.


-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 11:45:54 +0000
Gerrit-HasComments: No

[kudu-CR] [web] add maintenance op statistics information on web pages for data retained bytes

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19407 )

Change subject: [web] add maintenance op statistics information on web pages for data_retained_bytes
......................................................................

[web] add maintenance op statistics information on web pages for data_retained_bytes

MaintenanceOpStats collects statistics about 'data_retained_bytes_',
which means amount of disk capacity in data blocks that would be freed if
current maintenence operation ran. But the protobuf file has no such
information, so it is not shown on web pages.

This patch adds a field in the protobuf file and updates the embedded web server
to show the retained bytes for a maintenance operation. Sample screenshot of
the maintenance manager page can be found here:
https://github.com/shenxingwuying/kudu/blob/dev/flyline/screenshot/data_retained.png

Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Reviewed-on: http://gerrit.cloudera.org:8080/19407
Tested-by: Kudu Jenkins
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/integration-tests/webserver-stress-itest.cc
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.proto
M www/maintenance-manager.mustache
5 files changed, 28 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Yifan Zhang: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 8
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [web] add maintenance op statistics information at web pages for data retained bytes

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19407 )

Change subject: [web] add maintenance op statistics information at web pages for data_retained_bytes
......................................................................


Patch Set 4:

(6 comments)

> Patch Set 4: Code-Review+1
> 
> It would be nice if you could provide the screenshot for the maintenance manager page and add the permanent link to the commit message.


Thanks your advice, get it. I should study it.

How to do this, is there any common way to do this?

http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@11
PS4, Line 11: showed
> shown
Done


http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@11
PS4, Line 11: no the information
> no such information
Done


http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@13
PS4, Line 13: protobuf file
> the protobuf file
Done


http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@13
PS4, Line 13: variable
> field
Done


http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@13
PS4, Line 13: show it at web pages
> ... updates the embedded web server to show the retained bytes for a mainte
Done


http://gerrit.cloudera.org:8080/#/c/19407/4/src/kudu/integration-tests/webserver-stress-itest.cc
File src/kudu/integration-tests/webserver-stress-itest.cc:

http://gerrit.cloudera.org:8080/#/c/19407/4/src/kudu/integration-tests/webserver-stress-itest.cc@101
PS4, Line 101: #ifdef __linux__
> Would be great to add a comment to explain why having this extra check unde
I think it again, it's not necessary to restrict os platform. So I remove it.



-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Jan 2023 06:40:00 +0000
Gerrit-HasComments: Yes

[kudu-CR] [web] add maintenance op statistics information on web pages for data retained bytes

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19407 )

Change subject: [web] add maintenance op statistics information on web pages for data_retained_bytes
......................................................................


Patch Set 7:

> Patch Set 7:
> 
> (1 comment)

Just ignore my comment.

Thanks for your contribution!


-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 7
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 06 Feb 2023 02:03:25 +0000
Gerrit-HasComments: No

[kudu-CR] [web] add maintenance op statistics information at web pages for data retained bytes

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19407

to look at the new patch set (#4).

Change subject: [web] add maintenance op statistics information at web pages for data_retained_bytes
......................................................................

[web] add maintenance op statistics information at web pages for data_retained_bytes

MaintenanceOpStats has collected statistics about 'data_retained_bytes_',
which means the amount of disk capacity can be freed later. But the protobuf
file has no the information, so it is not showed at web pages.

This patch adds a variable in protobuf file and show it at web pages.

Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
---
M src/kudu/integration-tests/webserver-stress-itest.cc
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.proto
M www/maintenance-manager.mustache
5 files changed, 26 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/19407/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [web] add maintenance op statistics information at web pages for data retained bytes

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19407 )

Change subject: [web] add maintenance op statistics information at web pages for data_retained_bytes
......................................................................


Patch Set 5:

> Patch Set 4:
> 
> (6 comments)
> 
> > Patch Set 4: Code-Review+1
> > 
> > It would be nice if you could provide the screenshot for the maintenance manager page and add the permanent link to the commit message.
> 
> 
> Thanks your advice, get it. I should study it.
> 
> How to do this, is there any common way to do this?

Maybe a simple way is to take a screenshot of this page, upload it to github, and then you can paste the url of the picture in the commit message.


-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 06:20:21 +0000
Gerrit-HasComments: No

[kudu-CR] [web] add maintenance op statistics information on web pages for data retained bytes

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19407 )

Change subject: [web] add maintenance op statistics information on web pages for data_retained_bytes
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 7
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 06 Feb 2023 01:17:35 +0000
Gerrit-HasComments: No

[kudu-CR] [web] add maintenance op statistics information at web pages for data retained bytes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19407 )

Change subject: [web] add maintenance op statistics information at web pages for data_retained_bytes
......................................................................


Patch Set 4: Verified+1

(6 comments)

+1 for adding a link to a screenshot of the maintenance manager page, as suggested by Yifan

http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@11
PS4, Line 11: no the information
no such information


http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@11
PS4, Line 11: showed
shown


http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@13
PS4, Line 13: protobuf file
the protobuf file


http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@13
PS4, Line 13: show it at web pages
... updates the embedded web server to show the retained bytes for a maintenance operation


http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@13
PS4, Line 13: variable
field


http://gerrit.cloudera.org:8080/#/c/19407/4/src/kudu/integration-tests/webserver-stress-itest.cc
File src/kudu/integration-tests/webserver-stress-itest.cc:

http://gerrit.cloudera.org:8080/#/c/19407/4/src/kudu/integration-tests/webserver-stress-itest.cc@101
PS4, Line 101: #ifdef __linux__
Would be great to add a comment to explain why having this extra check under this macro.



-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 18 Jan 2023 05:16:18 +0000
Gerrit-HasComments: Yes

[kudu-CR] [web] add maintenance op statistics information at web pages for data retained bytes

Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19407 )

Change subject: [web] add maintenance op statistics information at web pages for data_retained_bytes
......................................................................


Patch Set 5:

(4 comments)

Thanks for adding this.

http://gerrit.cloudera.org:8080/#/c/19407/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19407/5//COMMIT_MSG@7
PS5, Line 7: at
nit: on


http://gerrit.cloudera.org:8080/#/c/19407/5//COMMIT_MSG@9
PS5, Line 9: has collected
nit: collects


http://gerrit.cloudera.org:8080/#/c/19407/5//COMMIT_MSG@10
PS5, Line 10: the amount of disk capacity can be freed later
nit: amount of disk space in data blocks that would be freed if current maintenance operation ran


http://gerrit.cloudera.org:8080/#/c/19407/5//COMMIT_MSG@11
PS5, Line 11: at
nit: on



-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Jan 2023 13:49:31 +0000
Gerrit-HasComments: Yes

[kudu-CR] [web] add maintenance op statistics information on web pages for data retained bytes

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Ashwani Raina, Yingchun Lai, Yifan Zhang, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19407

to look at the new patch set (#7).

Change subject: [web] add maintenance op statistics information on web pages for data_retained_bytes
......................................................................

[web] add maintenance op statistics information on web pages for data_retained_bytes

MaintenanceOpStats collects statistics about 'data_retained_bytes_',
which means amount of disk capacity in data blocks that would be freed if
current maintenence operation ran. But the protobuf file has no such
information, so it is not shown on web pages.

This patch adds a field in the protobuf file and updates the embedded web server
to show the retained bytes for a maintenance operation. Sample screenshot of
the maintenance manager page can be found here:
https://github.com/shenxingwuying/kudu/blob/dev/flyline/screenshot/data_retained.png

Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
---
M src/kudu/integration-tests/webserver-stress-itest.cc
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.proto
M www/maintenance-manager.mustache
5 files changed, 28 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/19407/7
-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 7
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [web] add maintenance op statistics information on web pages for data retained bytes

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19407 )

Change subject: [web] add maintenance op statistics information on web pages for data_retained_bytes
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19407/7/src/kudu/integration-tests/webserver-stress-itest.cc
File src/kudu/integration-tests/webserver-stress-itest.cc:

http://gerrit.cloudera.org:8080/#/c/19407/7/src/kudu/integration-tests/webserver-stress-itest.cc@108
PS7, Line 108: data_retained
nit: This should be "Data retained".



-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 7
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 06 Feb 2023 01:46:25 +0000
Gerrit-HasComments: Yes

[kudu-CR] [web] add maintenance op statistics information at web pages for data retained bytes

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yingchun Lai, Yifan Zhang, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19407

to look at the new patch set (#5).

Change subject: [web] add maintenance op statistics information at web pages for data_retained_bytes
......................................................................

[web] add maintenance op statistics information at web pages for data_retained_bytes

MaintenanceOpStats has collected statistics about 'data_retained_bytes_',
which means the amount of disk capacity can be freed later. But the protobuf
file has no suchinformation, so it is not shown at web pages.

This patch adds a field in the protobuf file and updates the embedded web server
to show the retained bytes for a maintenance operation.

Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
---
M src/kudu/integration-tests/webserver-stress-itest.cc
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.proto
M www/maintenance-manager.mustache
5 files changed, 27 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/19407/5
-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [web] add maintenance op statistics information on web pages for data retained bytes

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19407 )

Change subject: [web] add maintenance op statistics information on web pages for data_retained_bytes
......................................................................


Patch Set 6:

(4 comments)

Thanks your advices. I have fixed them.

http://gerrit.cloudera.org:8080/#/c/19407/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19407/5//COMMIT_MSG@7
PS5, Line 7: on
> nit: on
Done


http://gerrit.cloudera.org:8080/#/c/19407/5//COMMIT_MSG@9
PS5, Line 9: collects stat
> nit: collects
Done


http://gerrit.cloudera.org:8080/#/c/19407/5//COMMIT_MSG@10
PS5, Line 10: amount of disk capacity in data blocks that wo
> nit: amount of disk space in data blocks that would be freed if current mai
Done


http://gerrit.cloudera.org:8080/#/c/19407/5//COMMIT_MSG@11
PS5, Line 11: bu
> nit: on
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 6
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Feb 2023 09:48:14 +0000
Gerrit-HasComments: Yes

[kudu-CR] [web] add maintenance op statistics information at web pages for data retained bytes

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19407

to look at the new patch set (#3).

Change subject: [web] add maintenance op statistics information at web pages for data_retained_bytes
......................................................................

[web] add maintenance op statistics information at web pages for data_retained_bytes

MaintenanceOpStats has collected statistics about 'data_retained_bytes_',
which means the amount of disk capacity can be freed later. But the protobuf
file has no the information, so it is not showed at web pages.

This patch adds a variable in protobuf file and show it at web pages.

Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
---
M src/kudu/integration-tests/webserver-stress-itest.cc
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.proto
M www/maintenance-manager.mustache
5 files changed, 26 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/19407/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [web] add maintenance op statistics information at web pages for data retained bytes

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19407

to look at the new patch set (#2).

Change subject: [web] add maintenance op statistics information at web pages for data_retained_bytes
......................................................................

[web] add maintenance op statistics information at web pages for data_retained_bytes

MaintenanceOpStats has collected statistics about 'data_retained_bytes_',
which means the amount of disk capacity can be freed later. But the protobuf
file has no the information, so it is not showed at web pages.

This patch adds a variable in protobuf file and show it at web pages.

Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
---
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.proto
M www/maintenance-manager.mustache
4 files changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/19407/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [web] add maintenance op statistics information at web pages for data retained bytes

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19407 )

Change subject: [web] add maintenance op statistics information at web pages for data_retained_bytes
......................................................................


Patch Set 4: Code-Review+1

It would be nice if you could provide the screenshot for the maintenance manager page and add the permanent link to the commit message.


-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 16 Jan 2023 08:12:42 +0000
Gerrit-HasComments: No

[kudu-CR] [web] add maintenance op statistics information at web pages for data retained bytes

Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19407 )

Change subject: [web] add maintenance op statistics information at web pages for data_retained_bytes
......................................................................


Patch Set 5: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Jan 2023 14:02:11 +0000
Gerrit-HasComments: No

[kudu-CR] [web] add maintenance op statistics information on web pages for data retained bytes

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Ashwani Raina, Yingchun Lai, Yifan Zhang, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19407

to look at the new patch set (#6).

Change subject: [web] add maintenance op statistics information on web pages for data_retained_bytes
......................................................................

[web] add maintenance op statistics information on web pages for data_retained_bytes

MaintenanceOpStats collects statistics about 'data_retained_bytes_',
which means amount of disk capacity in data blocks that would be freed if
current maintenence operation ran. But the protobuf file has no such
information, so it is not shown on web pages.

This patch adds a field in the protobuf file and updates the embedded web server
to show the retained bytes for a maintenance operation. Sample screenshot of
the maintenance manager page can be found here:
https://github.com/shenxingwuying/kudu/blob/dev/flyline/screenshot/data_retained.png

Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
---
M src/kudu/integration-tests/webserver-stress-itest.cc
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.proto
M www/maintenance-manager.mustache
5 files changed, 29 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/19407/6
-- 
To view, visit http://gerrit.cloudera.org:8080/19407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e
Gerrit-Change-Number: 19407
Gerrit-PatchSet: 6
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>