You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2024/11/20 00:05:09 UTC

[Impala-ASF-CR] Add logging to pip download.py and fail if downloads fail

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22081


Change subject: Add logging to pip_download.py and fail if downloads fail
......................................................................

Add logging to pip_download.py and fail if downloads fail

Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
---
M infra/python/deps/pip_download.py
1 file changed, 9 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/22081/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22081/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22081/8//COMMIT_MSG@12
PS8, Line 12: 2. This stops testing impala-shell with system python 2.
> Right, this doesn't touch toolchain python 2, and that is still used for ru
It might automatically do the right thing, but can definitely clean it up.



-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 18:49:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04
......................................................................


Patch Set 8: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 13:35:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04
......................................................................


Patch Set 7: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11151/


-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 09:38:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04
......................................................................


Patch Set 8: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22081/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22081/8//COMMIT_MSG@12
PS8, Line 12: 2. This stops testing impala-shell with system python 2.
So this preserves building and running tests with impala-python, but stops testing with Python 2?



-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 18:21:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Add logging to pip download.py and fail if downloads fail

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22081

to look at the new patch set (#3).

Change subject: Add logging to pip_download.py and fail if downloads fail
......................................................................

Add logging to pip_download.py and fail if downloads fail

Try untarring the virtualenv tarball in impala-python-common.sh

Print out more info for bootstrap_virtualenv.py

Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
---
M bin/impala-python-common.sh
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/pip_download.py
3 files changed, 20 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/22081/3
-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17513/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 04:05:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22081

to look at the new patch set (#7).

Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04
......................................................................

PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

This fixes the tarfile.ReadError by doing two things:
1. bootstrap_virtualenv.py uses commandline tar to unpack the
   virtualenv tarball for Python 2.
2. This stops testing impala-shell with system python 2.

Python 2 is destined to be removed anyway. Ideally it would happen
under less emergent circumstances, but Python 2 needs to die.

Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
---
M CMakeLists.txt
M bin/impala-config.sh
M infra/python/bootstrap_virtualenv.py
M shell/CMakeLists.txt
M tests/shell/util.py
5 files changed, 2 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/22081/7
-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04
......................................................................


Patch Set 8:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17517/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 08:32:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add logging to pip download.py and fail if downloads fail

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22081

to look at the new patch set (#4).

Change subject: Add logging to pip_download.py and fail if downloads fail
......................................................................

Add logging to pip_download.py and fail if downloads fail

Try untarring the virtualenv tarball in impala-python-common.sh

Print out more info for bootstrap_virtualenv.py

Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
---
M bin/impala-python-common.sh
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/pip_download.py
3 files changed, 25 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/22081/4
-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17514/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 04:30:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11151/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 04:23:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add logging to pip download.py and fail if downloads fail

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: Add logging to pip_download.py and fail if downloads fail
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/17509/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 00:24:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add logging to pip download.py and fail if downloads fail

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: Add logging to pip_download.py and fail if downloads fail
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/17510/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 00:38:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add logging to pip download.py and fail if downloads fail

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22081

to look at the new patch set (#6).

Change subject: Add logging to pip_download.py and fail if downloads fail
......................................................................

Add logging to pip_download.py and fail if downloads fail

Try untarring the virtualenv tarball in impala-python-common.sh

Print out more info for bootstrap_virtualenv.py

Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
---
M CMakeLists.txt
M bin/impala-config.sh
M bin/impala-python-common.sh
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/pip_download.py
M shell/CMakeLists.txt
M tests/shell/util.py
7 files changed, 25 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/22081/6
-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22081/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22081/8//COMMIT_MSG@10
PS8, Line 10: 1. bootstrap_virtualenv.py uses commandline tar to unpack the
Looks like Ubuntu put out a bad build: https://bugs.launchpad.net/ubuntu/+source/python-defaults/+bug/2089136



-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 18:24:45 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Add logging to pip download.py and fail if downloads fail

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22081

to look at the new patch set (#2).

Change subject: Add logging to pip_download.py and fail if downloads fail
......................................................................

Add logging to pip_download.py and fail if downloads fail

Try untarring the virtualenv tarball in impala-python-common.sh

Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
---
M bin/impala-python-common.sh
M infra/python/deps/pip_download.py
2 files changed, 18 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/22081/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22081/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22081/8//COMMIT_MSG@12
PS8, Line 12: 2. This stops testing impala-shell with system python 2.
> So this preserves building and running tests with impala-python, but stops 
Right, this doesn't touch toolchain python 2, and that is still used for running pytests and various other things.

We use system python 2 for shell tests (with the shell tarball and also with a pip installed impala-shell). This stops testing impala-shell with system python 2, so the only testing configurations for impala-shell would be system python 3.

This would impact what we ship in the shell tarball. The shell tarball would no longer include python 2 support. So, I think I would also need to change the tarball's impala-shell executable to only care about python3.



-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 18:43:08 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Add logging to pip download.py and fail if downloads fail

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: Add logging to pip_download.py and fail if downloads fail
......................................................................


Patch Set 4:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/22081/4/infra/python/bootstrap_virtualenv.py
File infra/python/bootstrap_virtualenv.py:

http://gerrit.cloudera.org:8080/#/c/22081/4/infra/python/bootstrap_virtualenv.py@140
PS4, Line 140: #
flake8: E265 block comment should start with '# '


http://gerrit.cloudera.org:8080/#/c/22081/4/infra/python/bootstrap_virtualenv.py@141
PS4, Line 141: #
flake8: E265 block comment should start with '# '


http://gerrit.cloudera.org:8080/#/c/22081/4/infra/python/bootstrap_virtualenv.py@143
PS4, Line 143: #
flake8: E265 block comment should start with '# '



-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 00:56:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Add logging to pip download.py and fail if downloads fail

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: Add logging to pip_download.py and fail if downloads fail
......................................................................


Patch Set 3:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/17511/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 00:55:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22081

to look at the new patch set (#8).

Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04
......................................................................

PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

This fixes the tarfile.ReadError by doing two things:
1. bootstrap_virtualenv.py uses commandline tar to unpack the
   virtualenv tarball for Python 2.
2. This stops testing impala-shell with system python 2.

Python 2 is destined to be removed anyway. Ideally it would happen
under less emergent circumstances, but Python 2 needs to die.

Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
---
M CMakeLists.txt
M bin/impala-config.sh
M infra/python/bootstrap_virtualenv.py
M shell/CMakeLists.txt
M tests/shell/util.py
5 files changed, 3 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/22081/8
-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11152/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 08:05:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add logging to pip download.py and fail if downloads fail

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: Add logging to pip_download.py and fail if downloads fail
......................................................................


Patch Set 4:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/17512/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 01:11:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add logging to pip download.py and fail if downloads fail

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )

Change subject: Add logging to pip_download.py and fail if downloads fail
......................................................................


Patch Set 6:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/22081/6/infra/python/bootstrap_virtualenv.py
File infra/python/bootstrap_virtualenv.py:

http://gerrit.cloudera.org:8080/#/c/22081/6/infra/python/bootstrap_virtualenv.py@140
PS6, Line 140: #
flake8: E265 block comment should start with '# '


http://gerrit.cloudera.org:8080/#/c/22081/6/infra/python/bootstrap_virtualenv.py@141
PS6, Line 141: #
flake8: E265 block comment should start with '# '


http://gerrit.cloudera.org:8080/#/c/22081/6/infra/python/bootstrap_virtualenv.py@143
PS6, Line 143: #
flake8: E265 block comment should start with '# '



-- 
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 03:40:07 +0000
Gerrit-HasComments: Yes