You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ce...@apache.org on 2015/11/08 11:01:48 UTC
svn commit: r1713218 - in /poi/trunk: build.xml
src/resources/devtools/forbidden-signatures.txt
Author: centic
Date: Sun Nov 8 10:01:48 2015
New Revision: 1713218
URL: http://svn.apache.org/viewvc?rev=1713218&view=rev
Log:
Tried to add excelant to forbidden-apis-check, but failed due to issue #82 in forbidden-api-checks tool. List more pathes that we still not include. Add description to custom forbidden-api-checks and add commented out checks for reflectoin as discussed in bug 58597
Modified:
poi/trunk/build.xml
poi/trunk/src/resources/devtools/forbidden-signatures.txt
Modified: poi/trunk/build.xml
URL: http://svn.apache.org/viewvc/poi/trunk/build.xml?rev=1713218&r1=1713217&r2=1713218&view=diff
==============================================================================
--- poi/trunk/build.xml (original)
+++ poi/trunk/build.xml Sun Nov 8 10:01:48 2015
@@ -1767,19 +1767,32 @@ under the License.
<forbiddenapis
internalRuntimeForbidden="true"
classpathref="javadoc.classpath"
- suppressAnnotation="org.apache.poi.util.SuppressForbidden"
- >
+ suppressAnnotation="org.apache.poi.util.SuppressForbidden"
+ >
<bundledsignatures name="jdk-unsafe-${jdk.version.source}"/>
<bundledsignatures name="jdk-deprecated-${jdk.version.source}"/>
- <signaturesFileset file="src/resources/devtools/forbidden-signatures.txt"/>
- <fileset dir="${main.output.dir}"/>
- <fileset dir="${scratchpad.output.dir}"/>
- <fileset dir="${ooxml.output.dir}"/>
- <fileset dir="${main.output.test.dir}"/>
- <fileset dir="${ooxml.output.test.dir}"/>
- <!--
- <fileset dir="${scratchpad.output.test.dir}"/>
- -->
+ <!--
+ <bundledsignatures name="jdk-system-out"/>
+ -->
+ <signaturesFileset file="src/resources/devtools/forbidden-signatures.txt"/>
+ <!-- sources -->
+ <fileset dir="${main.output.dir}"/>
+ <fileset dir="${ooxml.output.dir}"/>
+ <fileset dir="${scratchpad.output.dir}"/>
+ <!--
+ Adding Excelant causes ClassNotFoundException, see https://github.com/policeman-tools/forbidden-apis/issues/85
+ <fileset dir="${excelant.output.dir}"/>
+ -->
+ <!--
+ <fileset dir="${examples.output.dir}"/>
+ -->
+ <!-- test-sources -->
+ <fileset dir="${main.output.test.dir}"/>
+ <fileset dir="${ooxml.output.test.dir}"/>
+ <!--
+ <fileset dir="${scratchpad.output.test.dir}"/>
+ <fileset dir="${excelant.output.test.dir}"/>
+ -->
</forbiddenapis>
</target>
Modified: poi/trunk/src/resources/devtools/forbidden-signatures.txt
URL: http://svn.apache.org/viewvc/poi/trunk/src/resources/devtools/forbidden-signatures.txt?rev=1713218&r1=1713217&r2=1713218&view=diff
==============================================================================
--- poi/trunk/src/resources/devtools/forbidden-signatures.txt (original)
+++ poi/trunk/src/resources/devtools/forbidden-signatures.txt Sun Nov 8 10:01:48 2015
@@ -20,7 +20,13 @@
@ignoreUnresolvable
@defaultMessage POI forbidden APIs
-java.util.Locale#getDefault()
-java.util.Locale#setDefault(java.util.Locale)
-java.util.TimeZone#getDefault()
-java.util.Date#toString()
\ No newline at end of file
+# Locale related interfaces which we want to avoid to not have code which depends on the locale of the current machine
+java.util.Locale#getDefault() @ Do not use methods that depend on the current Local, either use Locale.ROOT or let the user define the local, see class LocaleUtil for details
+java.util.Locale#setDefault(java.util.Locale) @ Do not use methods that depend on the current Local, either use Locale.ROOT or let the user define the local, see class LocaleUtil for details
+java.util.TimeZone#getDefault() @ Do not use methods that depend on the current Local, either use Locale.ROOT or let the user define the local, see class LocaleUtil for details
+java.util.Date#toString() @ Do not use methods that depend on the current Local, either use Locale.ROOT or let the user define the local, see class LocaleUtil for details
+
+# disabled as there are still invocations that we could not remove easily
+#java.lang.reflect.AccessibleObject#setAccessible(java.lang.reflect.AccessibleObject[], boolean) @ Reflection usage fails with SecurityManagers and likely will not work any more in Java 9
+#java.lang.reflect.AccessibleObject#setAccessible(boolean) @ Reflection usage fails with SecurityManagers and likely will not work any more in Java 9
+#java.lang.reflect.Method#invoke(java.lang.Object, java.lang.Object[]) @ Reflection usage fails with SecurityManagers and likely will not work any more in Java 9
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org
RE: svn commit: r1713218 - in /poi/trunk: build.xml src/resources/devtools/forbidden-signatures.txt
Posted by Uwe Schindler <uw...@thetaphi.de>.
I fixed the forbiddenapis issue. The problem was incomplete classpath. Forbiddenapis used the javadoc.classpath, which did not include the excelant.classpath which has the ANT jar files as downloaded from Maven Central.
Uwe
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
> -----Original Message-----
> From: centic@apache.org [mailto:centic@apache.org]
> Sent: Sunday, November 08, 2015 11:02 AM
> To: commits@poi.apache.org
> Subject: svn commit: r1713218 - in /poi/trunk: build.xml
> src/resources/devtools/forbidden-signatures.txt
>
> Author: centic
> Date: Sun Nov 8 10:01:48 2015
> New Revision: 1713218
>
> URL: http://svn.apache.org/viewvc?rev=1713218&view=rev
> Log:
> Tried to add excelant to forbidden-apis-check, but failed due to issue #82 in
> forbidden-api-checks tool. List more pathes that we still not include. Add
> description to custom forbidden-api-checks and add commented out checks
> for reflectoin as discussed in bug 58597
>
> Modified:
> poi/trunk/build.xml
> poi/trunk/src/resources/devtools/forbidden-signatures.txt
>
> Modified: poi/trunk/build.xml
> URL:
> http://svn.apache.org/viewvc/poi/trunk/build.xml?rev=1713218&r1=171321
> 7&r2=1713218&view=diff
> ==========================================================
> ====================
> --- poi/trunk/build.xml (original)
> +++ poi/trunk/build.xml Sun Nov 8 10:01:48 2015
> @@ -1767,19 +1767,32 @@ under the License.
> <forbiddenapis
> internalRuntimeForbidden="true"
> classpathref="javadoc.classpath"
> -
> suppressAnnotation="org.apache.poi.util.SuppressForbidden"
> - >
> + suppressAnnotation="org.apache.poi.util.SuppressForbidden"
> + >
> <bundledsignatures name="jdk-unsafe-${jdk.version.source}"/>
> <bundledsignatures name="jdk-deprecated-${jdk.version.source}"/>
> - <signaturesFileset file="src/resources/devtools/forbidden-
> signatures.txt"/>
> - <fileset dir="${main.output.dir}"/>
> - <fileset dir="${scratchpad.output.dir}"/>
> - <fileset dir="${ooxml.output.dir}"/>
> - <fileset dir="${main.output.test.dir}"/>
> - <fileset dir="${ooxml.output.test.dir}"/>
> - <!--
> - <fileset dir="${scratchpad.output.test.dir}"/>
> - -->
> + <!--
> + <bundledsignatures name="jdk-system-out"/>
> + -->
> + <signaturesFileset file="src/resources/devtools/forbidden-
> signatures.txt"/>
> + <!-- sources -->
> + <fileset dir="${main.output.dir}"/>
> + <fileset dir="${ooxml.output.dir}"/>
> + <fileset dir="${scratchpad.output.dir}"/>
> + <!--
> + Adding Excelant causes ClassNotFoundException, see
> https://github.com/policeman-tools/forbidden-apis/issues/85
> + <fileset dir="${excelant.output.dir}"/>
> + -->
> + <!--
> + <fileset dir="${examples.output.dir}"/>
> + -->
> + <!-- test-sources -->
> + <fileset dir="${main.output.test.dir}"/>
> + <fileset dir="${ooxml.output.test.dir}"/>
> + <!--
> + <fileset dir="${scratchpad.output.test.dir}"/>
> + <fileset dir="${excelant.output.test.dir}"/>
> + -->
> </forbiddenapis>
> </target>
>
>
> Modified: poi/trunk/src/resources/devtools/forbidden-signatures.txt
> URL:
> http://svn.apache.org/viewvc/poi/trunk/src/resources/devtools/forbidden-
> signatures.txt?rev=1713218&r1=1713217&r2=1713218&view=diff
> ==========================================================
> ====================
> --- poi/trunk/src/resources/devtools/forbidden-signatures.txt (original)
> +++ poi/trunk/src/resources/devtools/forbidden-signatures.txt Sun Nov 8
> 10:01:48 2015
> @@ -20,7 +20,13 @@
> @ignoreUnresolvable
> @defaultMessage POI forbidden APIs
>
> -java.util.Locale#getDefault()
> -java.util.Locale#setDefault(java.util.Locale)
> -java.util.TimeZone#getDefault()
> -java.util.Date#toString()
> \ No newline at end of file
> +# Locale related interfaces which we want to avoid to not have code which
> depends on the locale of the current machine
> +java.util.Locale#getDefault() @ Do not use methods that depend on the
> current Local, either use Locale.ROOT or let the user define the local, see
> class LocaleUtil for details
> +java.util.Locale#setDefault(java.util.Locale) @ Do not use methods that
> depend on the current Local, either use Locale.ROOT or let the user define
> the local, see class LocaleUtil for details
> +java.util.TimeZone#getDefault() @ Do not use methods that depend on the
> current Local, either use Locale.ROOT or let the user define the local, see
> class LocaleUtil for details
> +java.util.Date#toString() @ Do not use methods that depend on the current
> Local, either use Locale.ROOT or let the user define the local, see class
> LocaleUtil for details
> +
> +# disabled as there are still invocations that we could not remove easily
> +#java.lang.reflect.AccessibleObject#setAccessible(java.lang.reflect.Accessi
> bleObject[], boolean) @ Reflection usage fails with SecurityManagers and
> likely will not work any more in Java 9
> +#java.lang.reflect.AccessibleObject#setAccessible(boolean) @ Reflection
> usage fails with SecurityManagers and likely will not work any more in Java 9
> +#java.lang.reflect.Method#invoke(java.lang.Object, java.lang.Object[]) @
> Reflection usage fails with SecurityManagers and likely will not work any
> more in Java 9
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
> For additional commands, e-mail: commits-help@poi.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org