[jira] [Commented] (KAFKA-7084) NewTopicBuilder#config should accept Map rather than Map

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-7084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060733#comment-17060733 ] 

ASF GitHub Bot commented on KAFKA-7084:
---------------------------------------

chia7712 commented on pull request #5261: KAFKA-7084 NewTopicBuilder#config should accept Map<String, String> r…
URL: https://github.com/apache/kafka/pull/5261
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> NewTopicBuilder#config should accept Map<String, String> rather than Map<String, Object>
> ----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-7084
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7084
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Major
>
> The field "config" in NewTopic is Map[String, String] but NewTopicBuilder#config accept the Map[String, Object] and then call Object#toString to convert the Map[String, Object] to Map[String, String]. That is weird since users have to trace the source code to understand how kafka generate the Map[String, String].
> we should deprecate NewTopicBuilder#config(Map[String, Object]) and add an alternative method NewTopicBuilder#config"s"(Map[String, String])



--
This message was sent by Atlassian Jira
(v8.3.4#803005)