You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2016/09/30 14:41:38 UTC
[GitHub] activemq-artemis pull request #814: ARTEMIS-762 Reflect management changes i...
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/814
ARTEMIS-762 Reflect management changes in AMQP protocol
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-762
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/814.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #814
----
commit 64ddc776fcd784fe31b11a6bb1b07aab95086b53
Author: Ulf Lilleengen <ul...@redhat.com>
Date: 2016-09-30T14:35:59Z
ARTEMIS-762 Reflect management changes in AMQP protocol
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #814: ARTEMIS-762 Reflect management changes in AMQP ...
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/814
The tests seem to be using sleep calls to determine connection closed which is not the best given that it might close long before, or not depending on the speed of the machine, I'd recommend using the Wait class that was pulled over from 5.x where you can do a "Wait.waitFor(new Wait.Condition() { return ....} );" that way you can avoid adding a bunch of extra time to the tests unnecessarily
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #814: ARTEMIS-762 Reflect management changes in AMQP ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/814
@mtaylor I have rebased the whole thing into my branch here:
https://github.com/clebertsuconic/activemq-artemis/tree/ARTEMIS-762
I was going to merge this, but I'm not sure about if this is ready to merge yet give @tabish121 comments. you want me to merge directly.. or you want to fetch my branch and rebase here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #814: ARTEMIS-762 Reflect management changes in AMQP ...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/814
@clebertsuconic Yes this is ready to go. Cheers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #814: ARTEMIS-762 Reflect management changes in AMQP ...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/814
@clebertsuconic please leave this I have made the changes locally, but need to modify the test client to handle disconnect errors. Will update shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #814: ARTEMIS-762 Reflect management changes in AMQP ...
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/814
Was the commit of the log file intentional?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #814: ARTEMIS-762 Reflect management changes i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/814
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #814: ARTEMIS-762 Reflect management changes in AMQP ...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/814
@tabish121 good catch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #814: ARTEMIS-762 Reflect management changes in AMQP ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/814
@mtaylor is this ready now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #814: ARTEMIS-762 Reflect management changes in AMQP ...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/814
@tabish121 removed and added **/*.log to my gitignore :) cheers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #814: ARTEMIS-762 Reflect management changes in AMQP ...
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/814
The remote close on the connection doesn't appear to provide any ErrorCondition to the remote to give it any indication of why it was closed which is less than ideal. There's a couple different stock AMQP error conditions that could be used, in the case of the Queue being deleted you could for instance use the "amqp:resource-deleted" error to at least give the remote some hint to what happened.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---