[GitHub] [spark] eyalzit commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer

[GitBox <gi...@apache.org>]

eyalzit commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer
URL: https://github.com/apache/spark/pull/24382#discussion_r276103595
 
 

 ##########
 File path: docs/structured-streaming-programming-guide.md
 ##########
 @@ -2145,6 +2145,10 @@ streamingDatasetOfString.writeStream.foreach(
     def close(errorOrNull: Throwable): Unit = {
       // Close the connection
     }
+
+    def abort(): Unit = {
+      // Close the connection, this method is optional
 
 Review comment:
   well, it's optional since for backward compatibility i added default empty implementation, but maybe it will be netter to remove the "optional" from the comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org