You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/03 09:44:45 UTC
[GitHub] [dubbo-go-hessian2] wongoo opened a new pull request #254: Fix emoji
wongoo opened a new pull request #254:
URL: https://github.com/apache/dubbo-go-hessian2/pull/254
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
fix emoji decoding error and refactor string decoding algorithm, with 17% performance improvement
**Which issue(s) this PR fixes**:
Fixes #252 #253
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
```release-note
- fix emoji decoding error and refactor string decoding algorithm, with 17% performance improvement
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #254: Fix emoji decoding error
Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #254:
URL: https://github.com/apache/dubbo-go-hessian2/pull/254#issuecomment-753592268
## benchmark result
before fixing:
```
BenchmarkDecodeStringAscii
BenchmarkDecodeStringAscii-8 6952 173795 ns/op
BenchmarkDecodeStringUnicode
BenchmarkDecodeStringUnicode-8 5228 229713 ns/op
BenchmarkDecodeStringEmoji
string_test.go:230: err: bad utf-8 encoding
--- FAIL: BenchmarkDecodeStringEmoji
```
after fixing:
```
BenchmarkDecodeStringAscii
BenchmarkDecodeStringAscii-8 7149 145317 ns/op
BenchmarkDecodeStringUnicode
BenchmarkDecodeStringUnicode-8 5768 182145 ns/op
BenchmarkDecodeStringEmoji
BenchmarkDecodeStringEmoji-8 1400 816080 ns/op
```
with 17% performance improvement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-io commented on pull request #254: Fix emoji decoding error
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #254:
URL: https://github.com/apache/dubbo-go-hessian2/pull/254#issuecomment-753592154
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/254?src=pr&el=h1) Report
> Merging [#254](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/254?src=pr&el=desc) (cc4f9a4) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/4014d7e19aa3b27df6e6a9e78c598a6f9969848f?el=desc) (4014d7e) will **increase** coverage by `1.42%`.
> The diff coverage is `78.04%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/254?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 66.19% 67.61% +1.42%
==========================================
Files 25 25
Lines 2801 2671 -130
==========================================
- Hits 1854 1806 -48
+ Misses 718 644 -74
+ Partials 229 221 -8
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/254?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/254/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `70.70% <78.04%> (+13.99%)` | :arrow_up: |
| [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/254/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `72.00% <0.00%> (-2.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/254?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/254?src=pr&el=footer). Last update [4014d7e...cc4f9a4](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/254?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks merged pull request #254: Fix emoji decoding error
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #254:
URL: https://github.com/apache/dubbo-go-hessian2/pull/254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] fangyincheng commented on pull request #254: Fix emoji decoding error
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on pull request #254:
URL: https://github.com/apache/dubbo-go-hessian2/pull/254#issuecomment-754359423
ci failed
```The command "/tmp/tools/license/license-header-checker -v -a -r -i vendor /tmp/tools/license/license.txt . go && [[ -z `git status -s` ]]" exited with 1.```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org