You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/26 21:33:44 UTC
Re: Review Request 66746: Replaced protobuf-specific comparators with
MessageDifferencer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66746/#review213233
-----------------------------------------------------------
Bad review!
Reviews applied: [66746]
Error:
2019-02-26 21:33:43 URL:https://reviews.apache.org/r/66746/diff/raw/ [45557/45557] -> "66746.patch" [1]
error: patch failed: include/mesos/type_utils.hpp:23
error: include/mesos/type_utils.hpp: patch does not apply
error: patch failed: include/mesos/v1/mesos.hpp:23
error: include/mesos/v1/mesos.hpp: patch does not apply
error: patch failed: src/common/type_utils.cpp:36
error: src/common/type_utils.cpp: patch does not apply
error: patch failed: src/v1/mesos.cpp:35
error: src/v1/mesos.cpp: patch does not apply
- Mesos Reviewbot
On April 20, 2018, 1:19 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66746/
> -----------------------------------------------------------
>
> (Updated April 20, 2018, 1:19 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The MessageDifferencer utility has been available since protobuf 3.0.0.
> When comparing most repeated fields, we treat them as sets so the order
> of elements doesn't matter. In some exceptional cases, we treat them as
> list so the order becomes important. Further, fields with default
> purposes are considered to be set for comparison purposes.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa
> include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb
> src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
> src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf
>
>
> Diff: https://reviews.apache.org/r/66746/diff/1/
>
>
> Testing
> -------
>
> `make check` currently fails with:
> DefaultExecutorCheckTest.CommandCheckSharesWorkDirWithTask
> DefaultExecutorCheckTest.MultipleTasksWithChecks
>
>
> Thanks,
>
> Kapil Arya
>
>