You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ShubhamGondane (via GitHub)" <gi...@apache.org> on 2026/03/08 02:29:32 UTC
[PR] Fix Playwright anti-pattern in AssetListPage [airflow]
ShubhamGondane opened a new pull request, #63084:
URL: https://github.com/apache/airflow/pull/63084
Only `AssetListPage.ts` required changes to close this issue as `asset.spec.ts` and `AssetDetailPage.ts` already followed Playwright best practices.
Replace `waitForFunction()` with a DOM query inside with a locator-based `expect(...).toBeVisible()` assertion, which uses Playwright's built-in auto-waiting.
closes: #63037
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (Claude Code)
Generated-by: Claude Code (claude-sonnet-4-6) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Playwright anti-pattern in AssetListPage [airflow]
Posted by "ShubhamGondane (via GitHub)" <gi...@apache.org>.
ShubhamGondane commented on PR #63084:
URL: https://github.com/apache/airflow/pull/63084#issuecomment-4019123820
Sure, @choo121600 I will update it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Playwright anti-pattern in AssetListPage [airflow]
Posted by "ShubhamGondane (via GitHub)" <gi...@apache.org>.
ShubhamGondane commented on PR #63084:
URL: https://github.com/apache/airflow/pull/63084#issuecomment-4020766028
After further review, found a few more improvements:
- Removed assetCount() and assetNames() from AssetListPage — dead code after the refactor
- Replaced remaining snapshot-then-assert patterns (count() + expect(count), assetNames() loop) with web-first assertions
- Removed the post-search name loop — redundant since expect.poll above already verifies all results match
- Replaced expect(count).toBeGreaterThanOrEqual(minCount) in AssetDetailPage with expect(button).toHaveText(/^[1-9]/) and dropped the now-unused minCount parameter
@choo121600 Please review and let me know. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Playwright anti-pattern in AssetListPage [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 merged PR #63084:
URL: https://github.com/apache/airflow/pull/63084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Playwright anti-pattern in AssetListPage [airflow]
Posted by "Pyasma (via GitHub)" <gi...@apache.org>.
Pyasma commented on PR #63084:
URL: https://github.com/apache/airflow/pull/63084#issuecomment-4018660537
LGTM :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org