You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by js...@apache.org on 2003/04/26 11:56:23 UTC
cvs commit: maven/src/plugins-build/java plugin.jelly plugin.properties
jstrachan 2003/04/26 02:56:23
Modified: src/plugins-build/java/xdocs properties.xml
src/plugins-build/java plugin.jelly plugin.properties
Log:
Defaulted the compile target to 1.1. If a build is done on JDK 1.4 then it defaults to JDK 1.4, which means on some JVM's (e.g. IBM's JDK 1.3) the code won't work! Even if you're not using any JDK 1.4 features. The generated bytecode can contain some JDK 1.4 specific methods!
So as a safety measure, I've defaulted the target to 1.1 by default (which is the default setting for JDK 1.1, 1.2 and 1.3 anyway).
You can still overload this value on a project by project basis - this just prevents this possible bug hitting Maven users.
Revision Changes Path
1.7 +2 -0 maven/src/plugins-build/java/xdocs/properties.xml
Index: properties.xml
===================================================================
RCS file: /home/cvs/maven/src/plugins-build/java/xdocs/properties.xml,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- properties.xml 22 Apr 2003 12:20:49 -0000 1.6
+++ properties.xml 26 Apr 2003 09:56:23 -0000 1.7
@@ -139,6 +139,8 @@
Corresponds to the <code>target</code> attribute for the ant
<a href="http://ant.apache.org/manual/CoreTasks/javac.html">javac</a>
task.
+ This value defaults to 1.1 so that builds on JDK 1.4 or later stil work on
+ earlier JVMs.
</p>
</td>
</tr>
1.16 +2 -5 maven/src/plugins-build/java/plugin.jelly
Index: plugin.jelly
===================================================================
RCS file: /home/cvs/maven/src/plugins-build/java/plugin.jelly,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- plugin.jelly 17 Apr 2003 08:40:12 -0000 1.15
+++ plugin.jelly 26 Apr 2003 09:56:23 -0000 1.16
@@ -45,11 +45,12 @@
<j:choose>
<j:when test="${sourcesPresent == 'true'}">
- <ant:javac
+ <ant:javac
destdir="${maven.build.dest}"
excludes="**/package.html"
debug="${maven.compile.debug}"
deprecation="${maven.compile.deprecation}"
+ target="${maven.compile.target}"
optimize="${maven.compile.optimize}">
<ant:src>
<ant:path refid="maven.compile.src.set"/>
@@ -95,10 +96,6 @@
<j:if test="${context.getVariable('maven.compile.source') != null}">
<ant:setProperty name="source" value="${maven.compile.source}" />
- </j:if>
-
- <j:if test="${context.getVariable('maven.compile.target') != null}">
- <ant:setProperty name="target" value="${maven.compile.target}" />
</j:if>
<j:if test="${context.getVariable('maven.compile.verbose') != null}">
1.3 +2 -1 maven/src/plugins-build/java/plugin.properties
Index: plugin.properties
===================================================================
RCS file: /home/cvs/maven/src/plugins-build/java/plugin.properties,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- plugin.properties 26 Mar 2003 10:27:17 -0000 1.2
+++ plugin.properties 26 Apr 2003 09:56:23 -0000 1.3
@@ -3,4 +3,5 @@
# -------------------------------------------------------------------
maven.jar.manifest = ${maven.conf.dir}/Manifest.mf
-maven.jar.mainclass =
\ No newline at end of file
+maven.jar.mainclass =
+maven.compile.target = 1.1
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: cvs commit: maven/src/plugins-build/java plugin.jelly plugin.properties
Posted by di...@multitask.com.au.
Or at least warns people....
--
dIon Gillard, Multitask Consulting
Blog: http://www.freeroller.net/page/dion/Weblog
Work: http://www.multitask.com.au
Ben Walding <be...@walding.com> wrote on 29/04/2003 02:20:37 PM:
> Should we create a CVS wrapper that won't allow a java file to be
> checked in with tabs?
>
> dion@multitask.com.au wrote:
>
> >Tabs.....
> >--
> >dIon Gillard, Multitask Consulting
> >Blog: http://www.freeroller.net/page/dion/Weblog
> >Work: http://www.multitask.com.au
> >
> >
> >jstrachan@apache.org wrote on 26/04/2003 07:56:23 PM:
> >
> >
> >
> >>jstrachan 2003/04/26 02:56:23
> >>
> >> Modified: src/plugins-build/java/xdocs properties.xml
> >> src/plugins-build/java plugin.jelly plugin.properties
> >> Log:
> >> Defaulted the compile target to 1.1. If a build is done on JDK 1.4
> >>then it defaults to JDK 1.4, which means on some JVM's (e.g. IBM's JDK
> >>1.3) the code won't work! Even if you're not using any JDK 1.4
> >>features. The generated bytecode can contain some JDK 1.4 specific
> >>
> >>
> >methods!
> >
> >
> >>So as a safety measure, I've defaulted the target to 1.1 by default
> >>(which is the default setting for JDK 1.1, 1.2 and 1.3 anyway).
> >>
> >>You can still overload this value on a project by project basis - this
> >>just prevents this possible bug hitting Maven users.
> >>
> >> Revision Changes Path
> >> 1.7 +2 -0 maven/src/plugins-build/java/xdocs/properties.xml
> >>
> >> Index: properties.xml
> >> ===================================================================
> >> RCS file:
> >>
> >>
> >/home/cvs/maven/src/plugins-build/java/xdocs/properties.xml,v
> >
> >
> >> retrieving revision 1.6
> >> retrieving revision 1.7
> >> diff -u -r1.6 -r1.7
> >> --- properties.xml 22 Apr 2003 12:20:49 -0000 1.6
> >> +++ properties.xml 26 Apr 2003 09:56:23 -0000 1.7
> >> @@ -139,6 +139,8 @@
> >> Corresponds to the <code>target</code> attribute for
> >>
> >>
> >the ant
> >
> >
> >> <a
> >>
> >>
> >href="http://ant.apache.org/manual/CoreTasks/javac.html
> >
> >
> >>">javac</a>
> >> task.
> >> + This value defaults to 1.1 so that builds on JDK 1.4
> >>or later stil work on
> >> + earlier JVMs.
> >> </p>
> >> </td>
> >> </tr>
> >>
> >>
> >>
> >> 1.16 +2 -5 maven/src/plugins-build/java/plugin.jelly
> >>
> >> Index: plugin.jelly
> >> ===================================================================
> >> RCS file: /home/cvs/maven/src/plugins-build/java/plugin.jelly,v
> >> retrieving revision 1.15
> >> retrieving revision 1.16
> >> diff -u -r1.15 -r1.16
> >> --- plugin.jelly 17 Apr 2003 08:40:12 -0000 1.15
> >> +++ plugin.jelly 26 Apr 2003 09:56:23 -0000 1.16
> >> @@ -45,11 +45,12 @@
> >>
> >> <j:choose>
> >> <j:when test="${sourcesPresent == 'true'}">
> >> - <ant:javac
> >> + <ant:javac
> >> destdir="${maven.build.dest}"
> >> excludes="**/package.html"
> >> debug="${maven.compile.debug}"
> >> deprecation="${maven.compile.deprecation}"
> >> + target="${maven.compile.target}"
> >> optimize="${maven.compile.optimize}">
> >> <ant:src>
> >> <ant:path refid="maven.compile.src.set"/>
> >> @@ -95,10 +96,6 @@
> >>
> >> <j:if
test="${context.getVariable('maven.compile.source')!=
> >>
> >>
> >null}">
> >
> >
> >> <ant:setProperty name="source"
> >>
> >>
> >value="${maven.compile.source}" />
> >
> >
> >> - </j:if>
> >> -
> >> - <j:if
test="${context.getVariable('maven.compile.target')!=
> >>
> >>
> >null}">
> >
> >
> >> - <ant:setProperty name="target"
> >>
> >>
> >value="${maven.compile.target}" />
> >
> >
> >> </j:if>
> >>
> >> <j:if test="${context.getVariable('maven.compile.
> >>verbose') != null}">
> >>
> >>
> >>
> >> 1.3 +2 -1 maven/src/plugins-build/java/plugin.properties
> >>
> >> Index: plugin.properties
> >> ===================================================================
> >> RCS file: /home/cvs/maven/src/plugins-build/java/plugin.properties,v
> >> retrieving revision 1.2
> >> retrieving revision 1.3
> >> diff -u -r1.2 -r1.3
> >> --- plugin.properties 26 Mar 2003 10:27:17 -0000 1.2
> >> +++ plugin.properties 26 Apr 2003 09:56:23 -0000 1.3
> >> @@ -3,4 +3,5 @@
> >> #
-------------------------------------------------------------------
> >>
> >> maven.jar.manifest = ${maven.conf.dir}/Manifest.mf
> >> -maven.jar.mainclass =
> >> \ No newline at end of file
> >> +maven.jar.mainclass =
> >> +maven.compile.target = 1.1
> >> \ No newline at end of file
> >>
> >>
> >>
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >>
> >>
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: cvs commit: maven/src/plugins-build/java plugin.jelly plugin.properties
Posted by Ben Walding <be...@walding.com>.
Should we create a CVS wrapper that won't allow a java file to be
checked in with tabs?
dion@multitask.com.au wrote:
>Tabs.....
>--
>dIon Gillard, Multitask Consulting
>Blog: http://www.freeroller.net/page/dion/Weblog
>Work: http://www.multitask.com.au
>
>
>jstrachan@apache.org wrote on 26/04/2003 07:56:23 PM:
>
>
>
>>jstrachan 2003/04/26 02:56:23
>>
>> Modified: src/plugins-build/java/xdocs properties.xml
>> src/plugins-build/java plugin.jelly plugin.properties
>> Log:
>> Defaulted the compile target to 1.1. If a build is done on JDK 1.4
>>then it defaults to JDK 1.4, which means on some JVM's (e.g. IBM's JDK
>>1.3) the code won't work! Even if you're not using any JDK 1.4
>>features. The generated bytecode can contain some JDK 1.4 specific
>>
>>
>methods!
>
>
>>So as a safety measure, I've defaulted the target to 1.1 by default
>>(which is the default setting for JDK 1.1, 1.2 and 1.3 anyway).
>>
>>You can still overload this value on a project by project basis - this
>>just prevents this possible bug hitting Maven users.
>>
>> Revision Changes Path
>> 1.7 +2 -0 maven/src/plugins-build/java/xdocs/properties.xml
>>
>> Index: properties.xml
>> ===================================================================
>> RCS file:
>>
>>
>/home/cvs/maven/src/plugins-build/java/xdocs/properties.xml,v
>
>
>> retrieving revision 1.6
>> retrieving revision 1.7
>> diff -u -r1.6 -r1.7
>> --- properties.xml 22 Apr 2003 12:20:49 -0000 1.6
>> +++ properties.xml 26 Apr 2003 09:56:23 -0000 1.7
>> @@ -139,6 +139,8 @@
>> Corresponds to the <code>target</code> attribute for
>>
>>
>the ant
>
>
>> <a
>>
>>
>href="http://ant.apache.org/manual/CoreTasks/javac.html
>
>
>>">javac</a>
>> task.
>> + This value defaults to 1.1 so that builds on JDK 1.4
>>or later stil work on
>> + earlier JVMs.
>> </p>
>> </td>
>> </tr>
>>
>>
>>
>> 1.16 +2 -5 maven/src/plugins-build/java/plugin.jelly
>>
>> Index: plugin.jelly
>> ===================================================================
>> RCS file: /home/cvs/maven/src/plugins-build/java/plugin.jelly,v
>> retrieving revision 1.15
>> retrieving revision 1.16
>> diff -u -r1.15 -r1.16
>> --- plugin.jelly 17 Apr 2003 08:40:12 -0000 1.15
>> +++ plugin.jelly 26 Apr 2003 09:56:23 -0000 1.16
>> @@ -45,11 +45,12 @@
>>
>> <j:choose>
>> <j:when test="${sourcesPresent == 'true'}">
>> - <ant:javac
>> + <ant:javac
>> destdir="${maven.build.dest}"
>> excludes="**/package.html"
>> debug="${maven.compile.debug}"
>> deprecation="${maven.compile.deprecation}"
>> + target="${maven.compile.target}"
>> optimize="${maven.compile.optimize}">
>> <ant:src>
>> <ant:path refid="maven.compile.src.set"/>
>> @@ -95,10 +96,6 @@
>>
>> <j:if test="${context.getVariable('maven.compile.source')!=
>>
>>
>null}">
>
>
>> <ant:setProperty name="source"
>>
>>
>value="${maven.compile.source}" />
>
>
>> - </j:if>
>> -
>> - <j:if test="${context.getVariable('maven.compile.target')!=
>>
>>
>null}">
>
>
>> - <ant:setProperty name="target"
>>
>>
>value="${maven.compile.target}" />
>
>
>> </j:if>
>>
>> <j:if test="${context.getVariable('maven.compile.
>>verbose') != null}">
>>
>>
>>
>> 1.3 +2 -1 maven/src/plugins-build/java/plugin.properties
>>
>> Index: plugin.properties
>> ===================================================================
>> RCS file: /home/cvs/maven/src/plugins-build/java/plugin.properties,v
>> retrieving revision 1.2
>> retrieving revision 1.3
>> diff -u -r1.2 -r1.3
>> --- plugin.properties 26 Mar 2003 10:27:17 -0000 1.2
>> +++ plugin.properties 26 Apr 2003 09:56:23 -0000 1.3
>> @@ -3,4 +3,5 @@
>> # -------------------------------------------------------------------
>>
>> maven.jar.manifest = ${maven.conf.dir}/Manifest.mf
>> -maven.jar.mainclass =
>> \ No newline at end of file
>> +maven.jar.mainclass =
>> +maven.compile.target = 1.1
>> \ No newline at end of file
>>
>>
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: cvs commit: maven/src/plugins-build/java plugin.jelly plugin.properties
Posted by di...@multitask.com.au.
Tabs.....
--
dIon Gillard, Multitask Consulting
Blog: http://www.freeroller.net/page/dion/Weblog
Work: http://www.multitask.com.au
jstrachan@apache.org wrote on 26/04/2003 07:56:23 PM:
> jstrachan 2003/04/26 02:56:23
>
> Modified: src/plugins-build/java/xdocs properties.xml
> src/plugins-build/java plugin.jelly plugin.properties
> Log:
> Defaulted the compile target to 1.1. If a build is done on JDK 1.4
> then it defaults to JDK 1.4, which means on some JVM's (e.g. IBM's JDK
> 1.3) the code won't work! Even if you're not using any JDK 1.4
> features. The generated bytecode can contain some JDK 1.4 specific
methods!
>
> So as a safety measure, I've defaulted the target to 1.1 by default
> (which is the default setting for JDK 1.1, 1.2 and 1.3 anyway).
>
> You can still overload this value on a project by project basis - this
> just prevents this possible bug hitting Maven users.
>
> Revision Changes Path
> 1.7 +2 -0 maven/src/plugins-build/java/xdocs/properties.xml
>
> Index: properties.xml
> ===================================================================
> RCS file:
/home/cvs/maven/src/plugins-build/java/xdocs/properties.xml,v
> retrieving revision 1.6
> retrieving revision 1.7
> diff -u -r1.6 -r1.7
> --- properties.xml 22 Apr 2003 12:20:49 -0000 1.6
> +++ properties.xml 26 Apr 2003 09:56:23 -0000 1.7
> @@ -139,6 +139,8 @@
> Corresponds to the <code>target</code> attribute for
the ant
> <a
href="http://ant.apache.org/manual/CoreTasks/javac.html
> ">javac</a>
> task.
> + This value defaults to 1.1 so that builds on JDK 1.4
> or later stil work on
> + earlier JVMs.
> </p>
> </td>
> </tr>
>
>
>
> 1.16 +2 -5 maven/src/plugins-build/java/plugin.jelly
>
> Index: plugin.jelly
> ===================================================================
> RCS file: /home/cvs/maven/src/plugins-build/java/plugin.jelly,v
> retrieving revision 1.15
> retrieving revision 1.16
> diff -u -r1.15 -r1.16
> --- plugin.jelly 17 Apr 2003 08:40:12 -0000 1.15
> +++ plugin.jelly 26 Apr 2003 09:56:23 -0000 1.16
> @@ -45,11 +45,12 @@
>
> <j:choose>
> <j:when test="${sourcesPresent == 'true'}">
> - <ant:javac
> + <ant:javac
> destdir="${maven.build.dest}"
> excludes="**/package.html"
> debug="${maven.compile.debug}"
> deprecation="${maven.compile.deprecation}"
> + target="${maven.compile.target}"
> optimize="${maven.compile.optimize}">
> <ant:src>
> <ant:path refid="maven.compile.src.set"/>
> @@ -95,10 +96,6 @@
>
> <j:if test="${context.getVariable('maven.compile.source')!=
null}">
> <ant:setProperty name="source"
value="${maven.compile.source}" />
> - </j:if>
> -
> - <j:if test="${context.getVariable('maven.compile.target')!=
null}">
> - <ant:setProperty name="target"
value="${maven.compile.target}" />
> </j:if>
>
> <j:if test="${context.getVariable('maven.compile.
> verbose') != null}">
>
>
>
> 1.3 +2 -1 maven/src/plugins-build/java/plugin.properties
>
> Index: plugin.properties
> ===================================================================
> RCS file: /home/cvs/maven/src/plugins-build/java/plugin.properties,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- plugin.properties 26 Mar 2003 10:27:17 -0000 1.2
> +++ plugin.properties 26 Apr 2003 09:56:23 -0000 1.3
> @@ -3,4 +3,5 @@
> # -------------------------------------------------------------------
>
> maven.jar.manifest = ${maven.conf.dir}/Manifest.mf
> -maven.jar.mainclass =
> \ No newline at end of file
> +maven.jar.mainclass =
> +maven.compile.target = 1.1
> \ No newline at end of file
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org