[jira] [Commented] (HBASE-15484) Correct the semantic of batch and partial

["Phil Yang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891776#comment-15891776 ] 

Phil Yang commented on HBASE-15484:
-----------------------------------

I find that KeyValueHeap.peak() just returns next Cell in current scanner, doesn't pass to QueryMatcher or filters. So moreCellsInRow logic in HRegion can not make sure we must have more. So parital(hasMoreCellsInRow) flag in Result is actually "mayHasMoreCellsInRow". If it is true, the result may still be the last Result for a row, and if it is false the result must be the last.

> Correct the semantic of batch and partial
> -----------------------------------------
>
>                 Key: HBASE-15484
>                 URL: https://issues.apache.org/jira/browse/HBASE-15484
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 1.2.0, 1.1.3
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15484-v1.patch, HBASE-15484-v2.patch, HBASE-15484-v3.patch, HBASE-15484-v4.patch
>
>
> Follow-up to HBASE-15325, as discussed, the meaning of setBatch and setAllowPartialResults should not be same. We should not regard setBatch as setAllowPartialResults.
> And isPartial should be define accurately.
> (Considering getBatch==MaxInt if we don't setBatch.) If result.rawcells.length<scan.getBatch && result is not the last part of this row, isPartial==true, otherwise isPartial == false. So if user don't setAllowPartialResults(true), isPartial should always be false.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)