You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Niklas Gustavsson <ni...@protocol7.com> on 2010/12/29 10:37:31 UTC
Re: svn commit: r1053570 - in /mina/vysper/trunk/server: core/
core/src/main/config/ core/src/main/java/org/apache/vysper/spring/
core/src/main/java/org/apache/vysper/xmpp/server/ extensions/xep0045-muc/
A few comments inline:
On Wed, Dec 29, 2010 at 10:00 AM, <be...@apache.org> wrote:
> Modified: mina/vysper/trunk/server/core/pom.xml
> URL: http://svn.apache.org/viewvc/mina/vysper/trunk/server/core/pom.xml?rev=1053570&r1=1053569&r2=1053570&view=diff
> ==============================================================================
> --- mina/vysper/trunk/server/core/pom.xml (original)
> +++ mina/vysper/trunk/server/core/pom.xml Wed Dec 29 09:00:33 2010
> @@ -106,13 +106,11 @@
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-log4j12</artifactId>
> - <scope>test</scope>
> </dependency>
>
> <dependency>
> <groupId>log4j</groupId>
> <artifactId>log4j</artifactId>
> - <scope>test</scope>
> </dependency>
These should be test scope, or slf4j-log4j12 and log4j would be
required for all downstream users, which seems contra productive given
we use a logging facade
> Modified: mina/vysper/trunk/server/extensions/xep0045-muc/pom.xml
> URL: http://svn.apache.org/viewvc/mina/vysper/trunk/server/extensions/xep0045-muc/pom.xml?rev=1053570&r1=1053569&r2=1053570&view=diff
> ==============================================================================
> --- mina/vysper/trunk/server/extensions/xep0045-muc/pom.xml (original)
> +++ mina/vysper/trunk/server/extensions/xep0045-muc/pom.xml Wed Dec 29 09:00:33 2010
> @@ -41,6 +41,82 @@
> <artifactId>vysper-core</artifactId>
> </dependency>
>
> + <dependency>
> + <groupId>commons-codec</groupId>
> + <artifactId>commons-codec</artifactId>
> + </dependency>
> +
> + <dependency>
> + <groupId>commons-io</groupId>
> + <artifactId>commons-io</artifactId>
> + <version>1.4</version>
> + </dependency>
> +
> + <dependency>
> + <groupId>org.apache.vysper</groupId>
> + <artifactId>nbxml</artifactId>
> + </dependency>
> +
> + <dependency>
> + <groupId>org.apache.vysper.extensions</groupId>
> + <artifactId>xep0045-muc</artifactId>
> + </dependency>
> +
> + <dependency>
> + <groupId>org.apache.vysper.extensions</groupId>
> + <artifactId>xep0060-pubsub</artifactId>
> + </dependency>
> +
> + <dependency>
> + <groupId>org.apache.vysper.extensions</groupId>
> + <artifactId>xep0124-xep0206-bosh</artifactId>
> + </dependency>
> +
> + <dependency>
> + <groupId>org.springframework</groupId>
> + <artifactId>spring</artifactId>
> + <optional>true</optional>
> + </dependency>
> +
> + <dependency>
> + <groupId>org.apache.mina</groupId>
> + <artifactId>mina-core</artifactId>
> + </dependency>
> +
> + <dependency>
> + <groupId>org.apache.mina</groupId>
> + <artifactId>mina-integration-jmx</artifactId>
> + <optional>true</optional>
> + </dependency>
> +
> + <dependency>
> + <groupId>javax.jcr</groupId>
> + <artifactId>jcr</artifactId>
> + </dependency>
> +
> + <dependency>
> + <groupId>org.apache.jackrabbit</groupId>
> + <artifactId>jackrabbit-core</artifactId>
> + </dependency>
> +
> + <!-- Logging -->
> + <dependency>
> + <groupId>org.slf4j</groupId>
> + <artifactId>slf4j-api</artifactId>
> + </dependency>
> +
> + <dependency>
> + <groupId>org.slf4j</groupId>
> + <artifactId>jcl-over-slf4j</artifactId>
> + <optional>true</optional>
> + </dependency>
> +
> + <dependency>
> + <groupId>net.sf.ehcache</groupId>
> + <artifactId>ehcache-core</artifactId>
> + <optional>true</optional>
> + </dependency>
> +
These should not be needed.
/niklas
Re: svn commit: r1053570 - in /mina/vysper/trunk/server: core/
core/src/main/config/ core/src/main/java/org/apache/vysper/spring/
core/src/main/java/org/apache/vysper/xmpp/server/ extensions/xep0045-muc/
Posted by Niklas Gustavsson <ni...@protocol7.com>.
On Wed, Dec 29, 2010 at 10:37 AM, Niklas Gustavsson
<ni...@protocol7.com> wrote:
> A few comments inline:
You beat me to it :-)
/niklas