You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Juan Pablo Santos Rodríguez (JIRA)" <ji...@apache.org> on 2017/12/16 19:26:00 UTC
[jira] [Resolved] (JSPWIKI-1064) Link to non-existing page doesn't
change if linked page is created
[ https://issues.apache.org/jira/browse/JSPWIKI-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juan Pablo Santos Rodríguez resolved JSPWIKI-1064.
--------------------------------------------------
Resolution: Fixed
Fix Version/s: 2.10.3
Hi Christian,
would you mind trying on 2.10.3-git-45? it should fix this issue.
When a page is saved, and the cache is active, there's a process which looks for all the page referers, in order to wipe them from the cache, so they don't keep showing an outdated edit link. The problem was, in those cases we were asking for an incorrect key on the cache, using only the name, whereas the cache stores the page renders using as a key the name and the version. As of 2.10.3-git-45, we only wipe from cache referers' last version, which should be more than enough..
Also, page renders are now taken/put from the cache only when there is a view ongoing (WikiContext is WikiContext.VIEW), doesn't make sense on other contexts/actions (i.e., attach, edit, preview etc.) where the page content / metadata / attachments may change.
> Link to non-existing page doesn't change if linked page is created
> ------------------------------------------------------------------
>
> Key: JSPWIKI-1064
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1064
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.10.3
> Environment: Redhat Enterprise Linux 7; Tomcat 6;
> Client: Internet explorer
> Reporter: Christian Fröhler
> Priority: Minor
> Fix For: 2.10.3
>
>
> Background:
> Links to non-existing pages in the same wiki look differently than links to existing pages.
> Clicking on a link to a non-existing page leads directly to the "Edit" View so that the page can easily be created.
> Problem:
> After the non-existing page has been created, the Link to that new page is still shown in the same way as a link to a non-existing page; Clicking the link leads to the Edit view
> To Reproduce:
> 1) On an existing page ("page1") create a link to a non-existing page ("page2")
> --> the link to "page2" is visible on "page1" and correctly shows up as a link to a non-existing page
> 2) Create "page2", and save it
> 3) Visit again "page1"
> Expected behavior: Link to page2 shows up as a normal link; clicking the link leads to the page2 in view mode
> Actual behavior: Link to page2 shows up as a link to a non-existing page; clicking the link leads to the Edit mode of page 2
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Re: [jira] [Resolved] (JSPWIKI-1064) Link to non-existing page
doesn't change if linked page is created
Posted by Harry Metske <ha...@gmail.com>.
This version of JSPWiki (2.10.3-git-45) has just been activated on
https://jspwiki-wiki.apache.org .
I also refreshed the dockerized version
<https://hub.docker.com/r/metskem/docker-jspwiki/> (Alpine: 3.3=>3.7
Tomcat: 8.5.15=>8.5.24 JSPWiki: 2.10.3-git-29 => 2.10.3-git-45) .
cheers,
Harry
On 16 December 2017 at 20:26, Juan Pablo Santos Rodríguez (JIRA) <
jira@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/JSPWIKI-1064?page=
> com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Juan Pablo Santos Rodríguez resolved JSPWIKI-1064.
> --------------------------------------------------
> Resolution: Fixed
> Fix Version/s: 2.10.3
>
> Hi Christian,
>
> would you mind trying on 2.10.3-git-45? it should fix this issue.
>
> When a page is saved, and the cache is active, there's a process which
> looks for all the page referers, in order to wipe them from the cache, so
> they don't keep showing an outdated edit link. The problem was, in those
> cases we were asking for an incorrect key on the cache, using only the
> name, whereas the cache stores the page renders using as a key the name and
> the version. As of 2.10.3-git-45, we only wipe from cache referers' last
> version, which should be more than enough..
>
> Also, page renders are now taken/put from the cache only when there is a
> view ongoing (WikiContext is WikiContext.VIEW), doesn't make sense on other
> contexts/actions (i.e., attach, edit, preview etc.) where the page content
> / metadata / attachments may change.
>
> > Link to non-existing page doesn't change if linked page is created
> > ------------------------------------------------------------------
> >
> > Key: JSPWIKI-1064
> > URL: https://issues.apache.org/jira/browse/JSPWIKI-1064
> > Project: JSPWiki
> > Issue Type: Bug
> > Components: Core & storage
> > Affects Versions: 2.10.3
> > Environment: Redhat Enterprise Linux 7; Tomcat 6;
> > Client: Internet explorer
> > Reporter: Christian Fröhler
> > Priority: Minor
> > Fix For: 2.10.3
> >
> >
> > Background:
> > Links to non-existing pages in the same wiki look differently than links
> to existing pages.
> > Clicking on a link to a non-existing page leads directly to the "Edit"
> View so that the page can easily be created.
> > Problem:
> > After the non-existing page has been created, the Link to that new page
> is still shown in the same way as a link to a non-existing page; Clicking
> the link leads to the Edit view
> > To Reproduce:
> > 1) On an existing page ("page1") create a link to a non-existing page
> ("page2")
> > --> the link to "page2" is visible on "page1" and correctly shows
> up as a link to a non-existing page
> > 2) Create "page2", and save it
> > 3) Visit again "page1"
> > Expected behavior: Link to page2 shows up as a normal link; clicking
> the link leads to the page2 in view mode
> > Actual behavior: Link to page2 shows up as a link to a non-existing
> page; clicking the link leads to the Edit mode of page 2
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.4.14#64029)
>