You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/12/08 16:49:50 UTC

[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1171: add config about logcleaner

PragmaTwice commented on code in PR #1171:
URL: https://github.com/apache/incubator-kvrocks/pull/1171#discussion_r1043577528


##########
src/config/config.cc:
##########
@@ -159,6 +159,8 @@ Config::Config() {
       {"migrate-sequence-gap", false, new IntField(&sequence_gap, 10000, 1, INT_MAX)},
       {"unixsocket", true, new StringField(&unixsocket, "")},
       {"unixsocketperm", true, new OctalField(&unixsocketperm, 0777, 1, INT_MAX)},
+      {"enablelogcleaner", false, new YesNoField(&enablelogcleaner, false)},
+      {"logcleanerday", false, new IntField(&logcleanerday, 365, 0, INT_MAX)},

Review Comment:
   Why the default value here is 365?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org