You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by jd...@apache.org on 2006/07/10 01:06:51 UTC

svn commit: r420367 - in /geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system: configuration/ServerOverrideTest.java repository/AbstractRepositoryTest.java rmi/RMIClassLoaderSpiImplTest.java

Author: jdillon
Date: Sun Jul  9 16:06:51 2006
New Revision: 420367

URL: http://svn.apache.org/viewvc?rev=420367&view=rev
Log:
Use logging instead of System.*

Modified:
    geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/configuration/ServerOverrideTest.java
    geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/repository/AbstractRepositoryTest.java
    geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/rmi/RMIClassLoaderSpiImplTest.java

Modified: geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/configuration/ServerOverrideTest.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/configuration/ServerOverrideTest.java?rev=420367&r1=420366&r2=420367&view=diff
==============================================================================
--- geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/configuration/ServerOverrideTest.java (original)
+++ geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/configuration/ServerOverrideTest.java Sun Jul  9 16:06:51 2006
@@ -45,10 +45,15 @@
 import java.util.Map;
 import java.util.Set;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
 /**
  * @version $Rev$ $Date$
  */
 public class ServerOverrideTest extends TestCase {
+    private static final Log log = LogFactory.getLog(ServerOverrideTest.class);
+    
     public void testBasics() throws Exception {
         GBeanOverride pizza = new GBeanOverride("Pizza", true);
         assertTrue(pizza.isLoad());
@@ -305,9 +310,7 @@
         xform.setOutputProperty(OutputKeys.INDENT, "yes");
         xform.setOutputProperty("{http://xml.apache.org/xslt}indent-amount", "2");
         xform.transform(new DOMSource(e), new StreamResult(out));
-        System.out.println();
-        System.out.println();
-        System.out.println(new String(out.toByteArray()));
+        log.debug(new String(out.toByteArray()));
         ByteArrayInputStream in = new ByteArrayInputStream(out.toByteArray());
         return parseXml(in, name);
     }

Modified: geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/repository/AbstractRepositoryTest.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/repository/AbstractRepositoryTest.java?rev=420367&r1=420366&r2=420367&view=diff
==============================================================================
--- geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/repository/AbstractRepositoryTest.java (original)
+++ geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/repository/AbstractRepositoryTest.java Sun Jul  9 16:06:51 2006
@@ -26,10 +26,15 @@
 import org.apache.geronimo.kernel.repository.ListableRepository;
 import org.apache.geronimo.kernel.repository.Version;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
 /**
  * @version $Rev$ $Date$
  */
 public class AbstractRepositoryTest extends TestCase {
+    private static final Log log = LogFactory.getLog(AbstractRepositoryTest.class);
+    
     protected ListableRepository repository;
     protected File rootRepoDir;
 
@@ -78,7 +83,7 @@
 
     public void testListAll() {
         SortedSet artifacts = repository.list();
-        System.out.println("Matched artifacts: "+artifacts);
+        log.debug("Matched artifacts: "+artifacts);
 
         assertTrue(artifacts.contains(new Artifact("org.foo", "test", "2.0.1", "properties")));
         assertFalse(artifacts.contains(new Artifact("Unknown", "artifact", "2.0.1", "properties")));

Modified: geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/rmi/RMIClassLoaderSpiImplTest.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/rmi/RMIClassLoaderSpiImplTest.java?rev=420367&r1=420366&r2=420367&view=diff
==============================================================================
--- geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/rmi/RMIClassLoaderSpiImplTest.java (original)
+++ geronimo/sandbox/svkmerge/m2migration/modules/system/src/test/org/apache/geronimo/system/rmi/RMIClassLoaderSpiImplTest.java Sun Jul  9 16:06:51 2006
@@ -27,13 +27,17 @@
 
 import junit.framework.TestCase;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
 /**
  * Unit tests for {@link RMIClassLoaderSpiImpl} class.
  *
  * @version $Rev$ $Date$
  */
-public class RMIClassLoaderSpiImplTest
-        extends TestCase {
+public class RMIClassLoaderSpiImplTest extends TestCase {
+    private static final Log log = LogFactory.getLog(RMIClassLoaderSpiImplTest.class);
+    
     private String baseURL;
     private String normalizedBaseURL;
 
@@ -50,8 +54,8 @@
             normalizedBaseURL = normalizedBaseURL.substring(0, normalizedBaseURL.length() - 1);
         }
 
-        System.out.println("Using base URL: " + baseURL);
-        System.out.println("Using normalized base URL: " + normalizedBaseURL);
+        log.debug("Using base URL: " + baseURL);
+        log.debug("Using normalized base URL: " + normalizedBaseURL);
     }
 
     public void testNormalizeURL() throws MalformedURLException {