You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dzeims <gi...@git.apache.org> on 2014/06/16 20:28:41 UTC
[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...
GitHub user dzeims opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/52
CB-6940: Android: context.getExternal* methods return null if sdcard isn't in mou...
...nted state, causing exceptions that prevent startup from reaching readystate
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dzeims/cordova-plugin-file master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/52.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #52
----
commit dabbd00804d8f68d2929bd96da82f184d84aaffe
Author: dzeims <dz...@users.noreply.github.com>
Date: 2014-06-16T18:24:23Z
CB-6940: context.getExternal* methods return null if sdcard isn't in mounted state, causing exceptions that prevent startup from reaching readystate
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...
Posted by dzeims <gi...@git.apache.org>.
Github user dzeims commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/52#issuecomment-46221077
My mistake, it should be NullPointerException. Updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...
Posted by dzeims <gi...@git.apache.org>.
Github user dzeims closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/52
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/52#issuecomment-46241179
I've accepted the first two and did the last fix at the same time. Can you close this pull request, since I don't remember how Apache wants us to do this. (I'm not kidding, I don't have the ability right in front of me)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...
Posted by dzeims <gi...@git.apache.org>.
Github user dzeims commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/52#issuecomment-46218127
I've updated the try/catch blocks and wrapped them with an Environment.getExternalStorageState() check I noticed was being used in FileUtils. From what I could tell, the documentation only seemed to narrow down the exception type to IOException.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---