You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Csaba Koncz <cs...@gmail.com> on 2019/01/12 14:41:09 UTC
Review Request 69731: RANGER-2321 Docker build fails due to PhantomJS
dependency
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69731/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-2321
https://issues.apache.org/jira/browse/RANGER-2321
Repository: ranger
Description
-------
- Docker image building installs the packages needed by installing and running PhantomJS
- modified Maven build so that PhantomJS downloading and execution can be skipped by adding -DskipJSTests to the command line
Diffs
-----
README.txt 8aa177927
build_ranger_using_docker.sh fa77d910f
security-admin/pom.xml 14cafb4b2
security-admin/src/main/webapp/package-lock.json 9deaf0071
security-admin/src/main/webapp/package.json 880f6b34f
security-admin/src/test/javascript/karma-common.conf.js 4dc9bb60f
security-admin/src/test/javascript/package-lock.json PRE-CREATION
security-admin/src/test/javascript/package.json PRE-CREATION
Diff: https://reviews.apache.org/r/69731/diff/1/
Testing
-------
The following succeeds and runs JavaScript tests:
```
./build_ranger_using_docker.sh -build_image mvn clean verify -am -pl security-admin
```
The following succeeds and does not run JavaScript tests and does not download PhantomJS:
```
mvn clean verify -am -pl security-admin -DskipJSTests
```
Thanks,
Csaba Koncz
Re: Review Request 69731: RANGER-2321 Docker build fails due to
PhantomJS dependency
Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69731/#review211940
-----------------------------------------------------------
Ship it!
Ship It!
- Zsombor Gegesy
On Jan. 13, 2019, 7:18 p.m., Csaba Koncz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69731/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2019, 7:18 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2321
> https://issues.apache.org/jira/browse/RANGER-2321
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - Docker image building installs the packages needed by installing and running PhantomJS
> - modified Maven build so that PhantomJS downloading and execution can be skipped by adding -DskipJSTests to the command line
>
>
> Diffs
> -----
>
> README.txt 8aa177927
> build_ranger_using_docker.sh fa77d910f
> security-admin/pom.xml 14cafb4b2
> security-admin/src/main/webapp/package-lock.json 9deaf0071
> security-admin/src/main/webapp/package.json 880f6b34f
> security-admin/src/test/javascript/karma-common.conf.js 4dc9bb60f
> security-admin/src/test/javascript/package-lock.json PRE-CREATION
> security-admin/src/test/javascript/package.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/69731/diff/2/
>
>
> Testing
> -------
>
> The following succeeds and runs JavaScript tests:
>
> ```
> ./build_ranger_using_docker.sh -build_image mvn clean verify -am -pl security-admin
> ```
>
> The following succeeds and does not run JavaScript tests and does not download PhantomJS:
> ```
> mvn clean verify -am -pl security-admin -DskipJSTests
> ```
>
>
> Thanks,
>
> Csaba Koncz
>
>
Re: Review Request 69731: RANGER-2321 Docker build fails due to
PhantomJS dependency
Posted by Csaba Koncz <cs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69731/
-----------------------------------------------------------
(Updated Jan. 13, 2019, 7:18 p.m.)
Review request for ranger.
Changes
-------
reference targed dir as ${project.build.directory}
Bugs: RANGER-2321
https://issues.apache.org/jira/browse/RANGER-2321
Repository: ranger
Description
-------
- Docker image building installs the packages needed by installing and running PhantomJS
- modified Maven build so that PhantomJS downloading and execution can be skipped by adding -DskipJSTests to the command line
Diffs (updated)
-----
README.txt 8aa177927
build_ranger_using_docker.sh fa77d910f
security-admin/pom.xml 14cafb4b2
security-admin/src/main/webapp/package-lock.json 9deaf0071
security-admin/src/main/webapp/package.json 880f6b34f
security-admin/src/test/javascript/karma-common.conf.js 4dc9bb60f
security-admin/src/test/javascript/package-lock.json PRE-CREATION
security-admin/src/test/javascript/package.json PRE-CREATION
Diff: https://reviews.apache.org/r/69731/diff/2/
Changes: https://reviews.apache.org/r/69731/diff/1-2/
Testing
-------
The following succeeds and runs JavaScript tests:
```
./build_ranger_using_docker.sh -build_image mvn clean verify -am -pl security-admin
```
The following succeeds and does not run JavaScript tests and does not download PhantomJS:
```
mvn clean verify -am -pl security-admin -DskipJSTests
```
Thanks,
Csaba Koncz
Re: Review Request 69731: RANGER-2321 Docker build fails due to
PhantomJS dependency
Posted by Csaba Koncz <cs...@gmail.com>.
> On Jan. 12, 2019, 10:12 p.m., Zsombor Gegesy wrote:
> > security-admin/pom.xml
> > Line 608 (original), 611 (patched)
> > <https://reviews.apache.org/r/69731/diff/1/?file=2119346#file2119346line611>
> >
> > ${basedir}/target is the same as ${project.build.directory}, isn't it? Can you use it everywhere?
correct, fixed it in the latest patch.
- Csaba
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69731/#review211937
-----------------------------------------------------------
On Jan. 13, 2019, 7:18 p.m., Csaba Koncz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69731/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2019, 7:18 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2321
> https://issues.apache.org/jira/browse/RANGER-2321
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - Docker image building installs the packages needed by installing and running PhantomJS
> - modified Maven build so that PhantomJS downloading and execution can be skipped by adding -DskipJSTests to the command line
>
>
> Diffs
> -----
>
> README.txt 8aa177927
> build_ranger_using_docker.sh fa77d910f
> security-admin/pom.xml 14cafb4b2
> security-admin/src/main/webapp/package-lock.json 9deaf0071
> security-admin/src/main/webapp/package.json 880f6b34f
> security-admin/src/test/javascript/karma-common.conf.js 4dc9bb60f
> security-admin/src/test/javascript/package-lock.json PRE-CREATION
> security-admin/src/test/javascript/package.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/69731/diff/2/
>
>
> Testing
> -------
>
> The following succeeds and runs JavaScript tests:
>
> ```
> ./build_ranger_using_docker.sh -build_image mvn clean verify -am -pl security-admin
> ```
>
> The following succeeds and does not run JavaScript tests and does not download PhantomJS:
> ```
> mvn clean verify -am -pl security-admin -DskipJSTests
> ```
>
>
> Thanks,
>
> Csaba Koncz
>
>
Re: Review Request 69731: RANGER-2321 Docker build fails due to
PhantomJS dependency
Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69731/#review211937
-----------------------------------------------------------
security-admin/pom.xml
Line 608 (original), 611 (patched)
<https://reviews.apache.org/r/69731/#comment297501>
${basedir}/target is the same as ${project.build.directory}, isn't it? Can you use it everywhere?
- Zsombor Gegesy
On Jan. 12, 2019, 2:41 p.m., Csaba Koncz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69731/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2019, 2:41 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2321
> https://issues.apache.org/jira/browse/RANGER-2321
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - Docker image building installs the packages needed by installing and running PhantomJS
> - modified Maven build so that PhantomJS downloading and execution can be skipped by adding -DskipJSTests to the command line
>
>
> Diffs
> -----
>
> README.txt 8aa177927
> build_ranger_using_docker.sh fa77d910f
> security-admin/pom.xml 14cafb4b2
> security-admin/src/main/webapp/package-lock.json 9deaf0071
> security-admin/src/main/webapp/package.json 880f6b34f
> security-admin/src/test/javascript/karma-common.conf.js 4dc9bb60f
> security-admin/src/test/javascript/package-lock.json PRE-CREATION
> security-admin/src/test/javascript/package.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/69731/diff/1/
>
>
> Testing
> -------
>
> The following succeeds and runs JavaScript tests:
>
> ```
> ./build_ranger_using_docker.sh -build_image mvn clean verify -am -pl security-admin
> ```
>
> The following succeeds and does not run JavaScript tests and does not download PhantomJS:
> ```
> mvn clean verify -am -pl security-admin -DskipJSTests
> ```
>
>
> Thanks,
>
> Csaba Koncz
>
>