You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@red-bean.com> on 2008/06/30 20:33:05 UTC

Re: svn commit: r31931 - in trunk/subversion: include libsvn_subr

julianfoad@tigris.org writes:
> Log:
> Introduce a mechanism for reporting malfunctions in the Subversion libraries.
> This enables assertion failures and other "can't happen" scenarios to be
> detected with the simplicity of traditional "assert" and "abort" statements
> while also enabling these events to be caught and handled by the application
> if the application so chooses. The default behaviour is to print an error
> message to stderr and abort.

Yay!

> --- trunk/subversion/include/svn_error.h (r31930)
> +++ trunk/subversion/include/svn_error.h (r31931)
> @@ -295,6 +295,104 @@ void svn_handle_warning(FILE *stream, sv
>     err->apr_err == SVN_ERR_RA_NOT_LOCKED ||                 \
>     err->apr_err == SVN_ERR_FS_LOCK_EXPIRED)
>  
> [...]
>
> +/** Helper function for the macros that report malfunctions. */
> +svn_error_t *
> +svn_error__malfunction(const char *file, int line, const char *expr);

Real doc string?  (Even for helper functions.)

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r31931 - in trunk/subversion: include libsvn_subr

Posted by Julian Foad <ju...@btopenworld.com>.
On Mon, 2008-06-30 at 16:33 -0400, Karl Fogel wrote:
> julianfoad@tigris.org writes:
> > Log:
> > Introduce a mechanism for reporting malfunctions in the Subversion libraries.
> > This enables assertion failures and other "can't happen" scenarios to be
> > detected with the simplicity of traditional "assert" and "abort" statements
> > while also enabling these events to be caught and handled by the application
> > if the application so chooses. The default behaviour is to print an error
> > message to stderr and abort.
> 
> Yay!
> 
> > --- trunk/subversion/include/svn_error.h (r31930)
> > +++ trunk/subversion/include/svn_error.h (r31931)
> > @@ -295,6 +295,104 @@ void svn_handle_warning(FILE *stream, sv
> >     err->apr_err == SVN_ERR_RA_NOT_LOCKED ||                 \
> >     err->apr_err == SVN_ERR_FS_LOCK_EXPIRED)
> >  
> > [...]
> >
> > +/** Helper function for the macros that report malfunctions. */
> > +svn_error_t *
> > +svn_error__malfunction(const char *file, int line, const char *expr);
> 
> Real doc string?  (Even for helper functions.)

Ah, yes, of course... Coming right up.

r31934.

Thanks.
- Julian



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org