[shardingsphere] branch master updated: Refactor Calcite executor (#8863)

[me...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

menghaoran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new cfdc645  Refactor Calcite executor (#8863)
cfdc645 is described below

commit cfdc645f0398c235c702caecfae7b4c1a2e137e4
Author: Juan Pan(Trista) <pa...@apache.org>
AuthorDate: Sun Jan 3 17:23:57 2021 +0800

    Refactor Calcite executor (#8863)
    
    * Refactor Calcite executor
    
    * fix
    
    * fix ut
    
    * remove exception
    
    * add todo
---
 .../shardingsphere/infra/optimize/context/CalciteContextFactory.java   | 1 +
 .../infra/optimize/schema/CalciteLogicTableGenerator.java              | 3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/context/CalciteContextFactory.java b/shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/context/CalciteContextFactory.java
index 535b672..2b24ded 100644
--- a/shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/context/CalciteContextFactory.java
+++ b/shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/context/CalciteContextFactory.java
@@ -69,6 +69,7 @@ public final class CalciteContextFactory {
     }
     
     private Properties createProperties() {
+        // TODO Not only MySQL here.
         Properties result = new Properties();
         result.setProperty("lex", Lex.MYSQL.name());
         result.setProperty("conformance", SqlConformanceEnum.MYSQL_5.name());
diff --git a/shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/schema/CalciteLogicTableGenerator.java b/shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/schema/CalciteLogicTableGenerator.java
index efd61a7..51659f1 100644
--- a/shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/schema/CalciteLogicTableGenerator.java
+++ b/shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/schema/CalciteLogicTableGenerator.java
@@ -84,9 +84,8 @@ public final class CalciteLogicTableGenerator {
      *
      * @param executor executor
      * @return table
-     * @exception SQLException sql exception
      */
-    public Table create(final CalciteInternalExecutor executor) throws SQLException {
+    public Table create(final CalciteInternalExecutor executor) {
         return new CalciteFilterableTable(tableMetaData, relProtoDataType, executor);
     }
 }