You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by "yongwww (via GitHub)" <gi...@apache.org> on 2023/04/05 17:32:13 UTC

[GitHub] [tvm] yongwww commented on pull request #14493: [Unity][Op] introduce `ScatterElement` op

yongwww commented on PR #14493:
URL: https://github.com/apache/tvm/pull/14493#issuecomment-1497867762

   Not sure if this ScatterElement will be used by some other ops as well. I feel we can handle this scattering stuff in strided_slice itself. For example, the strided_slice is able to support begin/end has less elements than the rank of input data: https://github.com/apache/tvm/blob/unity/tests/python/topi/python/test_topi_transform.py#L850
   
   BTW, the ICHECK_LE in the posted sample expects the begin/end has equal (or less) elements


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org