You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/07/21 08:06:03 UTC

[GitHub] [hudi] bvaradar commented on a change in pull request #1819: [HUDI-1058] Make delete marker configurable

bvaradar commented on a change in pull request #1819:
URL: https://github.com/apache/hudi/pull/1819#discussion_r457912958



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -337,9 +337,15 @@ private void refreshTimeline() throws IOException {
     }
 
     JavaRDD<GenericRecord> avroRDD = avroRDDOptional.get();
+    if (writeClient == null) {
+      this.schemaProvider = schemaProvider;
+      setupWriteClient();

Review comment:
       +1, lets not create the write client here. As we are setting the field (including defaults) from DataSourceReadOptions, you can use the TypedProperties to get it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org