You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/06/17 15:35:33 UTC
[GitHub] [tinkerpop] spmallette opened a new pull request #1299: TINKERPOP-2076 Build on Java 11
spmallette opened a new pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299
https://issues.apache.org/jira/browse/TINKERPOP-2076
Not sure what else to say - finally done.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-650290287
Docker builds are now unstable. Something strange with surefire/failsafe plugins. Seems like it is a known problem, but I'm not sure what is only triggering it now. This body of work never seems to find a bottom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] porunov commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
porunov commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-652671192
@LifeIsStrange there are small breaking changes in Java 9, 10 and 11. The things are a little bit more complicated now because depending on what your `jar` uses (which was compiled with jdk 8), it now may work or may not work in javac 9, 10 or 11.
Thus, the project can't easily be updated to later java if it uses some old deps which won't work.
@spmallette Thank you for such a great update!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-651805851
@LifeIsStrange we can only move at the pace allowed by downstream libraries we depend on. spark 3.0 just only released a few weeks ago with jdk11 support. hadoop is still working on proper jdk11 support https://cwiki.apache.org/confluence/display/HADOOP/Hadoop+Java+Versions but luckily doesn't affect our build, but does affect local documentation generation, so we could move forward without it. Never mind issues with maven plugin infrastructure and jdk11 support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] darkduckgo commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
darkduckgo commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-1020121554
@spmallette sorry to disturb, with the java 17 (the latest LTS version) published
it's important for graph database like neo4j/JanusGraph which is based on Java env to improve the `GC` perf with the stable `zgc` or `oneGC` maybe. (especially for low latency or large memory env)
So will tinkerpop have the plan to support build in java17? (the Java11 will end lifecycle in 2026), or provide a TODO list for adopt it, we can help to solve them together.
BTW, @porunov will Janus consider support Java17 in next release version? or in a roadmap maybe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-650541761
Just got an error building locally now over surefire/failsafe. same issue as i was once having with docker:
```text
# Created at 2020-06-27T06:40:14.303
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '#'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '#'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.303
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '# A fatal error has been detected by the Java Runtime Environment:'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '# A fatal error has been detected by the Java Runtime Environment:'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.303
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '#'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '#'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.303
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '# SIGSEGV (0xb) at pc=0x00007f74e7fb610b, pid=29287, tid=29309'.
# Created at 2020-06-27T06:40:14.303
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '#'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '#'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.303
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '# JRE version: OpenJDK Runtime Environment (11.0.6+10) (build 11.0.6+10)'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '# JRE version: OpenJDK Runtime Environment (11.0.6+10) (build 11.0.6+10)'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.303
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '# Java VM: OpenJDK 64-Bit Server VM (11.0.6+10, mixed mode, tiered, compressed oops, g1 gc, linux-amd64)'.
# Created at 2020-06-27T06:40:14.303
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '# Problematic frame:'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '# Problematic frame:'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.310
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '# V [libjvm.so+0x85410b] IndexSetIterator::advance_and_next()+0x11b'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '# V [libjvm.so+0x85410b] IndexSetIterator::advance_and_next()+0x11b'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.311
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '#'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '#'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.311
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '# Core dump will be written. Default location: Core dumps may be processed with "/usr/share/apport/apport %p %s %c %d %P %E" (or dumping to /home/smallette/git/apache/tinkerpop/neo4j-gremlin/core.29287)'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '# Core dump will be written. Default location: Core dumps may be processed with "/usr/share/apport/apport %p %s %c %d %P %E" (or dumping to /home/smallette/git/apache/tinkerpop/neo4j-gremlin/core.29287)'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.311
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '#'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '#'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.311
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '# An error report file with more information is saved as:'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '# An error report file with more information is saved as:'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.311
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '# /home/smallette/git/apache/tinkerpop/neo4j-gremlin/hs_err_pid29287.log'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '# /home/smallette/git/apache/tinkerpop/neo4j-gremlin/hs_err_pid29287.log'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.333
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '#'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '#'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.333
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '# Compiler replay data is saved as:'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '# Compiler replay data is saved as:'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.333
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '# /home/smallette/git/apache/tinkerpop/neo4j-gremlin/replay_pid29287.log'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '# /home/smallette/git/apache/tinkerpop/neo4j-gremlin/replay_pid29287.log'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.333
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '#'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '#'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.333
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '# If you would like to submit a bug report, please visit:'.
# Created at 2020-06-27T06:40:14.333
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '# https://github.com/AdoptOpenJDK/openjdk-support/issues'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '# https://github.com/AdoptOpenJDK/openjdk-support/issues'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
# Created at 2020-06-27T06:40:14.333
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '#'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command '#'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:507)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:210)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:177)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:834)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-1020469569
There is an open issue about JPMS somewhere - I've not had time to investigate it. I probably need to read up more on how that should/could be used. Of course, we're still building to to java 8 compatible bytecode even on jdk11. We really haven't taken advantage of any any non-jdk8 features as of yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-649471627
Yes - it is working but doc generation is not. I'm glad I checked that. I'm not sure I had before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-1020469569
There is an open issue about JPMS somewhere - I've not had time to investigate it. I probably need to read up more on how that should/could be used. Of course, we're still building to to java 8 compatible bytecode even on jdk11. We really haven't taken advantage of any any non-jdk8 features as of yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] LifeIsStrange edited a comment on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
LifeIsStrange edited a comment on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-1020460346
@spmallette I don't know enough about the topic but I was wondering wether JDK 9 modules would allow to eliminate conflicts between libraries java runtime versions?
https://en.m.wikipedia.org/wiki/Java_Platform_Module_System
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] darkduckgo edited a comment on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
darkduckgo edited a comment on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-1020121554
@spmallette sorry to disturb, I didn't fond somewhere to submit new issue, so append message here... (tmp)
With the Java 17 (the latest LTS version) published, it's important for graph database like neo4j/JanusGraph which is based on Java env to improve the `GC` perf with the stable `zgc` or `oneGC` maybe. (especially for low latency or large memory env)
So will tinkerpop have the plan to support build in java17? (the Java11 will end lifecycle in 2026), or provide a TODO list to adopt it, we can help to solve them together.
BTW, @porunov will Janus consider support Java17 in next release version? or in a roadmap maybe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-650346479
I was able to get two good docker builds in a row with the latest commit. I had to get rid of my old docker images and rebuild incidentally. Continuing testing of other build options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] jorgebay commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
jorgebay commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-648765037
> I think we should add a job below using openjdk8
I still think having a job with jdk 8 will give us the certainty that it actually runs on jdk 8. In my experience different runtimes sometimes exhibit quirks and different behaviors even if the API contract is the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] darkduckgo edited a comment on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
darkduckgo edited a comment on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-1020121554
@spmallette sorry to disturb, I didn't fond somewhere to submit new issue, so append message here... (tmp)
With the Java 17 (the latest LTS version) published, it's important for graph database like `neo4j/JanusGraph/...` which is based on Java env to improve the `GC` perf with the stable `zgc` or `oneGC` maybe. (especially for low latency or large memory env)
So will tinkerpop have the plan to support build in java17? (the Java11 will end lifecycle in 2026), or provide a TODO list to adopt it, we can help to solve them together.
BTW, @porunov will Janus consider support Java17 in next release version? or in a roadmap maybe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] LifeIsStrange commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
LifeIsStrange commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-1020460346
@spmallette I don't know enough about the topic but I was wondering wether JDK 9 modules eliminate conflicts between libraries java runtime versions?
https://en.m.wikipedia.org/wiki/Java_Platform_Module_System
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-645979055
> Are we dropping support for jdk 8 altogether?
I think we are dropping support for buliding on jdk8, at least insofar as our maven configuration. You need jdk11 to build going forward. However, we support running on jdk8.
I'm glad you brought this up because I still had an old configuration in there from some early testing I was doing that had the release version at 11. It needed to be set at 8.
https://github.com/apache/tinkerpop/pull/1299/commits/23fe7dea89f5d65f6e11b828e5fa5d4d62a68767
The cross-compilation option is described here:
http://openjdk.java.net/jeps/247
> I think we should add a job below using openjdk8, that way we know that we are not breaking java 8 support.
My understanding here is that this setting would catch those situations where we used something incompatible with jdk8 at compile time. In this way we would not need to explicitly build on jdk8. I suppose there could be some argument to somehow test the jdk11 built artifacts on jdk8 but I guess that would take some extra work here.
The guidance on this stuff has been scattered and unclear in some ways. What I've outline here has been gathered from a wide variety of blog posts, stackoverflow comments, etc. If I'm misunderstanding something, please let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] LifeIsStrange edited a comment on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
LifeIsStrange edited a comment on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-1020460346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] LifeIsStrange commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
LifeIsStrange commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-651719373
Why not Java 13 or 14? Java 15 will reach general availability this september and the generated bytecode will still be compatible for clients having an openjdk 8.
Java devs has a culture of lagging years behing the stable releases despite having a language designed with excellent backward compatibility in mind.
I feel that java would loose less marketshare over C#, Go and others competitors if like them, the devs used the actual language and not a decade old version of it.
Anyway sorry for my rant it has nothing specific to do with tinkerpop but I wanted to say it.
This PR is still an improvement but feels to me a little bit too little too late.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-1020206626
personally, I have no problem with advancing the version of JDK support but if our dependencies don't support the JDK version we want to target then that can cause problems. i havent' looked at jdk17 yet to know what those problems would be. so far there is at least this issue to sort out: https://issues.apache.org/jira/browse/TINKERPOP-2633 further discussion on this topic should probably happen there or on the dev list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-651702036
With some added changes, this seems to be working now. Running more tests today and then expect to immediately merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vtslab commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
vtslab commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-650559546
Sounds frustrating, indeed. The following fix was merged in failsafe-2.2.2: https://github.com/apache/maven-surefire/commit/18b4078de24a0cd69eb51cad4e793d4e51b26743 and I see and older version in the TinkerPop pom.xml. Worth a try.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] LifeIsStrange commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
LifeIsStrange commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-1020460346
@spmallette I don't know enough about the topic but I was wondering wether JDK 9 modules eliminate conflicts between libraries java runtime versions?
https://en.m.wikipedia.org/wiki/Java_Platform_Module_System
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] LifeIsStrange edited a comment on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
LifeIsStrange edited a comment on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-651719373
Why not Java 13 or 14? Java 15 will reach general availability this september and the generated bytecode will still be compatible for clients having an openjdk 8.
Java devs have a culture of lagging years behing the stable releases despite having a language designed with excellent backward compatibility in mind.
I feel that java would loose less marketshare over C#, Go and others competitors if like them, the devs used the actual language and not a decade old version of it.
Anyway sorry for my rant it has nothing specific to do with tinkerpop but I wanted to say it.
This PR is still an improvement but feels to me a little bit too little too late.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
jorgebay commented on a change in pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#discussion_r442089259
##########
File path: .travis.yml
##########
@@ -2,9 +2,9 @@ language: java
os:
- linux
jdk:
- - openjdk8
+ - openjdk11
Review comment:
I think we should add a job below using `openjdk8`, that way we know that we are not breaking java 8 support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] jorgebay commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
jorgebay commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-649343988
It looks like last run went well!
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] LifeIsStrange edited a comment on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
LifeIsStrange edited a comment on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-1020460346
@spmallette I don't know enough about the topic but I was wondering wether JDK 9 modules would allow to eliminate conflicts between libraries java runtime versions?
https://en.m.wikipedia.org/wiki/Java_Platform_Module_System
Anyway thanks again for your contributions :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1299: TINKERPOP-2076 Build on Java 11
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-649752730
Docs are generating now. Have to re-run all the build options again to make sure everything is good. Hopefully no more problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org