You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhztheplayer (via GitHub)" <gi...@apache.org> on 2024/09/13 08:08:43 UTC
[PR] [VL] RAS: Fallback R2C whose schema contains complex data types [incubator-gluten]
zhztheplayer opened a new pull request, #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229
It's observed Velox R2C becomes expensive when containing complex data types as input. Add a coster in rough cost model to address the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Avoid adding R2C whose schema contains complex data types [incubator-gluten]
Posted by "FelixYBW (via GitHub)" <gi...@apache.org>.
FelixYBW commented on PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#issuecomment-2348380203
temp fix of #7223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Avoid adding R2C whose schema contains complex data types [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#discussion_r1758423529
##########
gluten-substrait/src/main/scala/org/apache/gluten/planner/cost/RoughCostModel.scala:
##########
@@ -34,6 +36,10 @@ class RoughCostModel extends LongCostModel {
// Make trivial ProjectExec has the same cost as ProjectExecTransform to reduce unnecessary
// c2r and r2c.
10L
+ case r2c: RowToColumnarExecBase if hasComplexTypes(r2c.schema) =>
+ // Avoid moving computation back to native when transition has complex types in schema.
+ // Such transitions are observed to be extreme expensive as of now.
+ Long.MaxValue
Review Comment:
Yes. It's just a heuristic as a temp solution.
##########
gluten-substrait/src/main/scala/org/apache/gluten/planner/cost/RoughCostModel.scala:
##########
@@ -34,6 +36,10 @@ class RoughCostModel extends LongCostModel {
// Make trivial ProjectExec has the same cost as ProjectExecTransform to reduce unnecessary
// c2r and r2c.
10L
+ case r2c: RowToColumnarExecBase if hasComplexTypes(r2c.schema) =>
+ // Avoid moving computation back to native when transition has complex types in schema.
+ // Such transitions are observed to be extreme expensive as of now.
+ Long.MaxValue
Review Comment:
Yes. it's just a heuristic as a temp solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Fallback R2C whose schema contains complex data types [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#issuecomment-2348309643
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Fallback R2C whose schema contains complex data types [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#issuecomment-2348307722
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Fallback R2C whose schema contains complex data types [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#issuecomment-2348308492
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Avoid adding R2C whose schema contains complex data types [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#discussion_r1758423529
##########
gluten-substrait/src/main/scala/org/apache/gluten/planner/cost/RoughCostModel.scala:
##########
@@ -34,6 +36,10 @@ class RoughCostModel extends LongCostModel {
// Make trivial ProjectExec has the same cost as ProjectExecTransform to reduce unnecessary
// c2r and r2c.
10L
+ case r2c: RowToColumnarExecBase if hasComplexTypes(r2c.schema) =>
+ // Avoid moving computation back to native when transition has complex types in schema.
+ // Such transitions are observed to be extreme expensive as of now.
+ Long.MaxValue
Review Comment:
Yes. it's just a heuristic as a temp solution from query optimizer side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Avoid adding R2C whose schema contains complex data types [incubator-gluten]
Posted by "jinchengchenghh (via GitHub)" <gi...@apache.org>.
jinchengchenghh commented on code in PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#discussion_r1758414748
##########
gluten-substrait/src/main/scala/org/apache/gluten/planner/cost/RoughCostModel.scala:
##########
@@ -34,6 +36,10 @@ class RoughCostModel extends LongCostModel {
// Make trivial ProjectExec has the same cost as ProjectExecTransform to reduce unnecessary
// c2r and r2c.
10L
+ case r2c: RowToColumnarExecBase if hasComplexTypes(r2c.schema) =>
+ // Avoid moving computation back to native when transition has complex types in schema.
+ // Such transitions are observed to be extreme expensive as of now.
+ Long.MaxValue
Review Comment:
We can use it as a temp solution. The r2c is very expensive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Fallback R2C whose schema contains complex data types [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#issuecomment-2348307200
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Avoid adding R2C whose schema contains complex data types [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#issuecomment-2348337131
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Avoid adding R2C whose schema contains complex data types [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer merged PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Avoid adding R2C whose schema contains complex data types [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#issuecomment-2348324146
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Avoid adding R2C whose schema contains complex data types [incubator-gluten]
Posted by "jinchengchenghh (via GitHub)" <gi...@apache.org>.
jinchengchenghh commented on code in PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#discussion_r1758411766
##########
gluten-substrait/src/main/scala/org/apache/gluten/planner/cost/RoughCostModel.scala:
##########
@@ -34,6 +36,10 @@ class RoughCostModel extends LongCostModel {
// Make trivial ProjectExec has the same cost as ProjectExecTransform to reduce unnecessary
// c2r and r2c.
10L
+ case r2c: RowToColumnarExecBase if hasComplexTypes(r2c.schema) =>
+ // Avoid moving computation back to native when transition has complex types in schema.
+ // Such transitions are observed to be extreme expensive as of now.
+ Long.MaxValue
Review Comment:
Can we add a more reasonable value to the cost? How can we measure the operator cost now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Avoid adding R2C whose schema contains complex data types [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#issuecomment-2348334638
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Avoid adding R2C whose schema contains complex data types [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#issuecomment-2348329867
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Avoid adding R2C whose schema contains complex data types [incubator-gluten]
Posted by "FelixYBW (via GitHub)" <gi...@apache.org>.
FelixYBW commented on PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#issuecomment-2351299140
Looks it doesn't work. Let me check what happens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] RAS: Fallback R2C whose schema contains complex data types [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#issuecomment-2348316680
cc @FelixYBW @jinchengchenghh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org