You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laurel Hale (Code Review)" <ge...@cloudera.org> on 2017/01/19 23:31:31 UTC

[Impala-ASF-CR] removed 'without Cloudera Manager' from two titles

Laurel Hale has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5749

Change subject: removed 'without Cloudera Manager' from two titles
......................................................................

removed 'without Cloudera Manager' from two titles

Change-Id: I224d72cac253037374c71ab1a618023cfeb9a7f6
---
M docs/topics/impala_noncm_installation.xml
M docs/topics/impala_upgrading.xml
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/5749/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I224d72cac253037374c71ab1a618023cfeb9a7f6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>

[Impala-ASF-CR] Remove 'without Cloudera Manager' from two titles

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: Remove 'without Cloudera Manager' from two titles
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I224d72cac253037374c71ab1a618023cfeb9a7f6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] Remove 'without Cloudera Manager' from two titles

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.

Change subject: Remove 'without Cloudera Manager' from two titles
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I224d72cac253037374c71ab1a618023cfeb9a7f6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] removed 'without Cloudera Manager' from two titles

Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.

Change subject: removed 'without Cloudera Manager' from two titles
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5749/1//COMMIT_MSG
Commit Message:

PS1, Line 7: removed
Capitalize + use the imperative mood in the subject line,
ie, change to "Remove"


-- 
To view, visit http://gerrit.cloudera.org:8080/5749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I224d72cac253037374c71ab1a618023cfeb9a7f6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] Remove 'without Cloudera Manager' from two titles

Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has uploaded a new patch set (#2).

Change subject: Remove 'without Cloudera Manager' from two titles
......................................................................

Remove 'without Cloudera Manager' from two titles

Change-Id: I224d72cac253037374c71ab1a618023cfeb9a7f6
---
M docs/topics/impala_noncm_installation.xml
M docs/topics/impala_upgrading.xml
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/5749/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I224d72cac253037374c71ab1a618023cfeb9a7f6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>

[Impala-ASF-CR] Remove 'without Cloudera Manager' from two titles

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: Remove 'without Cloudera Manager' from two titles
......................................................................


Patch Set 2:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/24/

-- 
To view, visit http://gerrit.cloudera.org:8080/5749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I224d72cac253037374c71ab1a618023cfeb9a7f6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] removed 'without Cloudera Manager' from two titles

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.

Change subject: removed 'without Cloudera Manager' from two titles
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5749/1/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:

Line 268:         To upgrade Impala on a cluster not managed by Cloudera Manager, run these Linux commands on the appropriate
are these refs to CM going to stay?


-- 
To view, visit http://gerrit.cloudera.org:8080/5749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I224d72cac253037374c71ab1a618023cfeb9a7f6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] Remove 'without Cloudera Manager' from two titles

Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.

Change subject: Remove 'without Cloudera Manager' from two titles
......................................................................


Patch Set 2:

(2 comments)

Fixed the commit message as recommended. Thank you.

http://gerrit.cloudera.org:8080/#/c/5749/1//COMMIT_MSG
Commit Message:

PS1, Line 7: Remove 
> Capitalize + use the imperative mood in the subject line,
Will do. I'm learning. Thank you.


http://gerrit.cloudera.org:8080/#/c/5749/1/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:

Line 268:         To upgrade Impala on a cluster not managed by Cloudera Manager, run these Linux commands on the appropriate
> are these refs to CM going to stay?
No, this was really just a test to make sure I can post gerrit reviews. These will definitely be removed in a subsequent patch. Thanks


-- 
To view, visit http://gerrit.cloudera.org:8080/5749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I224d72cac253037374c71ab1a618023cfeb9a7f6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] Remove 'without Cloudera Manager' from two titles

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: Remove 'without Cloudera Manager' from two titles
......................................................................


Remove 'without Cloudera Manager' from two titles

Change-Id: I224d72cac253037374c71ab1a618023cfeb9a7f6
Reviewed-on: http://gerrit.cloudera.org:8080/5749
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_noncm_installation.xml
M docs/topics/impala_upgrading.xml
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I224d72cac253037374c71ab1a618023cfeb9a7f6
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>