[jira] [Commented] (PIG-3001) TestExecutableManager.testAddJobConfToEnv fails randomly

["Jonathan Coveney (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483848#comment-13483848 ] 

Jonathan Coveney commented on PIG-3001:
---------------------------------------

Cheolsoo,

I am not a fan of this policy (though I understand why we have it), but we generally make patches without whitespace changes. Can you upload a new version without whitespace changes?

Thanks for the contribution. It looks good to me.
Jon
                
> TestExecutableManager.testAddJobConfToEnv fails randomly
> --------------------------------------------------------
>
>                 Key: PIG-3001
>                 URL: https://issues.apache.org/jira/browse/PIG-3001
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Gianmarco De Francisci Morales
>            Assignee: Cheolsoo Park
>            Priority: Minor
>         Attachments: PIG-3001-2.patch, PIG-3001.patch
>
>
> The test in the Summary fails intermittently.
> This is due to using a random number generator without seeding it.
> We should avoid stochastic tests.
> Furthermore, the test itself is ill conceived.
> Here the failure summary:
> {code}
> 12/10/23 11:02:48 WARN streaming.ExecutableManager: Property set in pig.streaming.environment not found in Configuration: ⻨ꢏ切歯
> 12/10/23 11:02:48 WARN streaming.ExecutableManager: Property set in pig.streaming.environment not found in Configuration: 狓偝
> 12/10/23 11:02:48 WARN streaming.ExecutableManager: Property set in pig.streaming.environment not found in Configuration: 墣챟㌌̀썬鼹騷
> 12/10/23 11:02:48 WARN streaming.ExecutableManager: Property set in pig.streaming.environment not found in Configuration: 훎滼
> {code}
> {code}
> Error Message:
> There should be no remaining pairs in the included map
> Stacktrace:
> junit.framework.AssertionFailedError: There should be no remaining pairs in the included map
> 	at org.apache.pig.impl.streaming.TestExecutableManager.testAddJobConfToEnv(TestExecutableManager.java:84)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira