[mynewt-newt] branch master updated: Emit toolchain output to stdout

[cc...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ccollins pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git


The following commit(s) were added to refs/heads/master by this push:
     new ce51d12  Emit toolchain output to stdout
ce51d12 is described below

commit ce51d12b18ae5dd7a1c33574fbb76e83480dc391
Author: Christopher Collins <cc...@apache.org>
AuthorDate: Tue Sep 17 09:35:10 2019 -0500

    Emit toolchain output to stdout
    
    Newt was discarding all toolchain output (compiler, linker, etc).  If
    there were any compiler warnings, they would not be visible to the user.
    
    This commit makes newt emit all toolchain output.  If there are no
    warnings, there is no extra output.
---
 newt/toolchain/compiler.go | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/newt/toolchain/compiler.go b/newt/toolchain/compiler.go
index 3a94049..6831d7a 100644
--- a/newt/toolchain/compiler.go
+++ b/newt/toolchain/compiler.go
@@ -561,10 +561,11 @@ func (c *Compiler) CompileFile(file string, compilerType int) error {
 		return util.NewNewtError("Unknown compiler type")
 	}
 
-	_, err = util.ShellCommand(cmd, nil)
+	o, err := util.ShellCommand(cmd, nil)
 	if err != nil {
 		return err
 	}
+	util.StatusMessage(util.VERBOSITY_DEFAULT, "%s", string(o))
 
 	c.compileCommands = append(c.compileCommands,
 		CompileCommand{
@@ -918,10 +919,11 @@ func (c *Compiler) CompileBinary(dstFile string, options map[string]bool,
 	}
 
 	cmd := c.CompileBinaryCmd(dstFile, options, objFiles, keepSymbols, elfLib)
-	_, err := util.ShellCommand(cmd, nil)
+	o, err := util.ShellCommand(cmd, nil)
 	if err != nil {
 		return err
 	}
+	util.StatusMessage(util.VERBOSITY_DEFAULT, "%s", string(o))
 
 	err = writeCommandFile(dstFile, cmd)
 	if err != nil {
@@ -958,10 +960,11 @@ func (c *Compiler) generateExtras(elfFilename string,
 			elfFilename,
 			binFile,
 		}
-		_, err := util.ShellCommand(cmd, nil)
+		o, err := util.ShellCommand(cmd, nil)
 		if err != nil {
 			return err
 		}
+		util.StatusMessage(util.VERBOSITY_DEFAULT, "%s", string(o))
 	}
 
 	if options["listFile"] {
@@ -1223,10 +1226,11 @@ func (c *Compiler) CompileArchive(archiveFile string) error {
 	}
 
 	cmd := c.CompileArchiveCmd(archiveFile, objFiles)
-	_, err = util.ShellCommand(cmd, nil)
+	o, err := util.ShellCommand(cmd, nil)
 	if err != nil {
 		return err
 	}
+	util.StatusMessage(util.VERBOSITY_DEFAULT, "%s", string(o))
 
 	err = writeCommandFile(archiveFile, cmd)
 	if err != nil {
@@ -1310,9 +1314,13 @@ func (c *Compiler) RenameSymbols(sm *symbol.SymbolMap, libraryFile string, ext s
 
 	cmd := c.RenameSymbolsCmd(sm, libraryFile, ext)
 
-	_, err := util.ShellCommand(cmd, nil)
+	o, err := util.ShellCommand(cmd, nil)
+	if err != nil {
+		return err
+	}
+	util.StatusMessage(util.VERBOSITY_DEFAULT, "%s", string(o))
 
-	return err
+	return nil
 }
 
 func (c *Compiler) ParseLibrary(libraryFile string) (error, []byte) {
@@ -1347,9 +1355,11 @@ func (c *Compiler) ConvertBinToHex(inFile string, outFile string, baseAddr int)
 		inFile,
 		outFile,
 	}
-	_, err := util.ShellCommand(cmd, nil)
+	o, err := util.ShellCommand(cmd, nil)
 	if err != nil {
 		return err
 	}
+	util.StatusMessage(util.VERBOSITY_DEFAULT, "%s", string(o))
+
 	return nil
 }