[jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015113#comment-14015113 ] 

Hadoop QA commented on YARN-2117:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12647835/YARN-2117.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 javac{color:red}.  The patch appears to cause the build to fail.

Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3883//console

This message is automatically generated.

> Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2117
>                 URL: https://issues.apache.org/jira/browse/YARN-2117
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Chen He
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-2117.patch
>
>
> Here is related code:
> {code}
>         Reader reader = new FileReader(signatureSecretFile);
>         int c = reader.read();
>         while (c > -1) {
>           secret.append((char) c);
>           c = reader.read();
>         }
>         reader.close();
> {code}
> If IOException is thrown out of reader.read(), reader would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)