You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Greg Miller (Jira)" <ji...@apache.org> on 2021/07/26 20:37:00 UTC

[jira] [Created] (LUCENE-10036) Ensure ScoreCachingWrappingScorer doesn't unnecessarily wrap another ScoreCachingWrappingScorer

Greg Miller created LUCENE-10036:
------------------------------------

             Summary: Ensure ScoreCachingWrappingScorer doesn't unnecessarily wrap another ScoreCachingWrappingScorer
                 Key: LUCENE-10036
                 URL: https://issues.apache.org/jira/browse/LUCENE-10036
             Project: Lucene - Core
          Issue Type: Improvement
          Components: core/search
    Affects Versions: main (9.0)
            Reporter: Greg Miller


This is a trivial issue, but it's easy to mistakenly "double wrap" an instance of {{ScoreCachingWrappingScorer}}, which is a bit wasteful. The calling code currently needs to check the instance type of the {{Scorable}} they intend to wrap to avoid this. {{FieldComparator}} is actually the only calling code that does this check.

It would be nice to add a factory method that encapsulates this check in {{ScoreCachingWrappingScorer}} so that calling code doesn't need to worry about it.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org