[GitHub] [sling-org-apache-sling-distribution-journal] tmaret edited a comment on issue #19: SLING-8944 - Systemready check for idle subscriber

[GitBox <gi...@apache.org>]

tmaret edited a comment on issue #19: SLING-8944 - Systemready check for idle subscriber
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/19#issuecomment-568463194
 
 
   The new hooks make sense to me. However, I think that there's a bug in the code. I may be mistaken since I looked at it quickly. The schedule is currently canceled with 
   ```
   schedule.cancel(false);
   ```
   which allows it to complete a schedule when started.
   
   If we keep submitting a schedule per import, we should cancel it with
   
   ```
   schedule.cancel(true);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services