[GitHub] [druid] jihoonson commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length
URL: https://github.com/apache/druid/pull/9356#discussion_r380952595
 
 

 ##########
 File path: extensions-contrib/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureByteSource.java
 ##########
 @@ -63,12 +63,12 @@ public InputStream openStream(long offset) throws IOException
       return azureStorage.getBlobInputStream(offset, containerName, blobPath);
     }
     catch (StorageException | URISyntaxException e) {
-      log.warn("Exception when opening stream to azure resource, containerName: %s, blobPath: %s, Error: %s",
-               containerName, blobPath, e.getMessage()
-      );
       if (AzureUtils.AZURE_RETRY.apply(e)) {
         throw new IOException("Recoverable exception", e);
       }
+      log.warn("Exception when opening stream to azure resource, containerName: %s, blobPath: %s, Error: %s",
 
 Review comment:
   Should the log level be error instead of warn?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org