You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/18 18:41:57 UTC
[GitHub] [arrow] nealrichardson opened a new pull request, #14676: MINOR: [R] Simplify compare_dplyr_binding test helper
nealrichardson opened a new pull request, #14676:
URL: https://github.com/apache/arrow/pull/14676
A long time ago, dplyr expressions on Tables and RecordBatches were evaluated by calling compute functions on (Chunked)Arrays, calling Slice or Filter methods on the Tables/RBs, etc. So to make sure that all C++ bindings were exposed correctly, we needed to test that operations worked on both Tables and RecordBatches.
Today, everything goes through ExecPlans, and RecordBatches get wrapped in Tables in creating TableSourceNodes: https://github.com/apache/arrow/blob/master/r/R/query-engine.R#L63. So as long as we are able to create a Table from a RecordBatch (tested elsewhere), the query evaluation is identical. This means we don't need to test every dplyr query twice.
On my machine, this cuts off a little more than 1/3 of the running time of the dplyr tests, or about 20 seconds. The bigger benefit IMO is that when there is a failure in one of these expectations, you'll only get it once instead of twice, so it will be less confusing to see what's up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic merged pull request #14676: MINOR: [R] Simplify compare_dplyr_binding test helper
Posted by GitBox <gi...@apache.org>.
thisisnic merged PR #14676:
URL: https://github.com/apache/arrow/pull/14676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14676: MINOR: [R] Simplify compare_dplyr_binding test helper
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14676:
URL: https://github.com/apache/arrow/pull/14676#issuecomment-1324280589
Benchmark runs are scheduled for baseline = e9222ae00b515a0f57d8c7d54bdb19457d68582f and contender = 31dca2b262a9b73004519128ebf81acbb61e2fec. 31dca2b262a9b73004519128ebf81acbb61e2fec is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0% :warning: Contender and baseline run contexts do not match] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/200085f7e7be45be92f6d464c561b2d9...612d6c47993749af874852d1b538ee68/)
[Failed :arrow_down:0.4% :arrow_up:0.23%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ec5836272cce4353be5d63e313401b38...093df85d19ef47138ce5a97045fef5f4/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2b064961a5294c0b9444351d781a6307...624416df9b0041dd996cc19b366c283e/)
[Finished :arrow_down:0.42% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/429504a38d274e7388428164765231ae...e2c6be4e525b4522a9764b940606b3e7/)
Buildkite builds:
[Finished] [`31dca2b2` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1895)
[Failed] [`31dca2b2` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1917)
[Finished] [`31dca2b2` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1886)
[Finished] [`31dca2b2` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1909)
[Finished] [`e9222ae0` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1894)
[Failed] [`e9222ae0` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1916)
[Failed] [`e9222ae0` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1885)
[Finished] [`e9222ae0` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1908)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org