You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/27 16:26:35 UTC
[GitHub] [airflow] potiuk opened a new pull request #11892: Fixes backtick in the documentation
potiuk opened a new pull request #11892:
URL: https://github.com/apache/airflow/pull/11892
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11892: Fixes backtick in the documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11892:
URL: https://github.com/apache/airflow/pull/11892#issuecomment-717476040
It was failing the static checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11892: Fixes backtick in the documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11892:
URL: https://github.com/apache/airflow/pull/11892#issuecomment-717476408
so we had failing master @kaxil :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11892: Fixes backtick in the documentation
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11892:
URL: https://github.com/apache/airflow/pull/11892#issuecomment-717478398
aah, I didn't see this commit that added that line https://github.com/apache/airflow/commit/de5e8905e582a86c49bcfc6195d4731aa6be6c48
Thanks for fixing it -- these days, thanks to "Super Fast" Github Action Queues -- it is difficult to know the current status lol
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #11892: Fixes backtick in the documentation
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11892:
URL: https://github.com/apache/airflow/pull/11892#discussion_r512947861
##########
File path: docs/start.rst
##########
@@ -46,7 +46,7 @@ The installation is quick and straightforward.
airflow webserver --port 8080
# start the scheduler
- # open a new terminal or else run webserver with `-D` option to run it as a deamon
+ # open a new terminal or else run webserver with ``-D`` option to run it as a deamon
Review comment:
Isn't this just a comment, that won't be rendered?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #11892: Fixes backtick in the documentation
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11892:
URL: https://github.com/apache/airflow/pull/11892
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11892: Fixes backtick in the documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11892:
URL: https://github.com/apache/airflow/pull/11892#issuecomment-717503666
Indeed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org