You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@subversion.apache.org by br...@apache.org on 2014/02/28 23:46:46 UTC

svn commit: r1573101 - /subversion/trunk/subversion/libsvn_subr/sysinfo.c

Author: breser
Date: Fri Feb 28 22:46:46 2014
New Revision: 1573101

URL: http://svn.apache.org/r1573101
Log:
Followup to r1573096, handle possible error case when getting the
CFMutableDataRef.

* subversion/libsvn_subr/sysinfo.c
  (system_version_plist): Check for NULL and bail.

Modified:
    subversion/trunk/subversion/libsvn_subr/sysinfo.c

Modified: subversion/trunk/subversion/libsvn_subr/sysinfo.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/sysinfo.c?rev=1573101&r1=1573100&r2=1573101&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/sysinfo.c (original)
+++ subversion/trunk/subversion/libsvn_subr/sysinfo.c Fri Feb 28 22:46:46 2014
@@ -929,6 +929,10 @@ system_version_plist(svn_boolean_t *serv
   CFMutableDataRef resource = CFDataCreateMutable(kCFAllocatorDefault, 0);
   CFStringRef errstr = NULL;
 
+  /* failed getting the CFMutableDataRef, shouldn't happen */
+  if (!resource)
+    return NULL;
+
   /* Try to open the plist files to get the data */
   err = svn_stream_open_readonly(&read_stream, server_version, pool, pool);
   if (err)