You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/19 18:25:49 UTC

[GitHub] [beam] pabloem commented on a change in pull request #11166: [BEAM-7923] Emit info when capture control options are configured.

pabloem commented on a change in pull request #11166: [BEAM-7923] Emit info when capture control options are configured.
URL: https://github.com/apache/beam/pull/11166#discussion_r395233280
 
 

 ##########
 File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
 ##########
 @@ -64,11 +67,33 @@ def enable_capture_replay(self, value):
     and pipeline runs always use the same data captured; False - Disables
     capture of replayable source data so that following PCollection evaluation
     and pipeline runs always use new data from sources."""
+    # This makes sure the log handler is configured correctly in case the
+    # options are configured in an early stage.
+    _ = ie.current_env()
+    if value:
+      _LOGGER.info(
+          'Capture replay is enabled. When a PCollection is evaluated or the '
+          'pipeline is executed, existing data captured from previous '
+          'computations will be replayed for replayability. If no capture is '
+          'available, new data from capturable sources will be captured.')
+    else:
+      _LOGGER.info(
+          'You have disabled capture replay. The next time a PCollection is '
+          'evaluated or the pipeline is executed, new data will always be '
+          'captured from capturable sources. You will not have replayability '
+          'until re-enabling this option.')
     self.capture_control._enable_capture_replay = value
 
   @property
   def capturable_sources(self):
-    """Interactive Beam automatically captures data from sources in this set."""
+    """Interactive Beam automatically captures data from sources in this set.
+    """
+    _ = ie.current_env()
+    _LOGGER.info(
+        'If you alter the capturable sources, to allow new data for the '
+        'altered sources being captured the next time a PCollection is '
 
 Review comment:
   ```suggestion
           'altered sources to be captured the next time a PCollection is '
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services