You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/04 09:32:20 UTC

[GitHub] [incubator-tvm] ANSHUMAN87 edited a comment on pull request #5725: [Bugfix][Serialization] Fix runtime::String backward compatibility in JSON

ANSHUMAN87 edited a comment on pull request #5725:
URL: https://github.com/apache/incubator-tvm/pull/5725#issuecomment-638734857


   Thanks @junrushao1994 !
   As i remember, I had handled version upgrade for "GlobalVar" in PR (#5547).
   So maybe we need to discuss how it got bypassed?
   I saw the changes in jason_compact.py, just wonder why below code did not work:
   `"relay.GlobalVar": [_rename("GlobalVar"), _update_from_std_str("name_hint")],`
   
   I understand the issue is because of the key name difference "relay.Global" vs "Global".
   Please correct me if my understanding is wrong.
   
   I wonder whether json string is v0.6.0 based :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org