[GitHub] [cxf] andrei-ivanov commented on a diff in pull request #927: Merge Opensaml4 to Jakarta EE branch

[GitBox <gi...@apache.org>]

andrei-ivanov commented on code in PR #927:
URL: https://github.com/apache/cxf/pull/927#discussion_r841418598


##########
rt/rs/security/oauth-parent/oauth2-saml/src/main/java/org/apache/cxf/rs/security/oauth2/saml/SamlOAuthValidator.java:
##########
@@ -144,7 +145,7 @@ private void validateSubjectConfirmation(Message m,
                                              SubjectConfirmationData subjectConfData) {
         if (subjectConfData == null) {
             if (!subjectConfirmationDataRequired
-                && cs.getNotOnOrAfter() != null && !cs.getNotOnOrAfter().isBeforeNow()) {
+                && cs.getNotOnOrAfter() != null && !cs.getNotOnOrAfter().isBefore(Instant.now())) {

Review Comment:
   Hmm, indeed... somehow I confused it with other `now()` calls with use the JVM default.
   Sorry for the noise



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org