You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (Created) (JIRA)" <ji...@apache.org> on 2012/04/04 19:46:19 UTC

[jira] [Created] (LUCENE-3952) validate depends on compile-tools, which does too much

validate depends on compile-tools, which does too much
------------------------------------------------------

                 Key: LUCENE-3952
                 URL: https://issues.apache.org/jira/browse/LUCENE-3952
             Project: Lucene - Java
          Issue Type: Bug
          Components: general/build
            Reporter: Robert Muir


lucene's common-build.xml 'validate' depends on compile-tools, but some
modules like icu, kuromoji, etc have a compile-tools target (for other reasons).

I think it should explicitly depend on common.compile-tools instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3952) validate depends on compile-tools, which does too much

Posted by "Hoss Man (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246685#comment-13246685 ] 

Hoss Man commented on LUCENE-3952:
----------------------------------

with commit r1309556 you can no longer "ant clean compile" from the top level of checkout...

{noformat}
hossman@bester:~/lucene/dev$ ant clean compile
...
validate:
     [echo] Building spatial...

validate:
     [echo] Building suggest...

validate:
  [taskdef] Could not load definitions from resource lucene-solr.antlib.xml. It could not be found.
     [echo] License check under: /home/hossman/lucene/dev/modules

BUILD FAILED
/home/hossman/lucene/dev/build.xml:68: The following error occurred while executing this line:
/home/hossman/lucene/dev/modules/build.xml:68: The following error occurred while executing this line:
/home/hossman/lucene/dev/lucene/tools/custom-tasks.xml:22: Problem: failed to create task or type licenses
Cause: The name is undefined.
Action: Check the spelling.
Action: Check that any custom tasks/types have been declared.
Action: Check that any <presetdef>/<macrodef> declarations have taken place.


Total time: 14 seconds
{noformat}
                
> validate depends on compile-tools, which does too much
> ------------------------------------------------------
>
>                 Key: LUCENE-3952
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3952
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: general/build
>            Reporter: Robert Muir
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3952.patch
>
>
> lucene's common-build.xml 'validate' depends on compile-tools, but some
> modules like icu, kuromoji, etc have a compile-tools target (for other reasons).
> I think it should explicitly depend on common.compile-tools instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3952) validate depends on compile-tools, which does too much

Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3952:
--------------------------------

    Attachment: LUCENE-3952.patch

trivial patch: this placeholder task shouldnt depend on anything, it does nothing.

the top-level tasks are the ones actually invoking license-check-macro.
                
> validate depends on compile-tools, which does too much
> ------------------------------------------------------
>
>                 Key: LUCENE-3952
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3952
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: general/build
>            Reporter: Robert Muir
>         Attachments: LUCENE-3952.patch
>
>
> lucene's common-build.xml 'validate' depends on compile-tools, but some
> modules like icu, kuromoji, etc have a compile-tools target (for other reasons).
> I think it should explicitly depend on common.compile-tools instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-3952) validate depends on compile-tools, which does too much

Posted by "Robert Muir (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-3952.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0
                   3.6
    
> validate depends on compile-tools, which does too much
> ------------------------------------------------------
>
>                 Key: LUCENE-3952
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3952
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: general/build
>            Reporter: Robert Muir
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3952.patch
>
>
> lucene's common-build.xml 'validate' depends on compile-tools, but some
> modules like icu, kuromoji, etc have a compile-tools target (for other reasons).
> I think it should explicitly depend on common.compile-tools instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org