You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/04 11:20:25 UTC

[GitHub] [arrow-datafusion] rdettai opened a new pull request #666: [fix] benchmark run with compose

rdettai opened a new pull request #666:
URL: https://github.com/apache/arrow-datafusion/pull/666


   # Which issue does this PR close?
   
   Closes #665.
   
    # Rationale for this change
   The the following command from the README:
   ```bash
   docker-compose run ballista-client cargo run benchmark ballista --host ballista-scheduler --port 50050 --query 1 --path /data --format tbl
   ```
   was failing because `--host` was taken as an option for `docker-compose` instead of `cargo run benchmark`. 
   
   Also binding to a folder outside the project folder:
   ```yaml
     volumes:
       - ./data:/data
       - ../..:/ballista
   ```
   is dangerous as you might end up overriding random files on the host filesystem.
   
   # What changes are included in this PR?
   Removed the binding to `../..` and documentation update.
   
   # Are there any user-facing changes?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan merged pull request #666: [fix] benchmark run with compose

Posted by GitBox <gi...@apache.org>.
Dandandan merged pull request #666:
URL: https://github.com/apache/arrow-datafusion/pull/666


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #666: [fix] benchmark run with compose

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #666:
URL: https://github.com/apache/arrow-datafusion/pull/666#issuecomment-874947107


   Thanks @rdettai !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org