You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2014/10/18 13:28:59 UTC
svn commit: r1632762 - in /maven/sandbox/trunk/dist-tools/dist-tool-plugin:
pom.xml src/main/java/org/apache/maven/dist/tools/AbstractDistCheckMojo.java
src/main/java/org/apache/maven/dist/tools/DummyFailureMojo.java
Author: hboutemy
Date: Sat Oct 18 11:28:59 2014
New Revision: 1632762
URL: http://svn.apache.org/r1632762
Log:
upgraded maven-reporting-impl to latest
Modified:
maven/sandbox/trunk/dist-tools/dist-tool-plugin/pom.xml
maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/AbstractDistCheckMojo.java
maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DummyFailureMojo.java
Modified: maven/sandbox/trunk/dist-tools/dist-tool-plugin/pom.xml
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/dist-tools/dist-tool-plugin/pom.xml?rev=1632762&r1=1632761&r2=1632762&view=diff
==============================================================================
--- maven/sandbox/trunk/dist-tools/dist-tool-plugin/pom.xml (original)
+++ maven/sandbox/trunk/dist-tools/dist-tool-plugin/pom.xml Sat Oct 18 11:28:59 2014
@@ -77,21 +77,7 @@
<dependency>
<groupId>org.apache.maven.reporting</groupId>
<artifactId>maven-reporting-impl</artifactId>
- <version>2.2</version>
- <exclusions>
- <exclusion>
- <artifactId>maven-artifact</artifactId>
- <groupId>org.apache.maven</groupId>
- </exclusion>
- <exclusion>
- <artifactId>maven-model</artifactId>
- <groupId>org.apache.maven</groupId>
- </exclusion>
- <exclusion>
- <artifactId>xml-apis</artifactId>
- <groupId>xml-apis</groupId>
- </exclusion>
- </exclusions>
+ <version>2.3</version>
</dependency>
<dependency>
<groupId>org.eclipse.aether</groupId>
Modified: maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/AbstractDistCheckMojo.java
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/AbstractDistCheckMojo.java?rev=1632762&r1=1632761&r2=1632762&view=diff
==============================================================================
--- maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/AbstractDistCheckMojo.java (original)
+++ maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/AbstractDistCheckMojo.java Sat Oct 18 11:28:59 2014
@@ -45,11 +45,8 @@ import org.apache.maven.artifact.version
import org.apache.maven.artifact.versioning.DefaultArtifactVersion;
import org.apache.maven.artifact.versioning.InvalidVersionSpecificationException;
import org.apache.maven.doxia.sink.Sink;
-import org.apache.maven.doxia.siterenderer.Renderer;
import org.apache.maven.plugin.MojoExecutionException;
-import org.apache.maven.plugins.annotations.Component;
import org.apache.maven.plugins.annotations.Parameter;
-import org.apache.maven.project.MavenProject;
import org.apache.maven.reporting.AbstractMavenReport;
import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
@@ -76,24 +73,6 @@ public abstract class AbstractDistCheckM
@Parameter( property = "configurationLines", defaultValue = "" )
private List<String> configurationLines;
- /**
- * Site renderer.
- */
- @Component
- protected Renderer siteRenderer;
-
- /**
- * Reporting directory.
- */
- @Parameter( defaultValue = "${project.reporting.outputDirectory}", required = true )
- protected File outputDirectory;
-
- /**
- * Maven project.
- */
- @Parameter( defaultValue = "${project}", readonly = true, required = true )
- protected MavenProject project;
-
@Parameter( defaultValue = "${project.build.directory}/dist-tool" )
protected File failuresDirectory;
@@ -137,24 +116,6 @@ public abstract class AbstractDistCheckM
return "dist-tool-" + getFailuresFilename().replace( ".old", "" );
}
- @Override
- protected String getOutputDirectory()
- {
- return outputDirectory.getAbsolutePath();
- }
-
- @Override
- protected Renderer getSiteRenderer()
- {
- return siteRenderer;
- }
-
- @Override
- protected MavenProject getProject()
- {
- return project;
- }
-
private void loadConfiguration()
throws MojoExecutionException
{
Modified: maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DummyFailureMojo.java
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DummyFailureMojo.java?rev=1632762&r1=1632761&r2=1632762&view=diff
==============================================================================
--- maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DummyFailureMojo.java (original)
+++ maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DummyFailureMojo.java Sat Oct 18 11:28:59 2014
@@ -23,12 +23,8 @@ import java.io.File;
import java.io.IOException;
import java.util.Locale;
-import org.apache.maven.doxia.siterenderer.Renderer;
import org.apache.maven.plugin.MojoExecutionException;
-import org.apache.maven.plugins.annotations.Component;
import org.apache.maven.plugins.annotations.Mojo;
-import org.apache.maven.plugins.annotations.Parameter;
-import org.apache.maven.project.MavenProject;
import org.apache.maven.reporting.MavenReportException;
import org.codehaus.plexus.util.FileUtils;
@@ -45,50 +41,14 @@ public class DummyFailureMojo
private static final String EOL = System.getProperty( "line.separator" );
- /**
- * Site renderer.
- */
- @Component
- protected Renderer siteRenderer;
-
- /**
- * Reporting directory.
- */
- @Parameter( defaultValue = "${project.reporting.outputDirectory}", required = true )
- protected File outputDirectory;
-
- /**
- * Maven project.
- */
- @Parameter( defaultValue = "${project}", readonly = true, required = true )
- protected MavenProject project;
-
@Override
boolean isIndexPageCheck()
{
return false;
}
- @Override
- public void execute()
- throws MojoExecutionException
- {
- boolean failure = false;
- // if failures log file is present, throw exception to fail build
- for ( String failuresFilename : FAILURES_FILENAMES )
- {
- failure |= checkFailure( failuresFilename );
- }
-
- if ( failure )
- {
- throw new MojoExecutionException( "Dist tools check reports found inconsistencies in some released "
- + "artifacts, see https://builds.apache.org/job/dist-tool-plugin/site/ for more information" );
- }
- }
-
private boolean checkFailure( String failuresFilename )
- throws MojoExecutionException
+ throws MavenReportException
{
File failureFile = new File( failuresDirectory, failuresFilename );
@@ -103,7 +63,7 @@ public class DummyFailureMojo
}
catch ( IOException ioe )
{
- throw new MojoExecutionException( "Cannot read " + failureFile, ioe );
+ throw new MavenReportException( "Cannot read " + failureFile, ioe );
}
}
@@ -111,17 +71,17 @@ public class DummyFailureMojo
protected void executeReport( Locale locale )
throws MavenReportException
{
- if ( !outputDirectory.exists() )
- {
- outputDirectory.mkdirs();
- }
- try
+ boolean failure = false;
+ // if failures log file is present, throw exception to fail build
+ for ( String failuresFilename : FAILURES_FILENAMES )
{
- this.execute();
+ failure |= checkFailure( failuresFilename );
}
- catch ( MojoExecutionException ex )
+
+ if ( failure )
{
- throw new MavenReportException( ex.getMessage() );
+ throw new MavenReportException( "Dist tools check reports found inconsistencies in some released "
+ + "artifacts, see https://builds.apache.org/job/dist-tool-plugin/site/ for more information" );
}
}