You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Yoshikazu Nojima <ma...@ynojima.net> on 2014/02/12 21:41:29 UTC
Review Request 18027: CLOUDSTACK-6072 vxlan networks not deallocating vnet
ids
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18027/
-----------------------------------------------------------
Review request for cloudstack and Marcus Sorensen.
Bugs: CLOUDSTACK-6072
https://issues.apache.org/jira/browse/CLOUDSTACK-6072
Repository: cloudstack-git
Description
-------
fixed issue: vxlan networks not deallocating vnet ids
Diffs
-----
server/src/com/cloud/network/guru/GuestNetworkGuru.java 85728c2
Diff: https://reviews.apache.org/r/18027/diff/
Testing
-------
1. deploy a physical network with VNI range "5000-5005"
2. create 6 guest networks
3. deploy a VM that joins 6 guest networks.
4. destroy the VM
5. destroy 4 guest networks.
6. create an additional guest network.
7. deploy a VM that joins 3 existing guest networks.
8. check VNI is reused.
Thanks,
Yoshikazu Nojima
Re: Review Request 18027: CLOUDSTACK-6072 vxlan networks not deallocating
vnet ids
Posted by Yoshikazu Nojima <ma...@ynojima.net>.
> On Feb. 14, 2014, 3:42 p.m., Marcus Sorensen wrote:
> > Ship It!
Hi, Could you merge this patch to master (and 4.3, if possible)?
- Yoshikazu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18027/#review34495
-----------------------------------------------------------
On Feb. 12, 2014, 8:44 p.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18027/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 8:44 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Bugs: CLOUDSTACK-6072
> https://issues.apache.org/jira/browse/CLOUDSTACK-6072
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> fixed issue: vxlan networks not deallocating vnet ids
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 85728c2
>
> Diff: https://reviews.apache.org/r/18027/diff/
>
>
> Testing
> -------
>
> 1. deploy a physical network with VNI range "5000-5005"
> 2. create 6 guest networks
> 3. deploy a VM that joins 3 guest networks.
> 4. deploy a VM that joins other 3 guest networks.
> 5. destroy the VMs
> 6. destroy 4 guest networks.
> 7. create an additional guest network.
> 8. deploy a VM that joins 3 existing guest networks.
> 9. check VNI is reused.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 18027: CLOUDSTACK-6072 vxlan networks not deallocating
vnet ids
Posted by Marcus Sorensen <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18027/#review34495
-----------------------------------------------------------
Ship it!
Ship It!
- Marcus Sorensen
On Feb. 12, 2014, 8:44 p.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18027/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 8:44 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Bugs: CLOUDSTACK-6072
> https://issues.apache.org/jira/browse/CLOUDSTACK-6072
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> fixed issue: vxlan networks not deallocating vnet ids
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 85728c2
>
> Diff: https://reviews.apache.org/r/18027/diff/
>
>
> Testing
> -------
>
> 1. deploy a physical network with VNI range "5000-5005"
> 2. create 6 guest networks
> 3. deploy a VM that joins 3 guest networks.
> 4. deploy a VM that joins other 3 guest networks.
> 5. destroy the VMs
> 6. destroy 4 guest networks.
> 7. create an additional guest network.
> 8. deploy a VM that joins 3 existing guest networks.
> 9. check VNI is reused.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 18027: CLOUDSTACK-6072 vxlan networks not deallocating
vnet ids
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18027/#review35135
-----------------------------------------------------------
Commit f1f79586da64cf3ad79ea7698927f10920b0d18d in cloudstack's branch refs/heads/master from Marcus Sorensen
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f1f7958 ]
CLOUDSTACK-6072: Release VNIs when guest networks are destroyed
submitted-by: mail@ynojima.net
- ASF Subversion and Git Services
On Feb. 12, 2014, 8:44 p.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18027/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 8:44 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Bugs: CLOUDSTACK-6072
> https://issues.apache.org/jira/browse/CLOUDSTACK-6072
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> fixed issue: vxlan networks not deallocating vnet ids
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 85728c2
>
> Diff: https://reviews.apache.org/r/18027/diff/
>
>
> Testing
> -------
>
> 1. deploy a physical network with VNI range "5000-5005"
> 2. create 6 guest networks
> 3. deploy a VM that joins 3 guest networks.
> 4. deploy a VM that joins other 3 guest networks.
> 5. destroy the VMs
> 6. destroy 4 guest networks.
> 7. create an additional guest network.
> 8. deploy a VM that joins 3 existing guest networks.
> 9. check VNI is reused.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 18027: CLOUDSTACK-6072 vxlan networks not deallocating
vnet ids
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18027/#review35136
-----------------------------------------------------------
Commit c04fb68fc7022c9d3ef6206d314194c3ce2a1872 in cloudstack's branch refs/heads/4.3-forward from Marcus Sorensen
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c04fb68 ]
CLOUDSTACK-6072: Release VNIs when guest networks are destroyed
submitted-by: mail@ynojima.net
- ASF Subversion and Git Services
On Feb. 12, 2014, 8:44 p.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18027/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 8:44 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Bugs: CLOUDSTACK-6072
> https://issues.apache.org/jira/browse/CLOUDSTACK-6072
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> fixed issue: vxlan networks not deallocating vnet ids
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 85728c2
>
> Diff: https://reviews.apache.org/r/18027/diff/
>
>
> Testing
> -------
>
> 1. deploy a physical network with VNI range "5000-5005"
> 2. create 6 guest networks
> 3. deploy a VM that joins 3 guest networks.
> 4. deploy a VM that joins other 3 guest networks.
> 5. destroy the VMs
> 6. destroy 4 guest networks.
> 7. create an additional guest network.
> 8. deploy a VM that joins 3 existing guest networks.
> 9. check VNI is reused.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 18027: CLOUDSTACK-6072 vxlan networks not deallocating
vnet ids
Posted by Yoshikazu Nojima <ma...@ynojima.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18027/
-----------------------------------------------------------
(Updated Feb. 12, 2014, 8:44 p.m.)
Review request for cloudstack and Marcus Sorensen.
Bugs: CLOUDSTACK-6072
https://issues.apache.org/jira/browse/CLOUDSTACK-6072
Repository: cloudstack-git
Description
-------
fixed issue: vxlan networks not deallocating vnet ids
Diffs
-----
server/src/com/cloud/network/guru/GuestNetworkGuru.java 85728c2
Diff: https://reviews.apache.org/r/18027/diff/
Testing (updated)
-------
1. deploy a physical network with VNI range "5000-5005"
2. create 6 guest networks
3. deploy a VM that joins 3 guest networks.
4. deploy a VM that joins other 3 guest networks.
5. destroy the VMs
6. destroy 4 guest networks.
7. create an additional guest network.
8. deploy a VM that joins 3 existing guest networks.
9. check VNI is reused.
Thanks,
Yoshikazu Nojima