You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "annerajb (via GitHub)" <gi...@apache.org> on 2023/08/11 13:13:51 UTC
[GitHub] [nuttx] annerajb opened a new pull request, #10193: Draft: Pinephone Pro Port
annerajb opened a new pull request, #10193:
URL: https://github.com/apache/nuttx/pull/10193
Pinephone pro (for now using a64 to make a small diff) will split to separate board once working
Status:
booting till GICD / IRQ issue
## Summary
This is a draft to gather early feedback and share the status of the pinephone pro rk3399
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on pull request #10193: Pinephone Pro port just nsh
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1689984626
@annerajb Very sorry about this, other PRs are also failing with the same issue: https://github.com/apache/nuttx/pulls
We might need to wait for this to be fixed, then rebase with master and rebuild 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on pull request #10193: Pinephone Pro port just nsh
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1690362510
or @hartmannathan
(or any other mantainer :P )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] hartmannathan commented on pull request #10193: Pinephone Pro port just nsh
Posted by "hartmannathan (via GitHub)" <gi...@apache.org>.
hartmannathan commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1690398981
> or @hartmannathan
>
> (or any other mantainer :P )
Someone got there faster than me :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on pull request #10193: Pinephone Pro port just nsh
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1686737369
> > Removing draft so I can get the CI to start running the check. Open to any feedback on whatever I pushed :D will write up a longer description with logs and what not tonight
>
> please squash your change into one patch.
Done lmk what CI reports I also took care (or tried) as many style checks as I saw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #10193: Pinephone Pro port just nsh
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1688301250
> @lupyuen fixed the default config removed, reset + ccache requirement and added includes
>
> @hartmannathan can you re approve pipeline since after the new squashed push is waiting again for mantainer approval.
I just approved it. Once again: nice work @annerajb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on a diff in pull request #10193: Draft: Pinephone Pro Port
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on code in PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#discussion_r1292180530
##########
arch/arm64/include/a64/chip.h:
##########
@@ -39,21 +39,24 @@
/* Allwinner A64 Generic Interrupt Controller v2: Distributor and Redist */
-#define CONFIG_GICD_BASE 0x1C81000
-#define CONFIG_GICR_BASE 0x1C82000
+#define CONFIG_GICD_BASE 0x8000000
+#define CONFIG_GICR_BASE 0x80a0000
+#define CONFIG_GICR_OFFSET 0x20000
Review Comment:
According to the [Linux Device Tree for RK3399](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L549-L553):
- GICD = 0xfee00000
- GICR = 0xfef00000
But I'm not sure what's [CONFIG_GICR_OFFSET](https://github.com/apache/nuttx/blob/master/arch/arm64/src/common/arm64_gicv3.c#L786-L793). (Offset to the GIC Registers for each CPU?)
Maybe we stick with the current value and test whether [UART Interrupts](https://lupyuen.github.io/articles/serial#uart-with-interrupts) are OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on a diff in pull request #10193: Draft: Pinephone Pro Port
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on code in PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#discussion_r1292180530
##########
arch/arm64/include/a64/chip.h:
##########
@@ -39,21 +39,24 @@
/* Allwinner A64 Generic Interrupt Controller v2: Distributor and Redist */
-#define CONFIG_GICD_BASE 0x1C81000
-#define CONFIG_GICR_BASE 0x1C82000
+#define CONFIG_GICD_BASE 0x8000000
+#define CONFIG_GICR_BASE 0x80a0000
+#define CONFIG_GICR_OFFSET 0x20000
Review Comment:
According to the [Linux Device Tree for RK3399](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L549-L553):
- GICD = 0xfee00000
- GICR = 0xfef00000
But I'm not sure what's CONFIG_GICR_OFFSET. Maybe we stick with the current value and test whether [UART Interrupts](https://lupyuen.github.io/articles/serial#uart-with-interrupts) are OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on a diff in pull request #10193: Draft: Pinephone Pro Port
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on code in PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#discussion_r1292180530
##########
arch/arm64/include/a64/chip.h:
##########
@@ -39,21 +39,24 @@
/* Allwinner A64 Generic Interrupt Controller v2: Distributor and Redist */
-#define CONFIG_GICD_BASE 0x1C81000
-#define CONFIG_GICR_BASE 0x1C82000
+#define CONFIG_GICD_BASE 0x8000000
+#define CONFIG_GICR_BASE 0x80a0000
+#define CONFIG_GICR_OFFSET 0x20000
Review Comment:
According to the [Linux Device Tree for RK3399](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L549-L553):
- GICD = 0xfee00000
- GICR = 0xfef00000
But I'm not sure what's [CONFIG_GICR_OFFSET](https://github.com/apache/nuttx/blob/master/arch/arm64/src/common/arm64_gicv3.c#L786-L793). (Offset to the GIC Registers for each CPU?)
Maybe we stick with the current value and test whether [UART Interrupts](https://lupyuen.github.io/articles/serial#uart-with-interrupts) are OK?
RK3399 UART0 is at [GIC Shared Peripheral Interrupt 99](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L695-L706)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on pull request #10193: arch/arm64: Add support for PINE64 PinePhone Pro
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1690890206
Looks great to me, approved. Thank you so much for contributing the PinePhone Pro port! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on pull request #10193: Pinephone Pro port just nsh
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1689978775
> Hmmm seems to be a problem with the common queue.h, not due to our PR...
>
> ```
> libuv/src/uv-common.c: In function 'uv_walk':
> Error: libuv/src/queue.h:68:19: error: storing the address of local variable 'queue' in '((void * (**)[2])MEM[(void *[2] * *)loop_13(D) + 8B])[1]' [-Werror=dangling-pointer=]
> 68 | QUEUE_PREV(q) = (n); \
> | ^
> libuv/src/queue.h:78:7: note: in expansion of macro 'QUEUE_SPLIT'
> 78 | QUEUE_SPLIT(h, q, n); \
> | ^~~~~~~~~~~
> libuv/src/uv-common.c:492:3: note: in expansion of macro 'QUEUE_MOVE'
> 492 | QUEUE_MOVE(&loop->handle_queue, &queue);
> | ^~~~~~~~~~
> ```
Yup master never built and failed the same way 10 hours ago
https://github.com/apache/nuttx/commit/81118db95d531b17d2f0188a2b37c71f424879a4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on pull request #10193: arch/arm64: Add support for PINE64 PinePhone Pro
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1692575171
> @annerajb Thanks again for porting NuttX to PinePhone Pro, your contribution is super valuable for learning the Internals of a Modern Smartphone! I have some suggestions for the next steps:
>
> 1. PinePhone's **UART Driver** has an issue with the [numbering of unused Serial Ports /dev/ttySn](https://github.com/apache/nuttx/pull/9304#issuecomment-1552218687), I think it affects PinePhone Pro too. One way to fix this: Switch to the [NuttX 16550 UART Driver](https://lupyuen.github.io/articles/plic)
> 2. Would be good to rename [**pinephone_bringup**](https://github.com/apache/nuttx/blob/master/boards/arm64/rk3399/pinephonepro/src/pinephonepro_bringup.c#L47) to `pinephonepro_bringup`, in case of name conflicts.
> 3. If we're building Mainline NuttX Daily for PinePhone Pro, check out this [**GitHub Actions Workflow**](https://github.com/lupyuen/pinephone-nuttx/blob/main/.github/workflows/pinephone.yml). (I haven't figured out how to do daily Automated Testing)
> 4. I understand that we're working on the **I2C Driver**. Which is great, because we can then use the [NuttX Touch Panel Driver for GT917S](https://lupyuen.github.io/articles/touch2)
> 5. For the **Display Driver**, maybe take a look at the VOP Driver for Tow Boot. See if we can reimplement a simpler driver for NuttX.
> 6. Use our new [**MIPI DSI Driver**](https://github.com/apache/nuttx/tree/master/drivers/video/mipidsi)
> 7. There's plenty to be done, maybe we can get the Community involved? Lemme know if I should broadcast this on the Pine64 Forum.
>
> As always, lemme know if you need any help :-)
Thanks,
Feel free to broadcast on the forum my roadmap is i2c, touch (mostly to confirm i2c is all good)
At that point which suspect will be a week reassess what is the most value-added next step based on if anybody else has contributed anything.
I have a new PR planned for the board reset support will rename the bring up file on that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on a diff in pull request #10193: Draft: Pinephone Pro Port
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on code in PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#discussion_r1292180530
##########
arch/arm64/include/a64/chip.h:
##########
@@ -39,21 +39,24 @@
/* Allwinner A64 Generic Interrupt Controller v2: Distributor and Redist */
-#define CONFIG_GICD_BASE 0x1C81000
-#define CONFIG_GICR_BASE 0x1C82000
+#define CONFIG_GICD_BASE 0x8000000
+#define CONFIG_GICR_BASE 0x80a0000
+#define CONFIG_GICR_OFFSET 0x20000
Review Comment:
According to the [Linux Device Tree for RK3399](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L549-L553):
- GICD = 0xfee00000
- GICR = 0xfef00000
But I'm not sure what's [CONFIG_GICR_OFFSET](https://github.com/apache/nuttx/blob/master/arch/arm64/src/common/arm64_gicv3.c#L786-L793). (Offset to the GIC Registers for each CPU?)
Maybe we stick with the current value and test whether [UART Interrupts](https://lupyuen.github.io/articles/serial#uart-with-interrupts) are OK?
[(See the Linux doc for GIC)](https://www.kernel.org/doc/Documentation/devicetree/bindings/interrupt-controller/arm%2Cgic-v3.txt)
RK3399 UART0 is at [GIC Shared Peripheral Interrupt 99](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L695-L706)
RK3399 UART is a [DesignWare APB UART (dw-apb-uart)](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L696), which maps to the [Linux DesignWare 8250 Driver (8250_dw.c)](https://github.com/torvalds/linux/blob/master/drivers/tty/serial/8250/8250_dw.c#L804).
Which is compatible with the [NuttX 16550 UART Driver](https://lupyuen.github.io/articles/plic#appendix-fix-the-spurious-uart-interrupts). So remember to enable 16550_WAIT_LCR, and set 16550_REGINCR=4. [(Because regshift=2)](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L701)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #10193: Pinephone Pro port just nsh
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1689520145
Fixed here: https://github.com/apache/nuttx/pull/10348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Throwaway8 commented on pull request #10193: arch/arm64: Add support for PINE64 PinePhone Pro
Posted by "Throwaway8 (via GitHub)" <gi...@apache.org>.
Throwaway8 commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1712844065
@annerajb whats the correct way to build, you flash onto a micro sd card with tow boot installed and it should boot? Is there any way to format the memory card because just using the basic build commands it doesn't have detect a partition table on the memory card
git clone https://github.com/apache/nuttx-apps apps
cd nuttx/
./tools/configure.sh pinephonepro/nsh
make
cp nuttx.bin Image
gzip Image
and the .gz image is what I flash with balena etcher to sd card, seems to be latest
Tow-Boot TPL 2022.07
Channel 0: LPDDR4, 50MHz
BW=32 Col=10 Bk=8 CS0 Row=15 CS1 Row=15 CS=2 Die BW=16 Size=2048MB
Channel 1: LPDDR4, 50MHz
BW=32 Col=10 Bk=8 CS0 Row=15 CS1 Row=15 CS=2 Die BW=16 Size=2048MB
256B stride
lpddr4_set_rate: change freq to 400000000 mhz 0, 1
lpddr4_set_rate: change freq to 800000000 mhz 1, 0
Trying to boot from BOOTROM
Returning to boot ROM...
Tow-Boot SPL 2022.07
Trying to boot from SPI
NOTICE: BL31: v2.6(release):
NOTICE: BL31: Built : 00:00:00, Jan 1 1980
Tow-Boot 2022.07 006 [variant: spi]
SoC: Rockchip rk3399
Reset cause: POR
Model: Pine64 PinePhonePro
DRAM: 3.9 GiB
Initializing Pinephone Pro charger
PMIC: RK8180 (on=0x40, off=0x08)
Core: 324 devices, 34 uclasses, devicetree: separate
MMC: mmc@fe310000: 3, mmc@fe320000: 1, mmc@fe330000: 0
Loading Environment from SPIFlash... SF: Detected gd25lq128e with page size 256 Bytes, erase size 4 KiB, total 16 MiB
*** Warning - bad CRC, using default environment
In: serial
Out: serial
Err: serial
Model: Pine64 PinePhonePro
Net: No ethernet found.
starting USB...
Bus usb@fe380000: ehci_generic usb@fe380000: Failed to get clocks (ret=-19)
Port not available.
Bus usb@fe3a0000: USB OHCI 1.0
Bus usb@fe3c0000: ehci_generic usb@fe3c0000: Failed to get clocks (ret=-19)
Port not available.
Bus usb@fe3e0000: USB OHCI 1.0
scanning bus usb@fe3a0000 for devices... 1 USB Device(s) found
scanning bus usb@fe3e0000 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Please press [ESCAPE] or [CTRL+C] to enter the boot menu.
off
off
switch to partitions #0, OK
mmc0(part 0) is current device
** Invalid partition 1 **
Couldn't find partition mmc 0:1
switch to partitions #0, OK
mmc1 is current device
** No partition table - mmc 1 **
Couldn't find partition mmc 1:1
Device 0: unknown device
No ethernet found.
missing environment variable: pxeuuid
Retrieving file: pxelinux.cfg/00000000
No ethernet found.
Retrieving file: pxelinux.cfg/0000000
No ethernet found.
Retrieving file: pxelinux.cfg/000000
No ethernet found.
Retrieving file: pxelinux.cfg/00000
No ethernet found.
Retrieving file: pxelinux.cfg/0000
No ethernet found.
Retrieving file: pxelinux.cfg/000
No ethernet found.
Retrieving file: pxelinux.cfg/00
No ethernet found.
Retrieving file: pxelinux.cfg/0
No ethernet found.
Retrieving file: pxelinux.cfg/default-arm-rk3399-pinephone-pro-rk3399
No ethernet found.
Retrieving file: pxelinux.cfg/default-arm-rk3399
No ethernet found.
Retrieving file: pxelinux.cfg/default-arm
No ethernet found.
Retrieving file: pxelinux.cfg/default
No ethernet found.
Config file not found
No ethernet found.
No ethernet found.
SF: Detected gd25lq128e with page size 256 Bytes, erase size 4 KiB, total 16 MiB
device 0 offset 0xffe000, size 0x2000
SF: 8192 bytes @ 0xffe000 Read: OK
## Executing script at 00500000
Wrong image format for "source" command
SCRIPT FAILED: continuing...
ERROR: Could not boot anything from distro_bootcmd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on a diff in pull request #10193: Draft: Pinephone Pro Port
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on code in PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#discussion_r1300105228
##########
arch/arm64/src/common/arm64_head.S:
##########
@@ -106,7 +106,7 @@ __start:
add x13, x18, #0x16 /* the magic "MZ" signature */
b real_start /* branch to kernel start */
- .quad 0x480000 /* Image load offset from start of RAM */
+ .quad 0x02080000 /* Image load offset from start of RAM */
Review Comment:
@lupyuen
Does this seem correct?
This is on the common folder which makes me doubt it's correct or i would want to hardcode it here instead of somehow making it a architecture specific argument with a common default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on a diff in pull request #10193: Draft: Pinephone Pro Port
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on code in PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#discussion_r1300185511
##########
arch/arm64/src/common/arm64_head.S:
##########
@@ -106,7 +106,7 @@ __start:
add x13, x18, #0x16 /* the magic "MZ" signature */
b real_start /* branch to kernel start */
- .quad 0x480000 /* Image load offset from start of RAM */
+ .quad 0x02080000 /* Image load offset from start of RAM */
Review Comment:
yup booted fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on pull request #10193: Pinephone Pro port just nsh
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1689561400
@annerajb Could you rebase with master to start the rebuild? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #10193: arch/arm64: Add support for PINE64 PinePhone Pro
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10193:
URL: https://github.com/apache/nuttx/pull/10193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on a diff in pull request #10193: Draft: Pinephone Pro Port
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on code in PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#discussion_r1292180530
##########
arch/arm64/include/a64/chip.h:
##########
@@ -39,21 +39,24 @@
/* Allwinner A64 Generic Interrupt Controller v2: Distributor and Redist */
-#define CONFIG_GICD_BASE 0x1C81000
-#define CONFIG_GICR_BASE 0x1C82000
+#define CONFIG_GICD_BASE 0x8000000
+#define CONFIG_GICR_BASE 0x80a0000
+#define CONFIG_GICR_OFFSET 0x20000
Review Comment:
According to the [Linux Device Tree for RK3399](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L549-L553):
- GICD = 0xfee00000
- GICR = 0xfef00000
But I'm not sure what's CONFIG_GICR_OFFSET. Maybe we stick with the current value and test whether UART Interrupts are OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on a diff in pull request #10193: Draft: Pinephone Pro Port
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on code in PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#discussion_r1300112529
##########
arch/arm64/src/common/arm64_head.S:
##########
@@ -106,7 +106,7 @@ __start:
add x13, x18, #0x16 /* the magic "MZ" signature */
b real_start /* branch to kernel start */
- .quad 0x480000 /* Image load offset from start of RAM */
+ .quad 0x02080000 /* Image load offset from start of RAM */
Review Comment:
@annerajb Image Load Offset isn't used, as I have discovered here: https://lupyuen.github.io/articles/uboot#porting-notes
Let's stick with the default value, see if it boots OK :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #10193: Pinephone Pro port just nsh
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1686615506
> Removing draft so I can get the CI to start running the check. Open to any feedback on whatever I pushed :D will write up a longer description with logs and what not tonight
please squash your change into one patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on pull request #10193: arch/arm64: Add support for PINE64 PinePhone Pro
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1692553921
@annerajb Thanks again for porting NuttX to PinePhone Pro, your contribution is super valuable for learning the Internals of a Modern Smartphone! I have some suggestions for the next steps:
1. PinePhone's __UART Driver__ has an issue with the [numbering of unused Serial Ports /dev/ttySn](https://github.com/apache/nuttx/pull/9304#issuecomment-1552218687), I think it affects PinePhone Pro too. One way to fix this: Switch to the [NuttX 16550 UART Driver](https://lupyuen.github.io/articles/plic)
1. Would be good to rename [__pinephone_bringup__](https://github.com/apache/nuttx/blob/master/boards/arm64/rk3399/pinephonepro/src/pinephonepro_bringup.c#L47) to `pinephonepro_bringup`, in case of name conflicts.
1. If we're building Mainline NuttX Daily for PinePhone Pro, check out this [__GitHub Actions Workflow__](https://github.com/lupyuen/pinephone-nuttx/blob/main/.github/workflows/pinephone.yml). (I haven't figured out how to do daily Automated Testing)
1. I understand that we're working on the __I2C Driver__. Which is great, because we can then use the [NuttX Touch Panel Driver for GT917S](https://lupyuen.github.io/articles/touch2)
1. For the __Display Driver__, maybe take a look at the VOP Driver for Tow Boot. See if we can reimplement a simpler driver for NuttX.
1. Use our new [__MIPI DSI Driver__](https://github.com/apache/nuttx/tree/master/drivers/video/mipidsi)
1. There's plenty to be done, maybe we can get the Community involved? Lemme know if I should broadcast this on the Pine64 Forum.
As always, lemme know if you need any help :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Throwaway8 commented on pull request #10193: arch/arm64: Add support for PINE64 PinePhone Pro
Posted by "Throwaway8 (via GitHub)" <gi...@apache.org>.
Throwaway8 commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1712994173
> https://github.com/webOS-ports/meta-pine64-luneos/releases/tag/20211220-v1
>
> then I deleted the `boot.scr` and created a `extlinux` folder where I copied the following extlinux.conf
>
> ```
> ## /boot/extlinux/extlinux.conf
> ##
> ## IMPORTANT WARNING
> ##
> ## The configuration of this file is generated automatically.
> ## Do not edit this file manually, use: u-boot-update
>
> default l0
> menu title U-Boot menu
> prompt 1
> timeout 1
>
>
> label l0
> menu label Mobian GNU/Linux 6.1-rockchip
> kernel /Image.gz
> fdt /rk3399-pinephone-pro.dtb
> ```
>
> copied the `Image.gz` to the root of the sdcard after using balena I also added the device tree `rk3399-pinephonepro.dtb` from another image (I can't remember which one) not even sure if it matters since uboot has it's own dtsi and nuttx is not using it.. but the uboot extlinux.conf wanted to have a `fdt` line
>
> [rk3399-pinephone-pro.zip](https://github.com/apache/nuttx/files/12570947/rk3399-pinephone-pro.zip)
Great thank you for sharing I will through this and give it a try soon.. makes sense I wasn't sure if you were using the only the image.gz file directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on pull request #10193: Pinephone Pro port just nsh
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1687188451
@annerajb Maybe you could Rebase with Master, to force the rebuild: https://lupyuen.github.io/articles/pr#submit-the-pull-request
Normally when the build fails, I take a [peek at other recent PRs](https://github.com/apache/nuttx/pulls). If they didn't fail the build, then it's probably OK to Rebase with Master to force the Rebuild. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] hartmannathan commented on pull request #10193: Pinephone Pro port just nsh
Posted by "hartmannathan (via GitHub)" <gi...@apache.org>.
hartmannathan commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1688929421
> Hmm riscv failed and caused canncelation of all other targets <_<
>
>
>
> ```
>
> 2023-08-22T14:54:39.9558447Z /usr/bin/bash: line 1: riscv64-unknown-elf-gcc: command not found
>
> 2023-08-22T14:54:39.9598922Z expr: syntax error: unexpected argument '12'
>
> ```
Toolchain is not installed in this buildbot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on pull request #10193: Pinephone Pro port just nsh
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1688292064
@lupyuen
fixed the default config removed, reset + ccache requirement and added includes
@hartmannathan
can you re approve pipeline since after the new squashed push is waiting again for mantainer approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on pull request #10193: Pinephone Pro port just nsh
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1687349871
@annerajb Found the problem, the `boards/arm64/rk3399/pinephonepro/include` directory is missing. Could you follow the same convention as PinePhone and create the missing files `board.h` and `board_memorymap.h`?
Then try doing a fresh new build from scratch, hope that it works. Thanks!
https://github.com/apache/nuttx/tree/master/boards/arm64/a64/pinephone/include
```text
→ ls boards/arm64/a64/pinephone/include
board.h board_memorymap.h
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on pull request #10193: Pinephone Pro port just nsh
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1689848887
@lupyuen done need approval from maintainer to run checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on pull request #10193: Draft: Pinephone Pro Port
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1686444383
Removing draft so I can get the CI to start running the check.
Open to any feedback on whatever I pushed :D
will write up a longer description with logs and what not tonight
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on a diff in pull request #10193: Pinephone Pro port just nsh
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on code in PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#discussion_r1301617587
##########
arch/arm64/src/common/arm64_mmu.c:
##########
@@ -426,7 +426,7 @@ static void init_xlat_tables(const struct arm_mmu_region *region)
uint64_t level_size;
#ifdef CONFIG_MMU_DEBUG
- sinfo("mmap: virt %llx phys %llx size %llx\n", virt, phys, size);
+ sinfo("mmap: virt %lu phys %lu size %lu\n", virt, phys, size);
Review Comment:
good catch, i fixed the datatype but removed the `x` just added it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on pull request #10193: Pinephone Pro port just nsh
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1687343815
@annerajb Something seems incorrect in our PinePhone Pro Build Config, `tools/configure.sh pinephonepro/nsh` is failing. Lemme check why...
```text
→ git clone https://github.com/annerajb/nuttx
→ git clone https://github.com/apache/nuttx-apps apps
→ cd nuttx
→ tools/configure.sh pinephonepro/nsh
Copy files
Select CONFIG_HOST_MACOS=y
Refreshing...
CP: arch/dummy/Kconfig to /private/tmp/nuttx/nuttx/arch/dummy/dummy_kconfig
CP: boards/dummy/Kconfig to /private/tmp/nuttx/nuttx/boards/dummy/dummy_kconfig
LN: platform/board to /private/tmp/nuttx/apps/platform/dummy
LN: include/arch to arch/arm64/include
LN: include/arch/board to /private/tmp/nuttx/nuttx/boards/arm64/rk3399/pinephonepro/include
No directory at /private/tmp/nuttx/nuttx/boards/arm64/rk3399/pinephonepro/include
make[1]: *** [tools/Unix.mk:285: include/arch/board] Error 1
make: *** [tools/Unix.mk:679: olddefconfig] Error 2
ERROR: failed to refresh
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #10193: Pinephone Pro port just nsh
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1690220715
@annerajb please rebase your patch, the break should be fixed by https://github.com/apache/nuttx/pull/10370 and https://github.com/apache/nuttx-apps/pull/1990.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on a diff in pull request #10193: Draft: Pinephone Pro Port
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on code in PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#discussion_r1292180530
##########
arch/arm64/include/a64/chip.h:
##########
@@ -39,21 +39,24 @@
/* Allwinner A64 Generic Interrupt Controller v2: Distributor and Redist */
-#define CONFIG_GICD_BASE 0x1C81000
-#define CONFIG_GICR_BASE 0x1C82000
+#define CONFIG_GICD_BASE 0x8000000
+#define CONFIG_GICR_BASE 0x80a0000
+#define CONFIG_GICR_OFFSET 0x20000
Review Comment:
According to the [Linux Device Tree for RK3399](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L549-L553):
- GICD = 0xfee00000
- GICR = 0xfef00000
But I'm not sure what's [CONFIG_GICR_OFFSET](https://github.com/apache/nuttx/blob/master/arch/arm64/src/common/arm64_gicv3.c#L786-L793). (Offset to the GIC Registers for each CPU?)
Maybe we stick with the current value and test whether [UART Interrupts](https://lupyuen.github.io/articles/serial#uart-with-interrupts) are OK?
RK3399 UART0 is at [GIC Shared Peripheral Interrupt 99](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L695-L706)
RK3399 UART is a [DesignWare APB UART (dw-apb-uart)](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L696), which maps to the [Linux DesignWare 8250 Driver (8250_dw.c)](https://github.com/torvalds/linux/blob/master/drivers/tty/serial/8250/8250_dw.c#L804).
Which is compatible with the [NuttX 16550 UART Driver](https://lupyuen.github.io/articles/plic#appendix-fix-the-spurious-uart-interrupts). So remember to enable 16550_WAIT_LCR, and set 16550_REGINCR=4. [(Because regshift=2)](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L701)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #10193: Draft: Pinephone Pro Port
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1674889800
Very nice @annerajb !!!
Please fix the check style issues reported by the CI.
You can run this command to confirm everything is fine before push the commit:
```
$ ./tools/checkpatch.sh -f arch/arm64/src/common/arm64_mmu.c
```
And since you will create a new commit, only to fix the issue, you need to squash them:
https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggestions-on-your-pull-request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on pull request #10193: Draft: Pinephone Pro Port
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1675654794
Hi @annerajb: Thank you so much for porting NuttX to PinePhone Pro! As Alan mentioned, we need to tidy up the code, here are some tips...
I wrote a guide on submitting a NuttX PR, it might be helpful:
- ["Preparing a Pull Request for Apache NuttX RTOS"](https://lupyuen.github.io/articles/pr)
To support PinePhone Pro we'll need to add a new NuttX Arch (SoC) and NuttX Board:
- NuttX Arch: arch/arm64/src/rk3399
- NuttX Board: boards/arm64/rk3399/pinephonepro
The steps are explained here:
- ["Add the NuttX Arch and Board"](https://lupyuen.github.io/articles/release#add-the-nuttx-arch-and-board)
But that's for RISC-V. For Arm64 we can follow this PR (but probably better to split into one PR for Arch and another PR for Board):
- ["arch/arm64: Add support for PINE64 PinePhone"](https://github.com/apache/nuttx/pull/7692)
We might be able to reuse the NuttX 16550 UART Driver:
- ["Star64 JH7110 + NuttX RTOS: RISC-V PLIC Interrupts and Serial I/O"](https://lupyuen.github.io/articles/plic)
Remember to enable [16550_WAIT_LCR](https://lupyuen.github.io/articles/plic#appendix-fix-the-spurious-uart-interrupts). And set [16550_REGINCR](https://lupyuen.github.io/articles/privilege#uart-registers-are-spaced-differently) to 4. (I think)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on a diff in pull request #10193: Draft: Pinephone Pro Port
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on code in PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#discussion_r1292180530
##########
arch/arm64/include/a64/chip.h:
##########
@@ -39,21 +39,24 @@
/* Allwinner A64 Generic Interrupt Controller v2: Distributor and Redist */
-#define CONFIG_GICD_BASE 0x1C81000
-#define CONFIG_GICR_BASE 0x1C82000
+#define CONFIG_GICD_BASE 0x8000000
+#define CONFIG_GICR_BASE 0x80a0000
+#define CONFIG_GICR_OFFSET 0x20000
Review Comment:
According to the [Linux Device Tree for RK3399](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L549-L553):
- GICD = 0xfee00000
- GICR = 0xfef00000
But I'm not sure what's [CONFIG_GICR_OFFSET](https://github.com/apache/nuttx/blob/master/arch/arm64/src/common/arm64_gicv3.c#L786-L793).
Maybe we stick with the current value and test whether [UART Interrupts](https://lupyuen.github.io/articles/serial#uart-with-interrupts) are OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on pull request #10193: Pinephone Pro port just nsh
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1688418447
Hmm riscv failed and caused canncelation of all other targets <_<
```
2023-08-22T14:54:39.9558447Z /usr/bin/bash: line 1: riscv64-unknown-elf-gcc: command not found
2023-08-22T14:54:39.9598922Z expr: syntax error: unexpected argument '12'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on pull request #10193: Pinephone Pro port just nsh
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1690227541
> @annerajb please rebase your patch, the break should be fixed by #10370 and [apache/nuttx-apps#1990](https://github.com/apache/nuttx-apps/pull/1990).
Done Can you approve the build / check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on pull request #10193: Pinephone Pro port just nsh
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1688178468
No it's my default config I enabled ccache to make it build faster and left it enabled on the default nsh config.
I am working on removing it from the default config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on pull request #10193: arch/arm64: Add support for PINE64 PinePhone Pro
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1690888627
> @annerajb Great job! We're ready to merge into NuttX Mainline, could we tidy up the PR Title and Impact? Maybe like this: #7692 Thanks!
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #10193: arch/arm64: Add support for PINE64 PinePhone Pro
Posted by "masayuki2009 (via GitHub)" <gi...@apache.org>.
masayuki2009 commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1691091837
@annerajb
Please remove unnecessary comments in the commit log next time.
```
commit 24e45d071e6c56611ba866620a47af59b1e604e7
Author: Anner J. Bonilla <ab...@soteradigital.com>
Date: Fri Aug 11 09:12:26 2023 -0400
Pinephone Pro port just nsh
Pinephone Pro port just nsh
Status:
booting till GICD / IRQ issue
style cleanups
start to fix style checks
revert offset
whitespaces
revert a64 bringup file
prob last cleanup
more cleanups
remove dts
move changes from a64 hardware specific folders to rk3399
undo common changes (except head.s)
revert gitignore
missing irq.h and rk3399_serial.c need to finish cleaning them up
WIP
add source for load address
make debug print hex again add board include
Pinephone Pro port just nsh
Status:
booting till GICD / IRQ issue
style cleanups
start to fix style checks
revert offset
whitespaces
revert a64 bringup file
prob last cleanup
more cleanups
remove dts
move changes from a64 hardware specific folders to rk3399
undo common changes (except head.s)
revert gitignore
missing irq.h and rk3399_serial.c need to finish cleaning them up
WIP
add source for load address
remove ccache, add board memory map
remove board reset
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on pull request #10193: Pinephone Pro port just nsh
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1690789996
@annerajb Great job! We're ready to merge into NuttX Mainline, could we tidy up the PR Title and Impact? Maybe like this: https://github.com/apache/nuttx/pull/7692 Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on a diff in pull request #10193: Pinephone Pro port just nsh
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on code in PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#discussion_r1300861696
##########
arch/arm64/src/common/arm64_mmu.c:
##########
@@ -426,7 +426,7 @@ static void init_xlat_tables(const struct arm_mmu_region *region)
uint64_t level_size;
#ifdef CONFIG_MMU_DEBUG
- sinfo("mmap: virt %llx phys %llx size %llx\n", virt, phys, size);
+ sinfo("mmap: virt %lu phys %lu size %lu\n", virt, phys, size);
Review Comment:
Why did we change this? I believe `virt` and `phys` are Memory Addresses, so it might be better to print them as hex?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on pull request #10193: Pinephone Pro port just nsh
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1689976766
Hmmm seems to be a problem with the common queue.h, not due to our PR...
```text
libuv/src/uv-common.c: In function 'uv_walk':
Error: libuv/src/queue.h:68:19: error: storing the address of local variable 'queue' in '((void * (**)[2])MEM[(void *[2] * *)loop_13(D) + 8B])[1]' [-Werror=dangling-pointer=]
68 | QUEUE_PREV(q) = (n); \
| ^
libuv/src/queue.h:78:7: note: in expansion of macro 'QUEUE_SPLIT'
78 | QUEUE_SPLIT(h, q, n); \
| ^~~~~~~~~~~
libuv/src/uv-common.c:492:3: note: in expansion of macro 'QUEUE_MOVE'
492 | QUEUE_MOVE(&loop->handle_queue, &queue);
| ^~~~~~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] hartmannathan commented on pull request #10193: Pinephone Pro port just nsh
Posted by "hartmannathan (via GitHub)" <gi...@apache.org>.
hartmannathan commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1688269005
> It says it's waiting on approval from a mantainer to start running the workflows / pipelines
I approved the workflows to run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lupyuen commented on pull request #10193: arch/arm64: Add support for PINE64 PinePhone Pro
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1692669040
Thanks @annerajb I have [announced the project on Pine64 Forum](https://forum.pine64.org/showthread.php?tid=18650). I hope NuttX on PinePhone Pro will become a Daily Driver. Or maybe we can teach it in schools! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on pull request #10193: Pinephone Pro port just nsh
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1687258992
> @annerajb Maybe you could Rebase with Master, to force the rebuild: https://lupyuen.github.io/articles/pr#submit-the-pull-request
>
> Normally when the build fails, I take a [peek at other recent PRs](https://github.com/apache/nuttx/pulls). If they didn't fail the build, then it's probably OK to Rebase with Master to force the Rebuild. Thanks!
It says it's waiting on approval from a mantainer to start running the workflows / pipelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] hartmannathan commented on pull request #10193: Pinephone Pro port just nsh
Posted by "hartmannathan (via GitHub)" <gi...@apache.org>.
hartmannathan commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1689911579
> @lupyuen done need approval from maintainer to run checks
@annerajb ok checks are running...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] mu578 commented on a diff in pull request #10193: arch/arm64: Add support for PINE64 PinePhone Pro
Posted by "mu578 (via GitHub)" <gi...@apache.org>.
mu578 commented on code in PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#discussion_r1320891705
##########
arch/arm64/src/common/arm64_head.S:
##########
@@ -106,7 +106,7 @@ __start:
add x13, x18, #0x16 /* the magic "MZ" signature */
b real_start /* branch to kernel start */
- .quad 0x480000 /* Image load offset from start of RAM */
+ .quad 0x02080000 /* Image load offset from start of RAM */
Review Comment:
yes, it is unused but would not hurt to push a comment about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on pull request #10193: arch/arm64: Add support for PINE64 PinePhone Pro
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1712951016
> @annerajb whats the correct way to build, you flash onto a micro sd card with tow boot installed and it should boot? Is there any way to format the memory card because just using the basic build commands it doesn't seem to be able to detect a partition table on the memory card
>
> git clone https://github.com/apache/nuttx.git
> cd nuttx/
> ./tools/configure.sh pinephonepro/nsh
> make
> cp nuttx.bin Image
> gzip Image
>
> and the .gz image is what I flash with balena etcher to sd card, seems to be latest
>
> Tow-Boot TPL 2022.07
> Channel 0: LPDDR4, 50MHz
> BW=32 Col=10 Bk=8 CS0 Row=15 CS1 Row=15 CS=2 Die BW=16 Size=2048MB
> Channel 1: LPDDR4, 50MHz
> BW=32 Col=10 Bk=8 CS0 Row=15 CS1 Row=15 CS=2 Die BW=16 Size=2048MB
> 256B stride
> lpddr4_set_rate: change freq to 400000000 mhz 0, 1
> lpddr4_set_rate: change freq to 800000000 mhz 1, 0
> Trying to boot from BOOTROM
> Returning to boot ROM...
>
> Tow-Boot SPL 2022.07
> Trying to boot from SPI
> NOTICE: BL31: v2.6(release):
> NOTICE: BL31: Built : 00:00:00, Jan 1 1980
>
>
> Tow-Boot 2022.07 006 [variant: spi]
>
> SoC: Rockchip rk3399
> Reset cause: POR
> Model: Pine64 PinePhonePro
> DRAM: 3.9 GiB
> Initializing Pinephone Pro charger
> PMIC: RK8180 (on=0x40, off=0x08)
> Core: 324 devices, 34 uclasses, devicetree: separate
> MMC: mmc@fe310000: 3, mmc@fe320000: 1, mmc@fe330000: 0
> Loading Environment from SPIFlash... SF: Detected gd25lq128e with page size 256 Bytes, erase size 4 KiB, total 16 MiB
> *** Warning - bad CRC, using default environment
>
> In: serial
> Out: serial
> Err: serial
> Model: Pine64 PinePhonePro
> Net: No ethernet found.
> starting USB...
> Bus usb@fe380000: ehci_generic usb@fe380000: Failed to get clocks (ret=-19)
> Port not available.
> Bus usb@fe3a0000: USB OHCI 1.0
> Bus usb@fe3c0000: ehci_generic usb@fe3c0000: Failed to get clocks (ret=-19)
> Port not available.
> Bus usb@fe3e0000: USB OHCI 1.0
> scanning bus usb@fe3a0000 for devices... 1 USB Device(s) found
> scanning bus usb@fe3e0000 for devices... 1 USB Device(s) found
> scanning usb for storage devices... 0 Storage Device(s) found
> Please press [ESCAPE] or [CTRL+C] to enter the boot menu.
> off
> off
> switch to partitions #0, OK
> mmc0(part 0) is current device
> ** Invalid partition 1 **
> Couldn't find partition mmc 0:1
> switch to partitions #0, OK
> mmc1 is current device
> ** No partition table - mmc 1 **
> Couldn't find partition mmc 1:1
>
> Device 0: unknown device
> No ethernet found.
> missing environment variable: pxeuuid
> Retrieving file: pxelinux.cfg/00000000
> No ethernet found.
> Retrieving file: pxelinux.cfg/0000000
> No ethernet found.
> Retrieving file: pxelinux.cfg/000000
> No ethernet found.
> Retrieving file: pxelinux.cfg/00000
> No ethernet found.
> Retrieving file: pxelinux.cfg/0000
> No ethernet found.
> Retrieving file: pxelinux.cfg/000
> No ethernet found.
> Retrieving file: pxelinux.cfg/00
> No ethernet found.
> Retrieving file: pxelinux.cfg/0
> No ethernet found.
> Retrieving file: pxelinux.cfg/default-arm-rk3399-pinephone-pro-rk3399
> No ethernet found.
> Retrieving file: pxelinux.cfg/default-arm-rk3399
> No ethernet found.
> Retrieving file: pxelinux.cfg/default-arm
> No ethernet found.
> Retrieving file: pxelinux.cfg/default
> No ethernet found.
> Config file not found
> No ethernet found.
> No ethernet found.
> SF: Detected gd25lq128e with page size 256 Bytes, erase size 4 KiB, total 16 MiB
> device 0 offset 0xffe000, size 0x2000
> SF: 8192 bytes @ 0xffe000 Read: OK
> ## Executing script at 00500000
> Wrong image format for "source" command
> SCRIPT FAILED: continuing...
>
> ERROR: Could not boot anything from distro_bootcmd.
>
No I flashed a random pinephone pro image that didn't use a uefi boot and modified the .conf file from grub to specify the copied over image.gz
Will paste a example later today and try to find what's the distro I flashed with balena
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] annerajb commented on pull request #10193: arch/arm64: Add support for PINE64 PinePhone Pro
Posted by "annerajb (via GitHub)" <gi...@apache.org>.
annerajb commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1712963949
https://github.com/webOS-ports/meta-pine64-luneos/releases/tag/20211220-v1
then I deleted the `boot.scr` and created a `extlinux` folder where I copied the following extlinux.conf
```
## /boot/extlinux/extlinux.conf
##
## IMPORTANT WARNING
##
## The configuration of this file is generated automatically.
## Do not edit this file manually, use: u-boot-update
default l0
menu title U-Boot menu
prompt 1
timeout 1
label l0
menu label Mobian GNU/Linux 6.1-rockchip
kernel /Image.gz
fdt /rk3399-pinephone-pro.dtb
```
copied the `Image.gz` to the root of the sdcard after using balena
I also added the device tree `rk3399-pinephonepro.dtb` from another image (I can't remember which one) not even sure if it matters since uboot has it's own dtsi and nuttx is not using it.. but the uboot extlinux.conf wanted to have a `fdt` line
[rk3399-pinephone-pro.zip](https://github.com/apache/nuttx/files/12570947/rk3399-pinephone-pro.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org