You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by "Jian Liu (JIRA)" <no...@atlassian.com> on 2007/09/11 06:24:29 UTC

[Roller-JIRA] Created: (ROL-1561) theme preview bug

theme preview bug
-----------------

                 Key: ROL-1561
                 URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1561
             Project: Roller
          Issue Type: Bug
         Environment: trunk
            Reporter: Jian Liu
            Assignee: Roller Unassigned


when i preview the theme, in the preview page, there are some url error in it
some method like category() in URLModel use the method getWeblogCollectionURL of urlStrategy
but PreviewURLStrategy class not implement this method,
for example, the correct url like   /roller-ui/authoring/preview/site/category/news?theme=testtheme
but in fact, the url is /roller-ui/authoring/preview/site/?theme=testthemecategory/news

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Roller-JIRA] Resolved: (ROL-1561) theme preview bug

Posted by "David Johnson (JIRA)" <no...@atlassian.com>.
     [ http://opensource.atlassian.com/projects/roller/browse/ROL-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Johnson resolved ROL-1561.
--------------------------------

    Resolution: Fixed

Evaluated, tested and applied the patch.
http://svn.apache.org/viewvc?rev=574619&view=rev

The patch fixes the URLs generated for category URLs, but the preview servlet still does not handle categories correctly. 

> theme preview bug
> -----------------
>
>                 Key: ROL-1561
>                 URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1561
>             Project: Roller
>          Issue Type: Bug
>         Environment: trunk
>            Reporter: Jian Liu
>            Assignee: David Johnson
>             Fix For: 4.0
>
>         Attachments: PreviewURLStrategy_java.patch
>
>
> when i preview the theme, in the preview page, there are some url error in it
> some method like category() in URLModel use the method getWeblogCollectionURL of urlStrategy
> but PreviewURLStrategy class not implement this method,
> for example, the correct url like   /roller-ui/authoring/preview/site/category/news?theme=testtheme
> but in fact, the url is /roller-ui/authoring/preview/site/?theme=testthemecategory/news

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Roller-JIRA] Updated: (ROL-1561) theme preview bug

Posted by "David Johnson (JIRA)" <no...@atlassian.com>.
     [ http://opensource.atlassian.com/projects/roller/browse/ROL-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Johnson updated ROL-1561:
-------------------------------

         Assignee: David Johnson  (was: Roller Unassigned)
    Fix Version/s: 4.0

> theme preview bug
> -----------------
>
>                 Key: ROL-1561
>                 URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1561
>             Project: Roller
>          Issue Type: Bug
>         Environment: trunk
>            Reporter: Jian Liu
>            Assignee: David Johnson
>             Fix For: 4.0
>
>         Attachments: PreviewURLStrategy_java.patch
>
>
> when i preview the theme, in the preview page, there are some url error in it
> some method like category() in URLModel use the method getWeblogCollectionURL of urlStrategy
> but PreviewURLStrategy class not implement this method,
> for example, the correct url like   /roller-ui/authoring/preview/site/category/news?theme=testtheme
> but in fact, the url is /roller-ui/authoring/preview/site/?theme=testthemecategory/news

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Roller-JIRA] Updated: (ROL-1561) theme preview bug

Posted by "Jian Liu (JIRA)" <no...@atlassian.com>.
     [ http://opensource.atlassian.com/projects/roller/browse/ROL-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jian Liu updated ROL-1561:
--------------------------

    Attachment: PreviewURLStrategy_java.patch

the patch file

> theme preview bug
> -----------------
>
>                 Key: ROL-1561
>                 URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1561
>             Project: Roller
>          Issue Type: Bug
>         Environment: trunk
>            Reporter: Jian Liu
>            Assignee: Roller Unassigned
>         Attachments: PreviewURLStrategy_java.patch
>
>
> when i preview the theme, in the preview page, there are some url error in it
> some method like category() in URLModel use the method getWeblogCollectionURL of urlStrategy
> but PreviewURLStrategy class not implement this method,
> for example, the correct url like   /roller-ui/authoring/preview/site/category/news?theme=testtheme
> but in fact, the url is /roller-ui/authoring/preview/site/?theme=testthemecategory/news

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Roller-JIRA] Work started: (ROL-1561) theme preview bug

Posted by "David Johnson (JIRA)" <no...@atlassian.com>.
     [ http://opensource.atlassian.com/projects/roller/browse/ROL-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on ROL-1561 started by David Johnson.

> theme preview bug
> -----------------
>
>                 Key: ROL-1561
>                 URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1561
>             Project: Roller
>          Issue Type: Bug
>         Environment: trunk
>            Reporter: Jian Liu
>            Assignee: David Johnson
>             Fix For: 4.0
>
>         Attachments: PreviewURLStrategy_java.patch
>
>
> when i preview the theme, in the preview page, there are some url error in it
> some method like category() in URLModel use the method getWeblogCollectionURL of urlStrategy
> but PreviewURLStrategy class not implement this method,
> for example, the correct url like   /roller-ui/authoring/preview/site/category/news?theme=testtheme
> but in fact, the url is /roller-ui/authoring/preview/site/?theme=testthemecategory/news

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira