You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/03/15 06:55:39 UTC
[kudu-CR](branch-1.7.x) Factor out consensus queue methods
Hello Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9650
to review the following change.
Change subject: Factor out consensus queue methods
......................................................................
Factor out consensus queue methods
This patch factors a couple of code blocks out into methods to reduce
the line count of PeerMessageQueue::ResponseFromPeer().
Change-Id: I278de150e3dc42181ccfbbd3a4c0e5cc4de90c1a
Reviewed-on: http://gerrit.cloudera.org:8080/9642
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 4c1788eae5bfd4cf4a714f1ca0ab775b005303b3)
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
2 files changed, 100 insertions(+), 72 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/9650/1
--
To view, visit http://gerrit.cloudera.org:8080/9650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I278de150e3dc42181ccfbbd3a4c0e5cc4de90c1a
Gerrit-Change-Number: 9650
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR](branch-1.7.x) Factor out consensus queue methods
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9650 )
Change subject: Factor out consensus queue methods
......................................................................
Patch Set 1: Verified+1
Some nonsense failure in LINT configuration with libtool:
00:03:01 libtool: Version mismatch error. This is libtool 2.4.2 Debian-2.4.2-1.7ubuntu1, but the
00:03:01 libtool: definition of this LT_INIT comes from libtool 2.4.6.
00:03:01 libtool: You should recreate aclocal.m4 with macros from libtool 2.4.2 Debian-2.4.2-1.7ubuntu1
00:03:01 libtool: and run autoconf again.
Ignoring
--
To view, visit http://gerrit.cloudera.org:8080/9650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I278de150e3dc42181ccfbbd3a4c0e5cc4de90c1a
Gerrit-Change-Number: 9650
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 15 Mar 2018 07:48:53 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.7.x) Factor out consensus queue methods
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9650 )
Change subject: Factor out consensus queue methods
......................................................................
Factor out consensus queue methods
This patch factors a couple of code blocks out into methods to reduce
the line count of PeerMessageQueue::ResponseFromPeer().
Change-Id: I278de150e3dc42181ccfbbd3a4c0e5cc4de90c1a
Reviewed-on: http://gerrit.cloudera.org:8080/9642
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 4c1788eae5bfd4cf4a714f1ca0ab775b005303b3)
Reviewed-on: http://gerrit.cloudera.org:8080/9650
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Grant Henke <gr...@gmail.com>
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
2 files changed, 100 insertions(+), 72 deletions(-)
Approvals:
Alexey Serbin: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I278de150e3dc42181ccfbbd3a4c0e5cc4de90c1a
Gerrit-Change-Number: 9650
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.7.x) Factor out consensus queue methods
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9650 )
Change subject: Factor out consensus queue methods
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I278de150e3dc42181ccfbbd3a4c0e5cc4de90c1a
Gerrit-Change-Number: 9650
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 15 Mar 2018 15:44:07 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.7.x) Factor out consensus queue methods
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9650 )
Change subject: Factor out consensus queue methods
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I278de150e3dc42181ccfbbd3a4c0e5cc4de90c1a
Gerrit-Change-Number: 9650
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>