You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by Apache Wiki <wi...@apache.org> on 2008/11/20 08:42:00 UTC
[Hadoop Wiki] Update of "CodeReviewChecklist" by SharadAgarwal
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Hadoop Wiki" for change notification.
The following page has been changed by SharadAgarwal:
http://wiki.apache.org/hadoop/CodeReviewChecklist
------------------------------------------------------------------------------
* if {{{equals}}} is overridden then {{{hashCode}}} is overridden (and vice versa)
* objects are checked ({{{instanceof}}}) for appropriate type before casting (use generics if possible)
* public API changes have been publically discussed
+ * use of static member variables should be used with caution especially in Map/reduce tasks due to the JVM reuse feature
== Tests ==