You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "Alasdair Nottingham (JIRA)" <ji...@apache.org> on 2010/02/19 14:44:28 UTC
[jira] Created: (ARIES-192) Convert bundles before generating the
application content
Convert bundles before generating the application content
---------------------------------------------------------
Key: ARIES-192
URL: https://issues.apache.org/jira/browse/ARIES-192
Project: Aries
Issue Type: Bug
Components: Application
Reporter: Alasdair Nottingham
Assignee: Alasdair Nottingham
We currently convert by value artefacts after generating the Application-Content which means we will not pull in converted artefacts when no Application-Content is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ARIES-192) Convert bundles before generating the
application content
Posted by "Emily Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emily Jiang updated ARIES-192:
------------------------------
Attachment: (was: management.diff)
> Convert bundles before generating the application content
> ---------------------------------------------------------
>
> Key: ARIES-192
> URL: https://issues.apache.org/jira/browse/ARIES-192
> Project: Aries
> Issue Type: Bug
> Components: Application
> Reporter: Alasdair Nottingham
> Assignee: Alasdair Nottingham
>
> We currently convert by value artefacts after generating the Application-Content which means we will not pull in converted artefacts when no Application-Content is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-192) Convert bundles before generating the
application content
Posted by "Emily Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885469#action_12885469 ]
Emily Jiang commented on ARIES-192:
-----------------------------------
I have fixed the problem and also added a test to verify the fix.
Thanks
Emily
> Convert bundles before generating the application content
> ---------------------------------------------------------
>
> Key: ARIES-192
> URL: https://issues.apache.org/jira/browse/ARIES-192
> Project: Aries
> Issue Type: Bug
> Components: Application
> Reporter: Alasdair Nottingham
> Assignee: Alasdair Nottingham
> Attachments: management.diff
>
>
> We currently convert by value artefacts after generating the Application-Content which means we will not pull in converted artefacts when no Application-Content is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (ARIES-192) Convert bundles before generating the
application content
Posted by "Mark Nuttall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Nuttall closed ARIES-192.
------------------------------
Resolution: Fixed
> Convert bundles before generating the application content
> ---------------------------------------------------------
>
> Key: ARIES-192
> URL: https://issues.apache.org/jira/browse/ARIES-192
> Project: Aries
> Issue Type: Bug
> Components: Application
> Reporter: Alasdair Nottingham
> Assignee: Mark Nuttall
> Attachments: management.diff
>
>
> We currently convert by value artefacts after generating the Application-Content which means we will not pull in converted artefacts when no Application-Content is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-192) Convert bundles before generating the
application content
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887926#action_12887926 ]
Jarek Gawor commented on ARIES-192:
-----------------------------------
I don't think this patch really addressed the problem. The only reason the included test was passing was that the DummyConverter was rewriting the entire eba file with the updated war file with the proper manifest information. The test should only be generating and returning the updated war file.
There are actually two main problems here: 1) The ManifestDefaultsInjector includes only valid bundles in the Application-Content header. So it might generate incomplete header if the eba contains non-bundles such as war files. The Application-Content should really be built based on extraBundlesInfo created in AriesApplicationManagerImpl.createApplication() since it will contains info for regular and converted bundles. 2) The extraBundlesInfo will not actually contain the right information for any converted bundles. That is because the BundleInfo created for the converted bundle is actually created with the manifest information of the source/unconverted file (I already mentioned this problem in point #2 in ARIES-257 a while ago). It should be using the manifest from the converted bundle and therefore there should be a call somewhere to BundleConversion.getBundleInfo().
> Convert bundles before generating the application content
> ---------------------------------------------------------
>
> Key: ARIES-192
> URL: https://issues.apache.org/jira/browse/ARIES-192
> Project: Aries
> Issue Type: Bug
> Components: Application
> Reporter: Alasdair Nottingham
> Assignee: Mark Nuttall
> Attachments: management.diff
>
>
> We currently convert by value artefacts after generating the Application-Content which means we will not pull in converted artefacts when no Application-Content is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-192) Convert bundles before generating the
application content
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887932#action_12887932 ]
Jarek Gawor commented on ARIES-192:
-----------------------------------
I committed fixes for the issues I mentioned in revision 963819.
> Convert bundles before generating the application content
> ---------------------------------------------------------
>
> Key: ARIES-192
> URL: https://issues.apache.org/jira/browse/ARIES-192
> Project: Aries
> Issue Type: Bug
> Components: Application
> Reporter: Alasdair Nottingham
> Assignee: Mark Nuttall
> Attachments: management.diff
>
>
> We currently convert by value artefacts after generating the Application-Content which means we will not pull in converted artefacts when no Application-Content is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ARIES-192) Convert bundles before generating the
application content
Posted by "Emily Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emily Jiang updated ARIES-192:
------------------------------
Attachment: management.diff
Fixed this defect and also made org.apache.aries.application projects' junits running successfully in eclipse by correcting the depencies for org.apache.aries.application.utils and org.apache.aries.application.api from org.osgi.core from version 4.0.0 to 4.2.0.
Thanks
Emily
> Convert bundles before generating the application content
> ---------------------------------------------------------
>
> Key: ARIES-192
> URL: https://issues.apache.org/jira/browse/ARIES-192
> Project: Aries
> Issue Type: Bug
> Components: Application
> Reporter: Alasdair Nottingham
> Assignee: Alasdair Nottingham
> Attachments: management.diff
>
>
> We currently convert by value artefacts after generating the Application-Content which means we will not pull in converted artefacts when no Application-Content is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ARIES-192) Convert bundles before generating the
application content
Posted by "Emily Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emily Jiang updated ARIES-192:
------------------------------
Attachment: management.diff
> Convert bundles before generating the application content
> ---------------------------------------------------------
>
> Key: ARIES-192
> URL: https://issues.apache.org/jira/browse/ARIES-192
> Project: Aries
> Issue Type: Bug
> Components: Application
> Reporter: Alasdair Nottingham
> Assignee: Alasdair Nottingham
> Attachments: management.diff
>
>
> We currently convert by value artefacts after generating the Application-Content which means we will not pull in converted artefacts when no Application-Content is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-192) Convert bundles before generating the
application content
Posted by "Emily Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888002#action_12888002 ]
Emily Jiang commented on ARIES-192:
-----------------------------------
Hi Jerek,
I think it is fair to say that the attached pacth and test were intended to fix the problem described by this jira "We currently convert by value artefacts after generating the Application-Content which means we will not pull in converted artefacts when no Application-Content is provided. We should convert the bundle before generating the application content". I was not aware of the issues that bundles were not converted properly as mentioned above. Personally, I think the problem you described earlier is related to this jira but is a different problem. Just thought to clarify.
Thanks
Emily
> Convert bundles before generating the application content
> ---------------------------------------------------------
>
> Key: ARIES-192
> URL: https://issues.apache.org/jira/browse/ARIES-192
> Project: Aries
> Issue Type: Bug
> Components: Application
> Reporter: Alasdair Nottingham
> Assignee: Mark Nuttall
> Attachments: management.diff
>
>
> We currently convert by value artefacts after generating the Application-Content which means we will not pull in converted artefacts when no Application-Content is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ARIES-192) Convert bundles before generating the
application content
Posted by "Mark Nuttall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Nuttall reassigned ARIES-192:
----------------------------------
Assignee: Mark Nuttall (was: Alasdair Nottingham)
> Convert bundles before generating the application content
> ---------------------------------------------------------
>
> Key: ARIES-192
> URL: https://issues.apache.org/jira/browse/ARIES-192
> Project: Aries
> Issue Type: Bug
> Components: Application
> Reporter: Alasdair Nottingham
> Assignee: Mark Nuttall
> Attachments: management.diff
>
>
> We currently convert by value artefacts after generating the Application-Content which means we will not pull in converted artefacts when no Application-Content is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.