You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2025/03/05 02:27:47 UTC

[PR] ci: ensure GitHub Actions and pre-commit hooks are pinned [arrow-adbc]

lidavidm opened a new pull request, #2576:
URL: https://github.com/apache/arrow-adbc/pull/2576

   Apache wants us to limit concurrency, ensure actions are pinned, and ensure we aren't exporting GITHUB_TOKEN etc. (https://infra.apache.org/github-actions-policy.html) It's not clear to me if our use of GITHUB_TOKEN in dev_pr.yaml falls under that.
   
   Fixes #2575.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: ensure GitHub Actions and pre-commit hooks are pinned [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #2576:
URL: https://github.com/apache/arrow-adbc/pull/2576#issuecomment-2713120058

   @kou or @zeroshade, any more comments here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: ensure GitHub Actions and pre-commit hooks are pinned [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #2576:
URL: https://github.com/apache/arrow-adbc/pull/2576#discussion_r1988729035


##########
.github/workflows/native-unix.yml:
##########
@@ -392,7 +392,7 @@ jobs:
         with:
           fetch-depth: 0
           persist-credentials: false
-      - uses: 'google-github-actions/auth@v2'
+      - uses: google-github-actions/auth@6fc4af4b145ae7821d527454aa9bd537d1f2dc5f  # v2

Review Comment:
   Oh I misread the diff



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: ensure GitHub Actions and pre-commit hooks are pinned [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #2576:
URL: https://github.com/apache/arrow-adbc/pull/2576#discussion_r1988682804


##########
.github/workflows/native-unix.yml:
##########
@@ -392,7 +392,7 @@ jobs:
         with:
           fetch-depth: 0
           persist-credentials: false
-      - uses: 'google-github-actions/auth@v2'
+      - uses: google-github-actions/auth@6fc4af4b145ae7821d527454aa9bd537d1f2dc5f  # v2

Review Comment:
   Hmm, I wonder how the hook missed that...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: ensure GitHub Actions and pre-commit hooks are pinned [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #2576:
URL: https://github.com/apache/arrow-adbc/pull/2576


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: ensure GitHub Actions and pre-commit hooks are pinned [arrow-adbc]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #2576:
URL: https://github.com/apache/arrow-adbc/pull/2576#issuecomment-2714513552

   Hmm..that's a very strange error. It's not an actual problem in the sense that I don't think anything is not working, there must be something about the output that's being generated from the example or test that R CMD check doesn't know what to do with. I will take a look today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: ensure GitHub Actions and pre-commit hooks are pinned [arrow-adbc]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #2576:
URL: https://github.com/apache/arrow-adbc/pull/2576#discussion_r1980610847


##########
.github/workflows/dev_adbc.yml:
##########
@@ -55,7 +55,7 @@ jobs:
         with:
           path: ~/conda_pkgs_dir
           key: conda-${{ runner.os }}-${{ steps.get-date.outputs.today }}-${{ env.CACHE_NUMBER }}-${{ hashFiles('ci/**') }}
-      - uses: conda-incubator/setup-miniconda@v3
+      - uses: conda-incubator/setup-miniconda@e5457fe695e3787d415a42160e580fd154de1899  # v3

Review Comment:
   It seems that the revision doesn't exist: https://github.com/conda-incubator/setup-miniconda/commit/e5457fe695e3787d415a42160e580fd154de1899
   
   ```suggestion
         - uses: conda-incubator/setup-miniconda@505e6394dae86d6a5c7fbb6e3fb8938e3e863830  # v3.1.1
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: ensure GitHub Actions and pre-commit hooks are pinned [arrow-adbc]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #2576:
URL: https://github.com/apache/arrow-adbc/pull/2576#issuecomment-2716306264

   Ok, the offending error message is:
   
   ```
   time="2025-03-11T12:51:47Z" level=info msg="Credentials cache path: /home/runner/.cache/snowflake/temporary_credential.json" func="gosnowflake.(*defaultLogger).Infof" file="log.go:182"
   ```
   
   In R you're not supposed to write to stderr directly, you're supposed to write to R's specific stderr stream (so that those messages can be captured by R things), and I am wondering if something in R CMD check is getting some mashup of the log message and what it intended to read by accident. This doesn't reproduce locally for me (maybe because I have no credentials when I run the examples, though).
   
   This is probably unrelated to this particular change (the R checks maybe haven't run on main for a while since I haven't updated anything 😬 ). I'll open a follow-up (and maybe a short-term solution would be to set the log level to `warning` rather than `info`?).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: ensure GitHub Actions and pre-commit hooks are pinned [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #2576:
URL: https://github.com/apache/arrow-adbc/pull/2576#issuecomment-2716316088

   Thanks for digging into it!
   
   I think the log message is coming from [gosnowflake](https://github.com/snowflakedb/gosnowflake/blob/8ed4c75ffd707dd712ad843f40189843ace683c4/secure_storage_manager.go#L96), though, so maybe the easiest thing is just a PR to remove the stray log (I can do this in a bit)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: ensure GitHub Actions and pre-commit hooks are pinned [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #2576:
URL: https://github.com/apache/arrow-adbc/pull/2576#issuecomment-2716517133

   Filed https://github.com/snowflakedb/gosnowflake/pull/1332


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: ensure GitHub Actions and pre-commit hooks are pinned [arrow-adbc]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #2576:
URL: https://github.com/apache/arrow-adbc/pull/2576#discussion_r1988677035


##########
.github/workflows/native-unix.yml:
##########
@@ -449,7 +449,7 @@ jobs:
         with:
           fetch-depth: 0
           persist-credentials: false
-      - uses: 'google-github-actions/auth@v2'
+      - uses: google-github-actions/auth@6fc4af4b145ae7821d527454aa9bd537d1f2dc5f  # v2

Review Comment:
   ```suggestion
         - uses: google-github-actions/auth@71f986410dfbc7added4569d411d040a91dc6935  # v2.1.8
   ```



##########
.github/workflows/packaging.yml:
##########
@@ -354,7 +354,7 @@ jobs:
           restore-keys: linux-${{ env.TASK_NAMESPACE }}-ccache-${{ matrix.target }}-
 
       - name: Login to GitHub Container registry
-        uses: docker/login-action@v3
+        uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567  # v3

Review Comment:
   ```suggestion
           uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567  # v3.3.0
   ```



##########
.github/workflows/native-unix.yml:
##########
@@ -392,7 +392,7 @@ jobs:
         with:
           fetch-depth: 0
           persist-credentials: false
-      - uses: 'google-github-actions/auth@v2'
+      - uses: google-github-actions/auth@6fc4af4b145ae7821d527454aa9bd537d1f2dc5f  # v2

Review Comment:
   ```suggestion
         - uses: google-github-actions/auth@71f986410dfbc7added4569d411d040a91dc6935  # v2.1.8
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: ensure GitHub Actions and pre-commit hooks are pinned [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #2576:
URL: https://github.com/apache/arrow-adbc/pull/2576#issuecomment-2714146049

   @paleolimbot am I right in thinking the failures are actual problems? (Also, I think you've brought up that Snowflake logging output before...we should report upstream/try to suppress it)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org